Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle non-object loader data in useDefaultValuesFromLoader #267

Merged
merged 2 commits into from
Apr 8, 2023

Conversation

haines
Copy link
Contributor

@haines haines commented Mar 22, 2023

Fixes #266

Signed-off-by: Andrew Haines <andrew@haines.org.nz>
@vercel
Copy link

vercel bot commented Mar 22, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
remix-validated-form ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 22, 2023 at 2:38PM (UTC)

@airjp73
Copy link
Owner

airjp73 commented Mar 22, 2023

Thanks! If possible, could you please add a test for this case?

Signed-off-by: Andrew Haines <andrew@haines.org.nz>
@haines
Copy link
Contributor Author

haines commented Mar 22, 2023

@airjp73 done 🙂

@airjp73
Copy link
Owner

airjp73 commented Apr 8, 2023

Sorry for the delay. Thanks for working on this!

@airjp73 airjp73 merged commit ae27716 into airjp73:main Apr 8, 2023
@haines haines deleted the handle-non-object-loader-data branch April 8, 2023 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: ValidatedForm with id prop set fails to render when loader data is not an object
2 participants