Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(zustand): Import named create instead of default #233

Merged
merged 2 commits into from
Jan 17, 2023

Conversation

machour
Copy link
Contributor

@machour machour commented Jan 13, 2023

Closes #231

By the way, 4.6.6 and 4.6.7 don't seem to be published in the repo Release tab.

@vercel
Copy link

vercel bot commented Jan 13, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
remix-validated-form ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Jan 16, 2023 at 5:24PM (UTC)

@machour
Copy link
Contributor Author

machour commented Jan 13, 2023

Can't look at the Vercel error, I get a 404 :/

@airjp73
Copy link
Owner

airjp73 commented Jan 14, 2023

Hi! Thanks for this. It looks like this is resulting in a type error though. Has the signature for this function changed at all?

@machour
Copy link
Contributor Author

machour commented Jan 14, 2023

It doesn't seem to be the case when I look at the PR that changed it: https://github.com/pmndrs/zustand/pull/1514/files

@airjp73
Copy link
Owner

airjp73 commented Jan 16, 2023

I think I see the issue. That PR is very recent (last week), but we're still on 4.0.0-rc. Could you upgrade zustand as well?

@machour
Copy link
Contributor Author

machour commented Jan 16, 2023

Oh, totally missed that, thanks 🙏🏼
Bumped to the version where the default export was deprecated.

@airjp73
Copy link
Owner

airjp73 commented Jan 17, 2023

Thanks!

@airjp73 airjp73 merged commit 540fbf4 into airjp73:main Jan 17, 2023
@machour machour deleted the fix-231 branch January 17, 2023 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Zustand deprecated the default export for create
2 participants