Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix settings link in the connection row #9941

Merged
merged 2 commits into from
Feb 2, 2022
Merged

Conversation

juliachvyrova
Copy link
Contributor

What

Fix Settings link in the connection row in Connections Page.

Closes #9637

@juliachvyrova juliachvyrova self-assigned this Jan 31, 2022
@juliachvyrova juliachvyrova requested a review from jrhizor January 31, 2022 22:10
@github-actions github-actions bot added area/frontend area/platform issues related to the platform labels Jan 31, 2022
import { RoutePaths } from "pages/routes";
import { useCurrentWorkspace } from "hooks/services/useWorkspace";
import Link from "components/Link";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this could be imported as

import { Link } from "components" instead

@juliachvyrova juliachvyrova temporarily deployed to more-secrets February 1, 2022 20:59 Inactive
@juliachvyrova juliachvyrova temporarily deployed to more-secrets February 2, 2022 16:31 Inactive
@jamakase jamakase merged commit edfe96b into master Feb 2, 2022
@jamakase jamakase deleted the julia/fix-settings-icon branch February 2, 2022 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/platform issues related to the platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Click on settings icon in connection list brings you to default page
3 participants