-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sentry release for connectors #9940
Conversation
/publish connector=connectors/source-e2e-test
|
/publish connector=connectors/source-e2e-test
|
/publish connector=connectors/source-e2e-test
|
/publish connector=connectors/source-e2e-test
|
/publish connector=connectors/source-e2e-test
|
/publish connector=connectors/destination-e2e-test
|
/publish connector=connectors/destination-e2e-test
|
/publish connector=connectors/destination-dev-null
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not familiar with how sentry works, is this basically doing:
- install/setup sentry tooling
- create a release with name like
source-whatever@1.2.3
and associate it with a range of git commits (?) - do the normal connector publish stuff
- finish the sentry release
and (presumably) if any of the sentry steps fail, then the entire release fails? (which seems like a good thing, just want to confirm)
Yes. I have installed the Sentry integration for Github. So Sentry can automatically associate the new commits for a new release. One flaw in the current process is that we typically publish a connector in a PR, and do a squash merge. So some of the PR commits will be included in the release, which won't exist in the master branch after the PR is merged. However, I cannot think of a quick way to solve this problem.
I think Sentry is flexible most of the time. As long as it is installed correctly, it won't fail if there is an issue.
I'd prefer not to. If we commit it, it becomes an implicit dependency we need to maintain. Sentry is usually pretty robust. We will re-evaluate if there are frequent failures. |
Summary