Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sentry release for connectors #9940

Merged
merged 10 commits into from
Feb 1, 2022
Merged

Add sentry release for connectors #9940

merged 10 commits into from
Feb 1, 2022

Conversation

tuliren
Copy link
Contributor

@tuliren tuliren commented Jan 31, 2022

Summary

@tuliren
Copy link
Contributor Author

tuliren commented Jan 31, 2022

/publish connector=connectors/source-e2e-test

🕑 connectors/source-e2e-test https://github.com/airbytehq/airbyte/actions/runs/1775135842

@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets January 31, 2022 22:05 Inactive
@tuliren
Copy link
Contributor Author

tuliren commented Jan 31, 2022

/publish connector=connectors/source-e2e-test

🕑 connectors/source-e2e-test https://github.com/airbytehq/airbyte/actions/runs/1775172948

@tuliren tuliren temporarily deployed to more-secrets January 31, 2022 22:12 Inactive
@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets January 31, 2022 22:13 Inactive
@tuliren tuliren temporarily deployed to more-secrets January 31, 2022 22:25 Inactive
@tuliren
Copy link
Contributor Author

tuliren commented Jan 31, 2022

/publish connector=connectors/source-e2e-test

🕑 connectors/source-e2e-test https://github.com/airbytehq/airbyte/actions/runs/1775261117

@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets January 31, 2022 22:35 Inactive
@tuliren
Copy link
Contributor Author

tuliren commented Jan 31, 2022

/publish connector=connectors/source-e2e-test

🕑 connectors/source-e2e-test https://github.com/airbytehq/airbyte/actions/runs/1775294220

@tuliren tuliren temporarily deployed to more-secrets January 31, 2022 22:44 Inactive
@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets January 31, 2022 22:45 Inactive
@tuliren
Copy link
Contributor Author

tuliren commented Jan 31, 2022

/publish connector=connectors/source-e2e-test

🕑 connectors/source-e2e-test https://github.com/airbytehq/airbyte/actions/runs/1775325674

@tuliren tuliren temporarily deployed to more-secrets January 31, 2022 22:53 Inactive
@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets January 31, 2022 22:54 Inactive
@tuliren tuliren temporarily deployed to more-secrets January 31, 2022 23:00 Inactive
@tuliren
Copy link
Contributor Author

tuliren commented Jan 31, 2022

/publish connector=connectors/destination-e2e-test

Error: Workflow does not have 'workflow_dispatch' trigger

@tuliren tuliren requested review from jrhizor and edgao January 31, 2022 23:03
@tuliren
Copy link
Contributor Author

tuliren commented Jan 31, 2022

/publish connector=connectors/destination-e2e-test

🕑 connectors/destination-e2e-test https://github.com/airbytehq/airbyte/actions/runs/1775386448
✅ connectors/destination-e2e-test https://github.com/airbytehq/airbyte/actions/runs/1775386448

@tuliren tuliren temporarily deployed to more-secrets January 31, 2022 23:09 Inactive
@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets January 31, 2022 23:10 Inactive
@tuliren tuliren marked this pull request as ready for review January 31, 2022 23:14
@tuliren
Copy link
Contributor Author

tuliren commented Jan 31, 2022

/publish connector=connectors/destination-dev-null

🕑 connectors/destination-dev-null https://github.com/airbytehq/airbyte/actions/runs/1775421535
✅ connectors/destination-dev-null https://github.com/airbytehq/airbyte/actions/runs/1775421535

@tuliren tuliren temporarily deployed to more-secrets January 31, 2022 23:18 Inactive
@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets January 31, 2022 23:20 Inactive
@github-actions github-actions bot added the area/documentation Improvements or additions to documentation label Jan 31, 2022
@tuliren tuliren temporarily deployed to more-secrets January 31, 2022 23:35 Inactive
@tuliren tuliren temporarily deployed to more-secrets January 31, 2022 23:57 Inactive
Copy link
Contributor

@edgao edgao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not familiar with how sentry works, is this basically doing:

  1. install/setup sentry tooling
  2. create a release with name like source-whatever@1.2.3 and associate it with a range of git commits (?)
  3. do the normal connector publish stuff
  4. finish the sentry release

and (presumably) if any of the sentry steps fail, then the entire release fails? (which seems like a good thing, just want to confirm)

@tuliren
Copy link
Contributor Author

tuliren commented Feb 1, 2022

create a release with name like source-whatever@1.2.3 and associate it with a range of git commits (?)

Yes. I have installed the Sentry integration for Github. So Sentry can automatically associate the new commits for a new release. One flaw in the current process is that we typically publish a connector in a PR, and do a squash merge. So some of the PR commits will be included in the release, which won't exist in the master branch after the PR is merged. However, I cannot think of a quick way to solve this problem.

if any of the sentry steps fail, then the entire release fails?

I think Sentry is flexible most of the time. As long as it is installed correctly, it won't fail if there is an issue.

does it make sense to commit this file to git? Then if e.g. sentry.io goes down, our ability to release isn't impacted

I'd prefer not to. If we commit it, it becomes an implicit dependency we need to maintain. Sentry is usually pretty robust. We will re-evaluate if there are frequent failures.

@tuliren tuliren merged commit aa3e00d into master Feb 1, 2022
@tuliren tuliren deleted the liren/add-sentry-release branch February 1, 2022 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants