Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tim/webapp/upgrade dependencies #9919

Closed
wants to merge 8 commits into from

Conversation

timroes
Copy link
Contributor

@timroes timroes commented Jan 31, 2022

What

Notes This superseeds #9916 (which was wrongly opened from a fork 😭 ). Please check the inline comments on that other PR!

Upgrade a bunch of used dependencies. It leaves a couple of major version updates of some dependencies unsolved, since they require more changes than I wanted to put into one PR. Especially since this PR includes a prettier update and thus a lot of files got reformatted.

How

See inline comments for more details where I actually changed code, and it wasn't simply a reformatting. I've also did a couple of minor updates where the code was anyway touched due to upgrade (also see inline comments).

I've tested that the pre commit hooks, building, running and running storybook are still working after this update.

@timroes timroes requested review from jamakase and jrhizor January 31, 2022 11:29
@github-actions github-actions bot added area/frontend area/platform issues related to the platform labels Jan 31, 2022
@timroes timroes temporarily deployed to more-secrets January 31, 2022 11:29 Inactive
@timroes
Copy link
Contributor Author

timroes commented Jan 31, 2022

And closing this again. Since we don't run Checks on PRs, but on the branches, it was actually enough to also push the very same commit additionally into the upstream repository, to get the checks properly run on the previous PR.

@timroes timroes closed this Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/platform issues related to the platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant