Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Source Zendesk support: add log message for 429 status code #9785

Merged
merged 4 commits into from
Feb 2, 2022

Conversation

annalvova05
Copy link
Contributor

What

Getting stuck everytime in report ticket_metrics.

How

Add log message for 429 status code - how many seconds we should wait.

Recommended reading order

  1. streams.py

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here
  • After the new connector version is published, connector version bumped in the seed directory as described here
  • Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

@github-actions github-actions bot added the area/connectors Connector related issues label Jan 25, 2022
@annalvova05 annalvova05 changed the title Source Zendesk support: add log message for 429 status code 🐛 Source Zendesk support: add log message for 429 status code Jan 25, 2022
@github-actions github-actions bot added the area/documentation Improvements or additions to documentation label Jan 25, 2022
@annalvova05 annalvova05 temporarily deployed to more-secrets January 25, 2022 12:31 Inactive
@codecov
Copy link

codecov bot commented Jan 25, 2022

Codecov Report

❗ No coverage uploaded for pull request base (master@f4365c5). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head c4d5336 differs from pull request most recent head 55a7ac9. Consider uploading reports for the commit 55a7ac9 to get more accurate results
Impacted file tree graph

@@            Coverage Diff            @@
##             master    #9785   +/-   ##
=========================================
  Coverage          ?   54.15%           
=========================================
  Files             ?        3           
  Lines             ?      349           
  Branches          ?        0           
=========================================
  Hits              ?      189           
  Misses            ?      160           
  Partials          ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f4365c5...55a7ac9. Read the comment docs.

@annalvova05 annalvova05 requested a review from antixar February 1, 2022 09:56
@antixar
Copy link
Contributor

antixar commented Feb 1, 2022

@annalvova05 , Please publish your changes

@annalvova05
Copy link
Contributor Author

annalvova05 commented Feb 2, 2022

/test connector=connectors/source-zendesk-support

🕑 connectors/source-zendesk-support https://github.com/airbytehq/airbyte/actions/runs/1783418726
❌ connectors/source-zendesk-support https://github.com/airbytehq/airbyte/actions/runs/1783418726
🐛 https://gradle.com/s/nhpgxvwxyuhl4

@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets February 2, 2022 10:45 Inactive
@annalvova05
Copy link
Contributor Author

annalvova05 commented Feb 2, 2022

/test connector=connectors/source-zendesk-support

🕑 connectors/source-zendesk-support https://github.com/airbytehq/airbyte/actions/runs/1783582738
✅ connectors/source-zendesk-support https://github.com/airbytehq/airbyte/actions/runs/1783582738
Python tests coverage:

	 Name                                                 Stmts   Miss  Cover
	 ------------------------------------------------------------------------
	 source_acceptance_test/__init__.py                       2      0   100%
	 source_acceptance_test/base.py                          10      4    60%
	 source_acceptance_test/config.py                        74      6    92%
	 source_acceptance_test/tests/__init__.py                 4      0   100%
	 source_acceptance_test/tests/test_core.py              275    106    61%
	 source_acceptance_test/tests/test_full_refresh.py       52      2    96%
	 source_acceptance_test/tests/test_incremental.py        69     38    45%
	 source_acceptance_test/utils/__init__.py                 6      0   100%
	 source_acceptance_test/utils/asserts.py                 37      2    95%
	 source_acceptance_test/utils/common.py                  70     17    76%
	 source_acceptance_test/utils/compare.py                 62     23    63%
	 source_acceptance_test/utils/connector_runner.py       110     48    56%
	 source_acceptance_test/utils/json_schema_helper.py     105     13    88%
	 ------------------------------------------------------------------------
	 TOTAL                                                  876    259    70%
	 Name                                 Stmts   Miss  Cover
	 --------------------------------------------------------
	 source_zendesk_support/__init__.py       2      0   100%
	 source_zendesk_support/source.py        38     15    61%
	 source_zendesk_support/streams.py      310     98    68%
	 --------------------------------------------------------
	 TOTAL                                  350    113    68%
	 Name                                 Stmts   Miss  Cover
	 --------------------------------------------------------
	 source_zendesk_support/__init__.py       2      0   100%
	 source_zendesk_support/source.py        38     13    66%
	 source_zendesk_support/streams.py      310    106    66%
	 --------------------------------------------------------
	 TOTAL                                  350    119    66%

@annalvova05 annalvova05 temporarily deployed to more-secrets February 2, 2022 11:24 Inactive
@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets February 2, 2022 11:24 Inactive
@annalvova05
Copy link
Contributor Author

annalvova05 commented Feb 2, 2022

/publish connector=connectors/source-zendesk-support

🕑 connectors/source-zendesk-support https://github.com/airbytehq/airbyte/actions/runs/1784030854
✅ connectors/source-zendesk-support https://github.com/airbytehq/airbyte/actions/runs/1784030854

@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets February 2, 2022 13:14 Inactive
@annalvova05 annalvova05 merged commit f0113c9 into master Feb 2, 2022
@annalvova05 annalvova05 deleted the alvova/9052-zendesk-support branch February 2, 2022 13:54
@annalvova05 annalvova05 temporarily deployed to more-secrets February 2, 2022 13:55 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 Source Zendesk support: getting stuck everytime in report ticket_metrics
5 participants