Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build error in airbyte-integrations module #9713

Closed
wants to merge 1 commit into from

Conversation

khwj
Copy link

@khwj khwj commented Jan 22, 2022

What

DestinationAcceptanceTest and AbstractSourceConnectorTest classes are still
using isOrchestrator option despite being removed in #9695 causing errors when testing with airbyte-integrations module.

How

Initialize DockerProcessFactory without isOrchestrator option.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

Community member or Airbyter

  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here
  • After the new connector version is published, connector version bumped in the seed directory as described here
  • Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

`DestinationAcceptanceTest` and `AbstractSourceConnectorTest` are still
using `isOrchestrator` despite being removed in airbytehq#9695.
@CLAassistant
Copy link

CLAassistant commented Jan 22, 2022

CLA assistant check
All committers have signed the CLA.

@khwj khwj marked this pull request as ready for review January 22, 2022 09:45
@marcosmarxm marcosmarxm requested a review from jrhizor January 24, 2022 12:59
@jrhizor
Copy link
Contributor

jrhizor commented Jan 24, 2022

Wasn't this already fixed in #9704 three days ago?

@marcosmarxm
Copy link
Member

any return here @khwj ?

@khwj
Copy link
Author

khwj commented Jan 26, 2022

@jrhizor think so, not sure why I didn't get the updates. I'll close the PR.

@khwj khwj closed this Jan 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants