-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Source Salesforce: Fix error during generating schema #9478
🐛 Source Salesforce: Fix error during generating schema #9478
Conversation
/test connector=connectors/source-salesforce |
airbyte-integrations/connectors/source-salesforce/source_salesforce/api.py
Outdated
Show resolved
Hide resolved
/test connector=connectors/source-salesforce
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Filtering by the "queryable" option is assumption. Can we print all stream options when SF returns 404 error?
We did not save all options for streams (only names). And that user data (need approve from Sherif). |
/test connector=connectors/source-salesforce
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
airbyte-integrations/connectors/source-salesforce/source_salesforce/api.py
Outdated
Show resolved
Hide resolved
/publish connector=connectors/source-salesforce
|
What
After collecting all available streams we try to get the schema for the stream, but some of the streams can have flags
"queriable": false
that depends on permissions of users roles.How
Filter streams by
queriable
flags during collecting all available streams.Recommended reading order
x.java
y.python
Pre-merge Checklist
New Connector
Community member or Airbyter
airbyte_secret
./gradlew :airbyte-integrations:connectors:<name>:integrationTest
.README.md
bootstrap.md
. See description and examplesdocs/integrations/<source or destination>/<name>.md
including changelog. See changelog exampleThis change is