Only migrate active and disable connection #9454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/platform
lmossman
reviewed
Jan 12, 2022
| @@ -234,13 +232,13 @@ public static void main(final String[] args) throws IOException, InterruptedExce | |||
| configs.getDatabaseUser(), | |||
| configs.getDatabasePassword(), | |||
| configs.getDatabaseUrl()) | |||
| .getInitialized(); | |||
| .getInitialized(); | |||
There was a problem hiding this comment.
Probably need to run gw format
lmossman
reviewed
Jan 12, 2022
| @@ -235,14 +236,15 @@ private static void migrateExistingConnection(final ConfigRepository configRepos | |||
| throws JsonValidationException, ConfigNotFoundException, IOException { | |||
| LOGGER.info("Start migration to the new scheduler..."); | |||
| final Set<UUID> connectionIds = | |||
| configRepository.listStandardSyncs().stream().map(standardSync -> standardSync.getConnectionId()).collect(Collectors.toSet()); | |||
| configRepository.listStandardSyncs().stream() | |||
| .filter(standardSync -> standardSync.getStatus() == Status.ACTIVE || standardSync.getStatus() == Status.INACTIVE) | |||
There was a problem hiding this comment.
What is the reasoning behind filtering down to only ACTIVE and INACTIVE?
There was a problem hiding this comment.
ACTIVE = enabled connections
INACTIVE = disabled connections
DEPRECATED = deleted connections
We need to start the enabled ones for an obvious reason. The disabled ones need to be started too so it can be re-enable later on. The workflow will await forever if it is disabled (like if it was a manual workflow).
There was a problem hiding this comment.
I think that makes sense to me. Though we should probably get a confirmation from @jrhizor to be sure
lmossman
approved these changes
Jan 12, 2022
…rate-active-wf-only
This was referenced Jan 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Filter out the deleted workflows.
Change a log to the right level.