cleanup airbyte_configs table #9437
Conversation
| import java.util.function.Function; | ||
| import org.slf4j.Logger; | ||
| import org.slf4j.LoggerFactory; | ||
|
|
||
| public class ConfigsDatabaseInstance extends BaseDatabaseInstance implements DatabaseInstance { | ||
|
|
||
| private static final Logger LOGGER = LoggerFactory.getLogger(ConfigsDatabaseInstance.class); | ||
|
|
||
| private static final Set<String> INITIAL_EXPECTED_TABLES = Collections.singleton("airbyte_configs"); |
There was a problem hiding this comment.
why do we still need this?
There was a problem hiding this comment.
@davinchia So the way Flyway is setup is that first we launch a fresh instance of Airbyte, we first create airbyte_configs table and then run all the migrations and eventually reach the latest state. So thats why this is required, we expect this table to be present to determine if the DB has been initialised
There was a problem hiding this comment.
aye, I get it. annoying. can you leave a comment then? it's not obvious from someone reading code. thanks.
|
@davinchia regarding this, we can not update the migration version in this PR. It should be done as part of Airbyte release cause if we do it in this PR, if someone does a git pull in airbtye repo and tries to launch Airbyte, it wont work
|
|
@subodh1810 got it! are you going to release after we merge this in? |
# Conflicts: # airbyte-config/persistence/src/main/java/io/airbyte/config/persistence/DeprecatedDatabaseConfigPersistence.java # airbyte-config/persistence/src/test/java/io/airbyte/config/persistence/DeprecatedDatabaseConfigPersistenceTest.java
Issue : https://github.com/airbytehq/airbyte-internal-issues/issues/342
This change is