destination-s3 use instanceprofile if credentials are not provided

airbyte-integrations/connectors/destination-s3/src/main/java/io/airbyte/integrations/destination/s3/S3DestinationConfig.java

@@ -129,7 +129,12 @@ public S3FormatConfig getFormatConfig() {
   public AmazonS3 getS3Client() {
     final AWSCredentials awsCreds = new BasicAWSCredentials(accessKeyId, secretAccessKey);
 
-    if (accessKeyId == null && secretAccessKey == null || accessKeyId.isEmpty() && secretAccessKey.isEmpty()) {
+    if (accessKeyId.isEmpty() && !secretAccessKey.isEmpty() 
+    || !accessKeyId.isEmpty() && secretAccessKey.isEmpty()) {
+      throw new RuntimeException("Either both accessKeyId and secretAccessKey are provided, or none");
+    }
+
+    if (accessKeyId.isEmpty() && secretAccessKey.isEmpty()) {
       return AmazonS3ClientBuilder.standard()
       .withCredentials(new InstanceProfileCredentialsProvider(false))
       .build();

airbyte-integrations/connectors/destination-s3/src/main/resources/spec.json

@@ -70,14 +70,14 @@
       },
       "access_key_id": {
         "type": "string",
-        "description": "The access key id to access the S3 bucket. Airbyte requires Read and Write permissions to the given bucket, if not set, Airbyte will rely on Instance Profile",
+        "description": "The access key id to access the S3 bucket. Airbyte requires Read and Write permissions to the given bucket, if not set, Airbyte will rely on Instance Profile.",
         "title": "S3 Key Id",
         "airbyte_secret": true,
         "examples": ["A012345678910EXAMPLE"]
       },
       "secret_access_key": {
         "type": "string",
-        "description": "The corresponding secret to the access key id.",
+        "description": "The corresponding secret to the access key id, if S3 Key Id is set, then S3 Access Key must also be provided",
         "title": "S3 Access Key",
         "airbyte_secret": true,
         "examples": ["a012345678910ABCDEFGH/AbCdEfGhEXAMPLEKEY"]

docs/integrations/destinations/s3.md

@@ -199,7 +199,7 @@ Under the hood, an Airbyte data stream in Json schema is first converted to an A
 #### Requirements
 
 1. Allow connections from Airbyte server to your AWS S3/ Minio S3 cluster \(if they exist in separate VPCs\).
-2. An S3 bucket with credentials or a instanceprofile with read/write permissions configured for the host(ec2, eks).
+2. An S3 bucket with credentials or an instanceprofile with read/write permissions configured for the host (ec2, eks).
 
 #### Setup Guide