Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎉 Source HubSpot: engagements stream, remove auto-generated properties #9385

Merged
merged 13 commits into from
Jan 13, 2022
Merged

🎉 Source HubSpot: engagements stream, remove auto-generated properties #9385

Show file tree
Hide file tree
Changes from 8 commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
86d846f
add_properties added
grubberr Jan 10, 2022
315fa35
hubspot.md updated
grubberr Jan 10, 2022
204f1e8
fix airbyte_stream.default_cursor_field
grubberr Jan 10, 2022
f1551c7
Merge branch 'master' into grubberr/9383-source-hubspot
grubberr Jan 11, 2022
cae85fc
fix table layout
grubberr Jan 11, 2022
0f5b8b4
Merge branch 'master' into grubberr/9383-source-hubspot
grubberr Jan 11, 2022
1c59312
remove entity "engagement"
grubberr Jan 11, 2022
0391b03
revert def streams
grubberr Jan 11, 2022
b04073d
Merge branch 'master' into grubberr/9383-source-hubspot
grubberr Jan 12, 2022
edb361d
extend schemas/engagements.json
grubberr Jan 12, 2022
87af927
fix unix newlines
grubberr Jan 12, 2022
6aaf751
Merge branch 'master' into grubberr/9383-source-hubspot
grubberr Jan 13, 2022
febfa3a
source_specs.yaml updated
grubberr Jan 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion airbyte-config/init/src/main/resources/seed/source_definitions.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -287,7 +287,7 @@
- name: HubSpot
sourceDefinitionId: 36c891d9-4bd9-43ac-bad2-10e12756272c
dockerRepository: airbyte/source-hubspot
dockerImageTag: 0.1.30
dockerImageTag: 0.1.31
documentationUrl: https://docs.airbyte.io/integrations/sources/hubspot
icon: hubspot.svg
sourceType: api
Expand Down
2 changes: 1 addition & 1 deletion airbyte-integrations/connectors/source-hubspot/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,5 +34,5 @@ COPY source_hubspot ./source_hubspot
ENV AIRBYTE_ENTRYPOINT "python /airbyte/integration_code/main.py"
ENTRYPOINT ["python", "/airbyte/integration_code/main.py"]

LABEL io.airbyte.version=0.1.30
LABEL io.airbyte.version=0.1.31
LABEL io.airbyte.name=airbyte/source-hubspot
8 changes: 2 additions & 6 deletions airbyte-integrations/connectors/source-hubspot/source_hubspot/api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -265,10 +265,7 @@ def _cast_value(declared_field_types: List, field_name: str, field_value: Any, d

def _cast_record_fields_if_needed(self, record: Mapping, properties: Mapping[str, Any] = None) -> Mapping:

if self.entity not in {"contact", "engagement", "product", "quote", "ticket", "company", "deal", "line_item"}:
return record

if not record.get("properties"):
if not self.entity or not record.get("properties"):
return record

properties = properties or self.properties
Expand Down Expand Up @@ -363,7 +360,7 @@ def parse_response(self, response: Union[Mapping[str, Any], List[dict]]) -> Iter
'message': 'This hapikey (....) does not have proper permissions! (requires any of [automation-access])',
'correlationId': '111111-2222-3333-4444-55555555555'}
"""
logger.warning(f"Stream `{self.entity}` cannot be procced. {response.get('message')}")
logger.warning(f"Stream `{self.name}` cannot be procced. {response.get('message')}")
return

if response.get(self.data_field) is None:
Expand Down Expand Up @@ -713,7 +710,6 @@ class EngagementStream(Stream):
Docs: https://legacydocs.hubspot.com/docs/methods/engagements/get-all-engagements
"""

entity = "engagement"
url = "/engagements/v1/engagements/paged"
more_key = "hasMore"
limit = 250
Expand Down
2 changes: 1 addition & 1 deletion docs/integrations/sources/hubspot.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,6 +110,7 @@ If you are using Oauth, most of the streams require the appropriate [scopes](htt

| Version | Date | Pull Request | Subject |
|:--------|:-----------| :--- |:-----------------------------------------------------------------------------------------------------------------------------------------------|
| 0.1.31 | 2022-01-11 | [9385](https://github.com/airbytehq/airbyte/pull/9385) | Remove auto-generated `properties` from `Engagements` stream |
| 0.1.30 | 2021-01-10 | [9129](https://github.com/airbytehq/airbyte/pull/9129) | Created Contacts list memberships streams |
| 0.1.29 | 2021-12-17 | [8699](https://github.com/airbytehq/airbyte/pull/8699) | Add incremental sync support for `companies`, `contact_lists`, `contacts`, `deals`, `line_items`, `products`, `quotes`, `tickets` streams |
| 0.1.28 | 2021-12-15 | [8429](https://github.com/airbytehq/airbyte/pull/8429) | Update fields and descriptions |
Expand All @@ -134,4 +135,3 @@ If you are using Oauth, most of the streams require the appropriate [scopes](htt
| 0.1.9 | 2021-08-11 | [5334](https://github.com/airbytehq/airbyte/pull/5334) | Fix empty strings inside float datatype |
| 0.1.8 | 2021-08-06 | [5250](https://github.com/airbytehq/airbyte/pull/5250) | Fix issue with printing exceptions |
| 0.1.7 | 2021-07-27 | [4913](https://github.com/airbytehq/airbyte/pull/4913) | Update fields schema |