Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include tcp port in Clickhouse destination configuration for normalization #9340

Merged
merged 4 commits into from
Jan 6, 2022
Merged

Include tcp port in Clickhouse destination configuration for normalization #9340

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
26373f2
Include tcp port in Clickhouse destination configuration for normaliz…
ChristopheDuong Jan 6, 2022
d4ddd0d
revert custom dbt on clickhouse
ChristopheDuong Jan 6, 2022
02fafba
Bumpversion of destination connector
ChristopheDuong Jan 6, 2022
be03576
Format code
ChristopheDuong Jan 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions airbyte-integrations/bases/base-normalization/normalization/transform_config/transform.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -277,6 +277,8 @@ def transform_clickhouse(config: Dict[str, Any]):
"user": config["username"],
"password": config["password"],
}
if "tcp-port" in config:
dbt_config["port"] = config["tcp-port"]
return dbt_config

@staticmethod
Expand Down
2 changes: 1 addition & 1 deletion airbyte-integrations/connectors/destination-clickhouse/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,5 +16,5 @@ ENV APPLICATION destination-clickhouse

COPY --from=build /airbyte /airbyte

LABEL io.airbyte.version=0.1.1
LABEL io.airbyte.version=0.1.2
LABEL io.airbyte.name=airbyte/destination-clickhouse
20 changes: 15 additions & 5 deletions airbyte-integrations/connectors/destination-clickhouse/src/main/resources/spec.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"documentationUrl": "https://docs.airbyte.io/integrations/destinations/clickhouse",
"supportsIncremental": true,
"supportsNormalization": true,
"supportsDBT": false,
"supportsDBT": true,
"supported_destination_sync_modes": ["overwrite", "append", "append_dedup"],
"connectionSpecification": {
"$schema": "http://json-schema.org/draft-07/schema#",
Expand All @@ -27,31 +27,41 @@
"examples": ["8123"],
"order": 1
},
"tcp-port": {
"title": "Native Port",
"description": "Native port (not the JDBC) of the database.",
"type": "integer",
"minimum": 0,
"maximum": 65536,
"default": 9000,
"examples": ["9000"],
"order": 2
},
"database": {
"title": "DB Name",
"description": "Name of the database.",
"type": "string",
"order": 2
"order": 3
},
"username": {
"title": "User",
"description": "Username to use to access the database.",
"type": "string",
"order": 3
"order": 4
},
"password": {
"title": "Password",
"description": "Password associated with the username.",
"type": "string",
"airbyte_secret": true,
"order": 4
"order": 5
},
"ssl": {
"title": "SSL Connection",
"description": "Encrypt data using SSL.",
"type": "boolean",
"default": false,
"order": 5
"order": 6
}
}
}
Expand Down