add ability to inject environment variables globally into launched processes #9329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrhizor
requested review from
sherifnada,
cgardens,
sergei-solonitcyn and
lmossman
github-actions
bot
added
area/platform
lmossman
approved these changes
Jan 6, 2022
airbyte-workers/src/main/java/io/airbyte/workers/temporal/sync/OrchestratorConstants.java
Outdated
Show resolved
Hide resolved
|
Have you considered this pattern instead of serializing json in env variables? |
sherifnada
approved these changes
Jan 6, 2022
cgardens
approved these changes
Jan 7, 2022
sergei-solonitcyn
approved these changes
Jan 9, 2022
|
Good idea with the prefix. Switched to that instead. Once this passes the build on Github I'll merge. |
tuliren
reviewed
Jan 10, 2022
| } | ||
|
|
||
| public EnvConfigs(final Function<String, String> getEnv) { | ||
| public EnvConfigs(final Function<String, String> getEnv, final Supplier<Set<String>> getAllEnvKeys) { |
There was a problem hiding this comment.
Nitpick. Can you add Javadoc to this class to explain the prefix setup?
|
Good call on the Javadoc. After realizing I didn't have a good way to explain it I cleaned up the interface instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specifically this will enable us to inject values like the
SENTRY_DSNwhen it is set in the.envfiles or Helm. It will also enable us to do things like setLOG_LEVEL(if it's respected at least) for launched containers in Docker and Kubernetes.This partially addresses #9104 (we can do a separate PR will actually introduce the sentry tracking -- I'd prefer for someone on connectors to do this to get a sense of where these overrides have to be added on OSS and cloud).