Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove intermediate docker images by label 'io.airbyte.build=$BUILD_ID' #9309

Closed
wants to merge 16 commits into from

Conversation

grubberr
Copy link
Contributor

@grubberr grubberr commented Jan 5, 2022

Signed-off-by: Sergey Chvalyuk grubberr@gmail.com

What

Docker multi-stage build produce intermediate image which consume disk space.

./gradlew :airbyte-integrations:connectors:destination-redshift:airbyteDocker

docker images
airbyte/destination-redshift             dev                 796a4716004e   5 seconds ago   700MB
<none>                                   <none>              76409be86212   10 seconds ago   993MB

How

We label intermediate image and prune it right after building

./gradlew :airbyte-integrations:connectors:destination-redshift:airbyteDocker

docker images
airbyte/destination-redshift             dev                 796a4716004e   5 seconds ago   700MB

Recommended reading order

  1. x.java
  2. y.python

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

  • Community member? Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • docs/SUMMARY.md
    • docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
    • docs/integrations/README.md
    • airbyte-integrations/builds.md
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here
  • After the connector is published, connector added to connector index as described here
  • Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here
  • After the new connector version is published, connector version bumped in the seed directory as described here
  • Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Connector Generator

  • Issue acceptance criteria met
  • PR name follows PR naming conventions
  • If adding a new generator, add it to the list of scaffold modules being tested
  • The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
  • Documentation which references the generator is updated as needed.

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
@grubberr grubberr self-assigned this Jan 5, 2022
@github-actions github-actions bot added the area/connectors Connector related issues label Jan 5, 2022
@grubberr grubberr linked an issue Jan 5, 2022 that may be closed by this pull request
@grubberr grubberr temporarily deployed to more-secrets January 5, 2022 11:16 Inactive
@grubberr grubberr temporarily deployed to more-secrets January 6, 2022 10:59 Inactive
@grubberr grubberr temporarily deployed to more-secrets January 6, 2022 11:52 Inactive
@grubberr grubberr temporarily deployed to more-secrets January 6, 2022 17:38 Inactive
Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
@grubberr grubberr temporarily deployed to more-secrets January 6, 2022 17:43 Inactive
@grubberr grubberr temporarily deployed to more-secrets January 6, 2022 20:37 Inactive
@grubberr grubberr temporarily deployed to more-secrets January 6, 2022 20:40 Inactive
Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
@grubberr grubberr temporarily deployed to more-secrets January 6, 2022 21:02 Inactive
@grubberr grubberr temporarily deployed to more-secrets January 6, 2022 22:19 Inactive
@grubberr grubberr temporarily deployed to more-secrets January 6, 2022 22:46 Inactive
@grubberr grubberr temporarily deployed to more-secrets January 6, 2022 23:18 Inactive
Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
@grubberr grubberr temporarily deployed to more-secrets January 7, 2022 10:24 Inactive
Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
@grubberr grubberr temporarily deployed to more-secrets January 7, 2022 11:06 Inactive
Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
@grubberr grubberr temporarily deployed to more-secrets January 7, 2022 11:14 Inactive
@grubberr grubberr temporarily deployed to more-secrets January 7, 2022 12:04 Inactive
@grubberr grubberr changed the title remove intermediate images by label 'io.airbyte.build' Remove intermediate docker images by label 'io.airbyte.build=$BUILD_ID' Jan 10, 2022
@grubberr grubberr temporarily deployed to more-secrets January 10, 2022 10:15 Inactive
@grubberr grubberr requested a review from antixar January 10, 2022 10:29
@grubberr
Copy link
Contributor Author

grubberr commented Jan 11, 2022

/test connector=bases-base-normalization

🕑 bases-base-normalization https://github.com/airbytehq/airbyte/actions/runs/1682406807
❌ bases-base-normalization https://github.com/airbytehq/airbyte/actions/runs/1682406807
🐛

@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets January 11, 2022 12:20 Inactive
@grubberr
Copy link
Contributor Author

grubberr commented Jan 12, 2022

we don't need this because of #9408

@grubberr grubberr closed this Jan 12, 2022
@grubberr grubberr removed the request for review from antixar January 12, 2022 17:54
@swyxio swyxio deleted the grubberr/9308-docker-multi-stage-cleanup branch October 12, 2022 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants