decrease cost of health check #9288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/api
davinchia
approved these changes
Jan 4, 2022
40 tasks
davinchia
added a commit
that referenced
this pull request
Apr 7, 2022
As part of digging into airbytehq/oncall#192. I realised the OSS Server's health checks aren't actually implemented. This was removed in ##9288. However we do require this to be implemented since we use it in Airbyte Cloud to inform whether the server is connected to the database or not and thus have properly start up. Since this check can potentially be called multiple times a second, it is important for the check to be fast. Because of this, we check the server is working by attempting to list the id column of the workspace table's first row.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As far as I can tell, nobody actually needs to use the db value (
HealthServicejust calls it and checks for an error and the scheduler app won't reach the point where the server is live if the db is not on startup).