Refactor SCD Jinja templates for normalization #9278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
40 tasks
edgao
approved these changes
Jan 4, 2022
| from input_data | ||
| ), | ||
| {{ '{%- endif %}' }} | ||
| {{ clickhouse_active_row_sql }} |
There was a problem hiding this comment.
does jinja insert an empty string if this variable is unset?
marcosmarxm
added a commit
that referenced
this pull request
Jan 5, 2022
* add normalization-clickhouse docker build step * bump normalization version * small changes gradle * fix settings gradle * fix eof file * correct clickhouse normalization * Refactor jinja template for scd (#9278) * merge chris code and regenerate sql files Co-authored-by: James Zhao <james.zhao@sinoreps.com> Co-authored-by: Edward Gao <edward.gao@airbyte.io> Co-authored-by: Christophe Duong <christophe.duong@gmail.com>
marcosmarxm
added a commit
that referenced
this pull request
Jan 7, 2022
* add normalization-clickhouse docker build step * bump normalization version * small changes gradle * fix settings gradle * fix eof file * correct clickhouse normalization * Refactor jinja template for scd (#9278) * merge chris code and regenerate sql files * correct scd post-hook generation for snowflake * fix scd table for snowflake prefix table with number * scd fix for all destinations * use quote * use normalize column for post-hook * change logic to apply quote * add logic to handle prefix for mssql and oracle * run tests * correct unit test * bump normalization version Co-authored-by: James Zhao <james.zhao@sinoreps.com> Co-authored-by: Edward Gao <edward.gao@airbyte.io> Co-authored-by: Christophe Duong <christophe.duong@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Refactor jinja template as follow-up to #9072