BufferedStreamConsumerTest: remove non-determinism in size of generated test records #9274

grubberr · 2022-01-04T10:12:28Z

Signed-off-by: Sergey Chvalyuk grubberr@gmail.com

What

BufferedStreamConsumerTest has side-effects
because generateRecords could generated records of different size and also total size of all records != 1000 as
assumed. Tests FAIL time to time.

How

My fix make all records fixed size (40 bytes) and total size of all records now equal 1000 (as assumed in function param)

How

Describe the solution

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
Credentials added to Github CI. Instructions.
/test connector=connectors/<name> command is passing.
New Connector version released on Dockerhub by running the /publish command described here
After the connector is published, connector added to connector index as described here
Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Updating a connector

Community member or Airbyter

Grant edit access to maintainers (instructions)
Secrets in the connector's spec are annotated with airbyte_secret
Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
Code reviews completed
Documentation updated
- Connector's README.md
- Connector's bootstrap.md. See description and examples
- Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
Credentials added to Github CI. Instructions.
/test connector=connectors/<name> command is passing.
New Connector version released on Dockerhub by running the /publish command described here
After the new connector version is published, connector version bumped in the seed directory as described here
Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Connector Generator

Issue acceptance criteria met
PR name follows PR naming conventions
If adding a new generator, add it to the list of scaffold modules being tested
The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
Documentation which references the generator is updated as needed.

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

fix buffer flush Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

davinchia · 2022-01-04T10:53:30Z

...io/airbyte/integrations/destination/buffered_stream_consumer/BufferedStreamConsumerTest.java

@@ -315,7 +315,7 @@ private static void consumeRecords(final BufferedStreamConsumer consumer, final
    List<AirbyteMessage> output = Lists.newArrayList();
    long bytesCounter = 0;
    for (int i = 0;; i++) {
-      JsonNode payload = Jsons.jsonNode(ImmutableMap.of("id", RandomStringUtils.randomAscii(7), "name", "human " + String.format("%5d", i)));
+      JsonNode payload = Jsons.jsonNode(ImmutableMap.of("id", RandomStringUtils.randomAlphabetic(7), "name", "human " + String.format("%8d", i)));


how does this make the generated size always be 40?

now it generates object of fixed size:

{"id":"dumplEw","name":"human 0"} {"id":"tnJatrn","name":"human 25"}

I have added more spaces before number (to make it 40 bytes)

I have also changed randomAscii -> randomAlphabetic
to avoid generation DOULD-QUOTE and BACK-SLACH which can generated 2 bytes after json-encoding

Got it, thanks for the explanation!

davinchia · 2022-01-04T10:54:33Z

...ava/io/airbyte/integrations/destination/buffered_stream_consumer/BufferedStreamConsumer.java

@@ -147,7 +147,7 @@ protected void acceptTracked(final AirbyteMessage message) throws Exception {
      // are serialized again when writing to
      // the destination
      long messageSizeInBytes = ByteUtils.getSizeInBytesForUTF8CharSet(Jsons.serialize(recordMessage.getData()));
-      if (bufferSizeInBytes + messageSizeInBytes >= maxQueueSizeInBytes) {
+      if (bufferSizeInBytes + messageSizeInBytes > maxQueueSizeInBytes) {


why is this changed too? should this also be =?

As for me it's real bug in code itself which I discovered fixing tests.
We need to FLUSH buffer only if
bufferSizeInBytes + messageSizeInBytes > maxQueueSizeInBytes

because if

bufferSizeInBytes + messageSizeInBytes = maxQueueSizeInBytes

we still has to keep buffer not flushed

it's not my logic
it's what I see according to tests

DoNotPanicUA

😍

grubberr added 2 commits January 4, 2022 12:02

bugfix: generate objects fixed size

a22dead

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

generated records 40 bytes of size

3871c96

fix buffer flush Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

grubberr temporarily deployed to more-secrets January 4, 2022 10:31 Inactive

grubberr requested review from sherifnada and davinchia January 4, 2022 10:36

grubberr linked an issue Jan 4, 2022 that may be closed by this pull request

buffered_stream_consumer.BufferedStreamConsumerTest FAIL time to time #9276

Closed

grubberr self-assigned this Jan 4, 2022

grubberr requested a review from DoNotPanicUA January 4, 2022 10:50

davinchia reviewed Jan 4, 2022

View reviewed changes

grubberr requested review from mkhokh-33 and davinchia January 4, 2022 11:18

grubberr temporarily deployed to more-secrets January 4, 2022 11:56 Inactive

DoNotPanicUA approved these changes Jan 4, 2022

View reviewed changes

mkhokh-33 approved these changes Jan 4, 2022

View reviewed changes

davinchia approved these changes Jan 4, 2022

View reviewed changes

grubberr merged commit c0a46c1 into master Jan 4, 2022

grubberr deleted the grubberr/buffered_stream_consumer_test_fix branch January 4, 2022 15:04

mkhokh-33 mentioned this pull request Jan 4, 2022

Destination BigQuery: Accept Dataset ID field prefixed by Project ID #8383

Merged

16 tasks

jrhizor mentioned this pull request Jan 7, 2022

Bump Airbyte version from 0.35.3-alpha to 0.35.4-alpha #9353

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

BufferedStreamConsumerTest: remove non-determinism in size of generated test records #9274

BufferedStreamConsumerTest: remove non-determinism in size of generated test records #9274

grubberr commented Jan 4, 2022 •

edited

Loading

davinchia Jan 4, 2022

grubberr Jan 4, 2022 •

edited

Loading

davinchia Jan 4, 2022

davinchia Jan 4, 2022

grubberr Jan 4, 2022

DoNotPanicUA left a comment

BufferedStreamConsumerTest: remove non-determinism in size of generated test records #9274

BufferedStreamConsumerTest: remove non-determinism in size of generated test records #9274

Conversation

grubberr commented Jan 4, 2022 • edited Loading

What

How

How

Recommended reading order

🚨 User Impact 🚨

Pre-merge Checklist

Community member or Airbyter

Airbyter

Community member or Airbyter

Airbyter

davinchia Jan 4, 2022

Choose a reason for hiding this comment

grubberr Jan 4, 2022 • edited Loading

Choose a reason for hiding this comment

davinchia Jan 4, 2022

Choose a reason for hiding this comment

davinchia Jan 4, 2022

Choose a reason for hiding this comment

grubberr Jan 4, 2022

Choose a reason for hiding this comment

DoNotPanicUA left a comment

Choose a reason for hiding this comment

grubberr commented Jan 4, 2022 •

edited

Loading

grubberr Jan 4, 2022 •

edited

Loading