Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update fields in source-connectors specifications: jdbc #9270

Merged
merged 2 commits into from
Jan 4, 2022

Conversation

ycherniaiev
Copy link
Contributor

What

Add title and description properties to each field in source-connectors specifications:
source-jdbc

How

Describe the solution

Recommended reading order

  1. x.java
  2. y.python

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here
  • After the new connector version is published, connector version bumped in the seed directory as described here
  • Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

@ycherniaiev ycherniaiev added area/documentation Improvements or additions to documentation area/connectors Connector related issues labels Jan 4, 2022
@ycherniaiev ycherniaiev requested a review from bazarnov January 4, 2022 09:51
@ycherniaiev ycherniaiev self-assigned this Jan 4, 2022
@github-actions github-actions bot removed the area/documentation Improvements or additions to documentation label Jan 4, 2022
@ycherniaiev
Copy link
Contributor Author

ycherniaiev commented Jan 4, 2022

/test connector=connectors/source-jdbc

🕑 connectors/source-jdbc https://github.com/airbytehq/airbyte/actions/runs/1653058006
✅ connectors/source-jdbc https://github.com/airbytehq/airbyte/actions/runs/1653058006
No Python unittests run

@jrhizor jrhizor temporarily deployed to more-secrets January 4, 2022 09:56 Inactive
@bazarnov
Copy link
Collaborator

bazarnov commented Jan 4, 2022

/publish connector=connectors/source-jdbc

🕑 connectors/source-jdbc https://github.com/airbytehq/airbyte/actions/runs/1653309196
✅ connectors/source-jdbc https://github.com/airbytehq/airbyte/actions/runs/1653309196

@jrhizor jrhizor temporarily deployed to more-secrets January 4, 2022 11:06 Inactive
@bazarnov bazarnov temporarily deployed to more-secrets January 4, 2022 11:15 Inactive
@ycherniaiev ycherniaiev added the area/documentation Improvements or additions to documentation label Jan 4, 2022
@bazarnov bazarnov merged commit c3c38a1 into master Jan 4, 2022
@bazarnov bazarnov deleted the ycherniaiev/issue-8931-update-title-descriptions branch January 4, 2022 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants