Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase sidecars' memory limit #9266

Merged

Conversation

TSkrebe
Copy link
Contributor

@TSkrebe TSkrebe commented Jan 4, 2022

What

Increases sidecars' memory limit to prevent OOMs in situations when memory usage spikes. Keep request at the 25Mi to prevent unnecessary memory over-allocation.

ref: #9233

How

Describe the solution

Recommended reading order

  1. x.java
  2. y.python

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

  • Community member? Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • docs/SUMMARY.md
    • docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
    • docs/integrations/README.md
    • airbyte-integrations/builds.md
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here
  • After the connector is published, connector added to connector index as described here
  • Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here
  • After the new connector version is published, connector version bumped in the seed directory as described here
  • Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Connector Generator

  • Issue acceptance criteria met
  • PR name follows PR naming conventions
  • If adding a new generator, add it to the list of scaffold modules being tested
  • The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
  • Documentation which references the generator is updated as needed.

@CLAassistant
Copy link

CLAassistant commented Jan 4, 2022

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added area/platform issues related to the platform area/worker Related to worker labels Jan 4, 2022
@davinchia
Copy link
Contributor

@TSkrebe can you please sign the CLA?

@TSkrebe
Copy link
Contributor Author

TSkrebe commented Jan 4, 2022

@TSkrebe can you please sign the CLA?

signed it a couple of hours ago.

Screenshot 2022-01-04 at 11 09 18

@davinchia
Copy link
Contributor

Strange - the build shows it's not signed yet.

@TSkrebe
Copy link
Contributor Author

TSkrebe commented Jan 4, 2022

Strange - the build shows it's not signed yet.

Email was not fully set-up on github.. looks good now.

@alafanechere alafanechere temporarily deployed to more-secrets January 4, 2022 13:44 Inactive
@alafanechere alafanechere merged commit cece4c6 into airbytehq:master Jan 4, 2022
@alafanechere
Copy link
Contributor

Thank you @TSkrebe for this, I hope it will help you solve your original issue.

@TSkrebe
Copy link
Contributor Author

TSkrebe commented Jan 5, 2022

@alafanechere will let you know. when do you plan on releasing a new version?

@davinchia
Copy link
Contributor

@TSkrebe definitely by the end of this week.

@musabmasood
Copy link

Curious if these sidecar resources are configurable on k8s (helm/kustomize) level somehow?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/platform issues related to the platform area/worker Related to worker community
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants