Fix generate.sh from bad trap for ERR signal by using bash instead of sh #9243
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Reports of some users seeing
bad trap
when runningairbyte-integrations/connector-templates/generator/generate.sh
becauseERR
does not exist in POSIX.#5586
How
Use
bash
instead. I noticed a lot of the shell scripts in the repo use#!/usr/bin/env bash
but a lot of the connectors usesh
in theacceptance-test-docker.sh
scripts. I was confused at first but it seems like the reason for this is that the generator docker image takes the last created connector and creates a template based off of that. So unless there was an intentional reason for usingsh
I think changing everything to bash now would solve this for the future until a linter rule is created to require bash.Recommended reading order
x.java
y.python
🚨 User Impact 🚨
No user impact
Pre-merge Checklist
This change is