Update fields in destination-connectors specifications: mssql, mssql-strict-encrypt #9158

igrankova · 2021-12-28T15:10:48Z

What

Add title and description properties to each field in destination-connectors specifications:
destination-mssql
destination-mssql-strict-encrypt

How

Describe the solution

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

Updating a connector

Community member or Airbyter

Grant edit access to maintainers (instructions)
Secrets in the connector's spec are annotated with airbyte_secret
Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
Code reviews completed
Documentation updated
- Connector's README.md
- Connector's bootstrap.md. See description and examples
- Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
Credentials added to Github CI. Instructions.
/test connector=connectors/<name> command is passing.
New Connector version released on Dockerhub by running the /publish command described here
After the new connector version is published, connector version bumped in the seed directory as described here
Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

igrankova · 2021-12-28T15:16:49Z

/test connector=connectors/destination-mssql

🕑 connectors/destination-mssql https://github.com/airbytehq/airbyte/actions/runs/1630950044
✅ connectors/destination-mssql https://github.com/airbytehq/airbyte/actions/runs/1630950044
Python tests coverage:

	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                                              Stmts   Miss  Cover
	 -------------------------------------------------------------------------------------
	 main_dev_transform_catalog.py                                         3      3     0%
	 main_dev_transform_config.py                                          3      3     0%
	 normalization/__init__.py                                             4      0   100%
	 normalization/destination_type.py                                    13      0   100%
	 normalization/transform_catalog/__init__.py                           2      0   100%
	 normalization/transform_catalog/catalog_processor.py                143     77    46%
	 normalization/transform_catalog/destination_name_transformer.py     124      6    95%
	 normalization/transform_catalog/reserved_keywords.py                 13      0   100%
	 normalization/transform_catalog/stream_processor.py                 494    313    37%
	 normalization/transform_catalog/table_name_registry.py              174     34    80%
	 normalization/transform_catalog/transform.py                         45     26    42%
	 normalization/transform_catalog/utils.py                             33      7    79%
	 normalization/transform_config/__init__.py                            2      0   100%
	 normalization/transform_config/transform.py                         146     32    78%
	 -------------------------------------------------------------------------------------
	 TOTAL                                                              1199    501    58%

annalvova05 · 2021-12-29T11:05:59Z

/publish connector=connectors/destination-mssql

🕑 connectors/destination-mssql https://github.com/airbytehq/airbyte/actions/runs/1633773029
❌ connectors/destination-mssql https://github.com/airbytehq/airbyte/actions/runs/1633773029

mkhokh-33 · 2021-12-30T13:33:23Z

/publish connector=connectors/destination-mssql

🕑 connectors/destination-mssql https://github.com/airbytehq/airbyte/actions/runs/1637630302
✅ connectors/destination-mssql https://github.com/airbytehq/airbyte/actions/runs/1637630302

mkhokh-33 · 2021-12-30T14:50:05Z

/test connector=connectors/destination-mssql-strict-encrypt

🕑 connectors/destination-mssql-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/1637842578
❌ connectors/destination-mssql-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/1637842578
🐛

mkhokh-33 · 2021-12-30T15:41:43Z

/test connector=connectors/destination-mssql-strict-encrypt

🕑 connectors/destination-mssql-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/1637984890
❌ connectors/destination-mssql-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/1637984890
🐛

mkhokh-33 · 2021-12-31T10:42:19Z

/test connector=connectors/destination-mssql-strict-encrypt

🕑 connectors/destination-mssql-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/1640499405
✅ connectors/destination-mssql-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/1640499405
Python tests coverage:

	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                                              Stmts   Miss  Cover
	 -------------------------------------------------------------------------------------
	 main_dev_transform_catalog.py                                         3      3     0%
	 main_dev_transform_config.py                                          3      3     0%
	 normalization/__init__.py                                             4      0   100%
	 normalization/destination_type.py                                    13      0   100%
	 normalization/transform_catalog/__init__.py                           2      0   100%
	 normalization/transform_catalog/catalog_processor.py                143     77    46%
	 normalization/transform_catalog/destination_name_transformer.py     124      6    95%
	 normalization/transform_catalog/reserved_keywords.py                 13      0   100%
	 normalization/transform_catalog/stream_processor.py                 494    313    37%
	 normalization/transform_catalog/table_name_registry.py              174     34    80%
	 normalization/transform_catalog/transform.py                         45     26    42%
	 normalization/transform_catalog/utils.py                             33      7    79%
	 normalization/transform_config/__init__.py                            2      0   100%
	 normalization/transform_config/transform.py                         146     32    78%
	 -------------------------------------------------------------------------------------
	 TOTAL                                                              1199    501    58%

mkhokh-33 · 2021-12-31T10:55:11Z

/publish connector=connectors/destination-mssql-strict-encrypt

🕑 connectors/destination-mssql-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/1640526994
❌ connectors/destination-mssql-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/1640526994

mkhokh-33 · 2021-12-31T11:24:19Z

/publish connector=connectors/destination-mssql-strict-encrypt

🕑 connectors/destination-mssql-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/1640594302
✅ connectors/destination-mssql-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/1640594302

Files title/description update for issue # 8950

4e0c98d

igrankova self-assigned this Dec 28, 2021

igrankova linked an issue Dec 28, 2021 that may be closed by this pull request

Update fields in destination-connectors specifications: mssql #8950

Closed

github-actions bot added the area/connectors Connector related issues label Dec 28, 2021

Version update for issue # 8950

f50f3ba

igrankova temporarily deployed to more-secrets December 28, 2021 15:15 Inactive

Changelogs update for PR #9158

5c18493

github-actions bot added the area/documentation Improvements or additions to documentation label Dec 28, 2021

igrankova requested a review from annalvova05 December 28, 2021 15:16

igrankova temporarily deployed to more-secrets December 28, 2021 15:17 Inactive

jrhizor temporarily deployed to more-secrets December 28, 2021 15:18 Inactive

annalvova05 approved these changes Dec 29, 2021

View reviewed changes

jrhizor temporarily deployed to more-secrets December 29, 2021 11:08 Inactive

igrankova requested a review from mkhokh-33 December 29, 2021 13:41

jrhizor temporarily deployed to more-secrets December 30, 2021 13:35 Inactive

igrankova temporarily deployed to more-secrets December 30, 2021 14:05 Inactive

update destination_specs.yaml with new version

24cd627

igrankova changed the title ~~Update fields in destination-connectors specifications: mssql~~ Update fields in destination-connectors specifications: mssql, mssql-strict-encrypt Dec 30, 2021

mkhokh-33 temporarily deployed to more-secrets December 30, 2021 14:22 Inactive

mkhokh-33 temporarily deployed to more-secrets December 30, 2021 14:32 Inactive

update version for destination-mssql-strict-encrypt

42e92b9

mkhokh-33 temporarily deployed to more-secrets December 30, 2021 14:37 Inactive

Merge branch 'master' into igrankova/issue-8950-update-title-description

ccfe472

mkhokh-33 temporarily deployed to more-secrets December 30, 2021 14:40 Inactive

jrhizor temporarily deployed to more-secrets December 30, 2021 14:51 Inactive

mkhokh-33 temporarily deployed to more-secrets December 30, 2021 15:03 Inactive

jrhizor temporarily deployed to more-secrets December 30, 2021 15:43 Inactive

fix destination-mssql-strict-encrypt integration tests

fa45108

mkhokh-33 temporarily deployed to more-secrets December 31, 2021 10:42 Inactive

jrhizor temporarily deployed to more-secrets December 31, 2021 10:44 Inactive

jrhizor temporarily deployed to more-secrets December 31, 2021 10:57 Inactive

jrhizor temporarily deployed to more-secrets December 31, 2021 11:26 Inactive

mkhokh-33 temporarily deployed to more-secrets December 31, 2021 11:38 Inactive

mkhokh-33 approved these changes Jan 4, 2022

View reviewed changes

mkhokh-33 merged commit 9de7443 into master Jan 4, 2022

mkhokh-33 deleted the igrankova/issue-8950-update-title-description branch January 4, 2022 12:10

jrhizor mentioned this pull request Jan 7, 2022

Bump Airbyte version from 0.35.3-alpha to 0.35.4-alpha #9353

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update fields in destination-connectors specifications: mssql, mssql-strict-encrypt #9158

Update fields in destination-connectors specifications: mssql, mssql-strict-encrypt #9158

igrankova commented Dec 28, 2021 •

edited

Loading

igrankova commented Dec 28, 2021 •

edited by github-actions bot

Loading

annalvova05 commented Dec 29, 2021 •

edited by github-actions bot

Loading

mkhokh-33 commented Dec 30, 2021 •

edited by github-actions bot

Loading

mkhokh-33 commented Dec 30, 2021 •

edited by github-actions bot

Loading

mkhokh-33 commented Dec 30, 2021 •

edited by github-actions bot

Loading

mkhokh-33 commented Dec 31, 2021 •

edited by github-actions bot

Loading

mkhokh-33 commented Dec 31, 2021 •

edited by github-actions bot

Loading

mkhokh-33 commented Dec 31, 2021 •

edited by github-actions bot

Loading

Update fields in destination-connectors specifications: mssql, mssql-strict-encrypt #9158

Update fields in destination-connectors specifications: mssql, mssql-strict-encrypt #9158

Conversation

igrankova commented Dec 28, 2021 • edited Loading

What

How

Recommended reading order

🚨 User Impact 🚨

Pre-merge Checklist

Community member or Airbyter

Airbyter

igrankova commented Dec 28, 2021 • edited by github-actions bot Loading

annalvova05 commented Dec 29, 2021 • edited by github-actions bot Loading

mkhokh-33 commented Dec 30, 2021 • edited by github-actions bot Loading

mkhokh-33 commented Dec 30, 2021 • edited by github-actions bot Loading

mkhokh-33 commented Dec 30, 2021 • edited by github-actions bot Loading

mkhokh-33 commented Dec 31, 2021 • edited by github-actions bot Loading

mkhokh-33 commented Dec 31, 2021 • edited by github-actions bot Loading

mkhokh-33 commented Dec 31, 2021 • edited by github-actions bot Loading

igrankova commented Dec 28, 2021 •

edited

Loading

igrankova commented Dec 28, 2021 •

edited by github-actions bot

Loading

annalvova05 commented Dec 29, 2021 •

edited by github-actions bot

Loading

mkhokh-33 commented Dec 30, 2021 •

edited by github-actions bot

Loading

mkhokh-33 commented Dec 30, 2021 •

edited by github-actions bot

Loading

mkhokh-33 commented Dec 30, 2021 •

edited by github-actions bot

Loading

mkhokh-33 commented Dec 31, 2021 •

edited by github-actions bot

Loading

mkhokh-33 commented Dec 31, 2021 •

edited by github-actions bot

Loading

mkhokh-33 commented Dec 31, 2021 •

edited by github-actions bot

Loading