Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update fields in source-connectors specifications: freshservice #9143

Merged
merged 5 commits into from
Jan 5, 2022
Merged

Update fields in source-connectors specifications: freshservice #9143

merged 5 commits into from
Jan 5, 2022

Conversation

ycherniaiev
Copy link
Contributor

No description provided.

@ycherniaiev ycherniaiev added area/documentation Improvements or additions to documentation area/connectors Connector related issues labels Dec 28, 2021
@ycherniaiev ycherniaiev requested a review from antixar December 28, 2021 10:43
@ycherniaiev ycherniaiev self-assigned this Dec 28, 2021
@github-actions github-actions bot removed the area/documentation Improvements or additions to documentation label Dec 28, 2021
@github-actions github-actions bot added the area/documentation Improvements or additions to documentation label Dec 28, 2021
@ycherniaiev ycherniaiev temporarily deployed to more-secrets December 28, 2021 10:48 Inactive
@ycherniaiev ycherniaiev linked an issue Dec 28, 2021 that may be closed by this pull request
Update fields in source-connectors specifications: freshservice #8925
Closed
@ycherniaiev
Copy link
Contributor Author

ycherniaiev commented Dec 28, 2021 •
edited
Loading

@sherifnada Freshservice account is suspended at this moment. In order to test and publish this PR and future updates to this connector we would need to re-acticate current plan , or create another prod account to handle this.

antixar
antixar approved these changes Dec 28, 2021
View reviewed changes
Copy link
Contributor

@antixar antixar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please publish this

@bazarnov bazarnov self-requested a review January 5, 2022 10:51
@bazarnov
Copy link
Collaborator

bazarnov commented Jan 5, 2022 •
edited by github-actions bot
Loading

/publish connector=connectors/source-freshservice run-tests=false

🕑 connectors/source-freshservice https://github.com/airbytehq/airbyte/actions/runs/1657984288
✅ connectors/source-freshservice https://github.com/airbytehq/airbyte/actions/runs/1657984288

@jrhizor jrhizor temporarily deployed to more-secrets January 5, 2022 10:54 Inactive
@bazarnov
Copy link
Collaborator

bazarnov commented Jan 5, 2022

We are publishing this connector without tests for now.
@sherifnada comment:

#9101
for the reasons mentioned in the “implementation” section of the parent ticket it is safe to publish this connector without running tests, so it’s not required at the moment.

@bazarnov bazarnov temporarily deployed to more-secrets January 5, 2022 11:12 Inactive
@bazarnov bazarnov temporarily deployed to more-secrets January 5, 2022 11:15 Inactive
@bazarnov bazarnov merged commit 680e74c into master Jan 5, 2022
@bazarnov bazarnov deleted the ycherniaiev/issue-8925-update-title-description branch January 5, 2022 11:45
@jrhizor jrhizor mentioned this pull request Jan 7, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antixar antixar antixar approved these changes

@bazarnov bazarnov bazarnov approved these changes

Assignees

@ycherniaiev ycherniaiev

Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/freshservice connectors/sources-api
Projects
No open projects
GL Roadmap
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update fields in source-connectors specifications: freshservice
5 participants
@ycherniaiev @bazarnov @antixar @jrhizor @igrankova