Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update snowflake normalization test output #9132

Closed
wants to merge 4 commits into from
Closed

update snowflake normalization test output #9132

wants to merge 4 commits into from

Conversation

edgao
Copy link
Contributor

@edgao edgao commented Dec 28, 2021

What

There's been some drift here. Ran the snowflake integration tests locally on master; this was the diff.

@edgao edgao temporarily deployed to more-secrets December 28, 2021 00:50 Inactive
@ChristopheDuong
Copy link
Contributor

drift seems to be due to merging a contributor's PR: #7620

@edgao edgao force-pushed the edgao/normalization_test_output branch from 8f07b26 to f0017b2 Compare December 28, 2021 18:40
@edgao
Copy link
Contributor Author

edgao commented Dec 28, 2021 •
edited by github-actions bot
Loading

/test connector=connectors/destination-snowflake

🕑 connectors/destination-snowflake https://github.com/airbytehq/airbyte/actions/runs/1631492742
✅ connectors/destination-snowflake https://github.com/airbytehq/airbyte/actions/runs/1631492742
Python tests coverage:

	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                                              Stmts   Miss  Cover
	 -------------------------------------------------------------------------------------
	 main_dev_transform_catalog.py                                         3      3     0%
	 main_dev_transform_config.py                                          3      3     0%
	 normalization/__init__.py                                             4      0   100%
	 normalization/destination_type.py                                    13      0   100%
	 normalization/transform_catalog/__init__.py                           2      0   100%
	 normalization/transform_catalog/catalog_processor.py                143     77    46%
	 normalization/transform_catalog/destination_name_transformer.py     124      6    95%
	 normalization/transform_catalog/reserved_keywords.py                 13      0   100%
	 normalization/transform_catalog/stream_processor.py                 494    313    37%
	 normalization/transform_catalog/table_name_registry.py              174     34    80%
	 normalization/transform_catalog/transform.py                         45     26    42%
	 normalization/transform_catalog/utils.py                             33      7    79%
	 normalization/transform_config/__init__.py                            2      0   100%
	 normalization/transform_config/transform.py                         146     32    78%
	 -------------------------------------------------------------------------------------
	 TOTAL                                                              1199    501    58%

@edgao
Copy link
Contributor Author

edgao commented Dec 28, 2021 •
edited by github-actions bot
Loading

/test connector=connectors/destination-redshift

🕑 connectors/destination-redshift https://github.com/airbytehq/airbyte/actions/runs/1631493213
✅ connectors/destination-redshift https://github.com/airbytehq/airbyte/actions/runs/1631493213
Python tests coverage:

	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                                              Stmts   Miss  Cover
	 -------------------------------------------------------------------------------------
	 main_dev_transform_catalog.py                                         3      3     0%
	 main_dev_transform_config.py                                          3      3     0%
	 normalization/__init__.py                                             4      0   100%
	 normalization/destination_type.py                                    13      0   100%
	 normalization/transform_catalog/__init__.py                           2      0   100%
	 normalization/transform_catalog/catalog_processor.py                143     77    46%
	 normalization/transform_catalog/destination_name_transformer.py     124      6    95%
	 normalization/transform_catalog/reserved_keywords.py                 13      0   100%
	 normalization/transform_catalog/stream_processor.py                 494    313    37%
	 normalization/transform_catalog/table_name_registry.py              174     34    80%
	 normalization/transform_catalog/transform.py                         45     26    42%
	 normalization/transform_catalog/utils.py                             33      7    79%
	 normalization/transform_config/__init__.py                            2      0   100%
	 normalization/transform_config/transform.py                         146     32    78%
	 -------------------------------------------------------------------------------------
	 TOTAL                                                              1199    501    58%

@edgao
Copy link
Contributor Author

edgao commented Dec 28, 2021 •
edited by github-actions bot
Loading

/test connector=connectors/destination-mysql

🕑 connectors/destination-mysql https://github.com/airbytehq/airbyte/actions/runs/1631493351
✅ connectors/destination-mysql https://github.com/airbytehq/airbyte/actions/runs/1631493351
Python tests coverage:

	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                                              Stmts   Miss  Cover
	 -------------------------------------------------------------------------------------
	 main_dev_transform_catalog.py                                         3      3     0%
	 main_dev_transform_config.py                                          3      3     0%
	 normalization/__init__.py                                             4      0   100%
	 normalization/destination_type.py                                    13      0   100%
	 normalization/transform_catalog/__init__.py                           2      0   100%
	 normalization/transform_catalog/catalog_processor.py                143     77    46%
	 normalization/transform_catalog/destination_name_transformer.py     124      6    95%
	 normalization/transform_catalog/reserved_keywords.py                 13      0   100%
	 normalization/transform_catalog/stream_processor.py                 494    313    37%
	 normalization/transform_catalog/table_name_registry.py              174     34    80%
	 normalization/transform_catalog/transform.py                         45     26    42%
	 normalization/transform_catalog/utils.py                             33      7    79%
	 normalization/transform_config/__init__.py                            2      0   100%
	 normalization/transform_config/transform.py                         146     32    78%
	 -------------------------------------------------------------------------------------
	 TOTAL                                                              1199    501    58%

@edgao edgao temporarily deployed to more-secrets December 28, 2021 18:41 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets December 28, 2021 18:42 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets December 28, 2021 18:42 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets December 28, 2021 18:42 Inactive
@edgao edgao temporarily deployed to more-secrets December 28, 2021 23:55 Inactive
@edgao
Copy link
Contributor Author

edgao commented Dec 28, 2021

integration tests look happy at least; regenerated some of the destinations.

Had trouble getting mysql/mssql/oracle normalization integration tests to run locally, so haven't regenerated those. Will try and figure them out tomorrow. (error is some sort of timeout when connecting to the DB)

@edgao
Copy link
Contributor Author

edgao commented Dec 29, 2021

closing in favor of #9072

@edgao edgao closed this Dec 29, 2021
@edgao edgao deleted the edgao/normalization_test_output branch December 29, 2021 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
connectors/destination/snowflake connectors/destinations-warehouse normalization
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@edgao @ChristopheDuong @jrhizor @karinakuz