Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐞 Destination S3 & GCS: remove excessive logging #8974

Merged
merged 2 commits into from
Dec 21, 2021
Merged

🐞 Destination S3 & GCS: remove excessive logging #8974

merged 2 commits into from
Dec 21, 2021

Conversation

tuliren
Copy link
Contributor

@tuliren tuliren commented Dec 20, 2021

A bug was briefly introduced in Json -> Avro object conversion that it logged every object. The bug has been fixed now, but it looks like it has already slipped in at least one of the releases.

This PR publishes the S3 and GCS destination connectors again to make sure those excessive logs are removed.

@github-actions github-actions bot added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels Dec 20, 2021
@tuliren
Copy link
Contributor Author

tuliren commented Dec 20, 2021 •
edited by github-actions bot
Loading

/publish connector=connectors/destination-s3

🕑 connectors/destination-s3 https://github.com/airbytehq/airbyte/actions/runs/1604262766
❌ connectors/destination-s3 https://github.com/airbytehq/airbyte/actions/runs/1604262766

@tuliren
Copy link
Contributor Author

tuliren commented Dec 20, 2021 •
edited by github-actions bot
Loading

/publish connector=connectors/destination-gcs

🕑 connectors/destination-gcs https://github.com/airbytehq/airbyte/actions/runs/1604262966
❌ connectors/destination-gcs https://github.com/airbytehq/airbyte/actions/runs/1604262966

@jrhizor jrhizor temporarily deployed to more-secrets December 20, 2021 22:34 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets December 20, 2021 22:34 Inactive
@tuliren
Copy link
Contributor Author

tuliren commented Dec 21, 2021 •
edited by github-actions bot
Loading

/publish connector=connectors/destination-s3

🕑 connectors/destination-s3 https://github.com/airbytehq/airbyte/actions/runs/1604656997
✅ connectors/destination-s3 https://github.com/airbytehq/airbyte/actions/runs/1604656997

@tuliren
Copy link
Contributor Author

tuliren commented Dec 21, 2021 •
edited by github-actions bot
Loading

/publish connector=connectors/destination-gcs

🕑 connectors/destination-gcs https://github.com/airbytehq/airbyte/actions/runs/1604657371
✅ connectors/destination-gcs https://github.com/airbytehq/airbyte/actions/runs/1604657371

@jrhizor jrhizor temporarily deployed to more-secrets December 21, 2021 00:53 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets December 21, 2021 00:53 Inactive
@tuliren tuliren requested a review from marcosmarxm December 21, 2021 01:47
@tuliren tuliren merged commit a6c2d05 into master Dec 21, 2021
@tuliren tuliren deleted the liren/bump-s3-gcs-version branch December 21, 2021 01:47
@tuliren tuliren temporarily deployed to more-secrets December 21, 2021 01:48 Inactive
@skwaugh
Copy link

skwaugh commented Dec 21, 2021

@tuliren thank you

@jrhizor jrhizor mentioned this pull request Dec 22, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcosmarxm marcosmarxm Awaiting requested review from marcosmarxm

Assignees
No one assigned
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tuliren @skwaugh @jrhizor