Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update fields in source-connectors specifications: quickbooks-singer #8960

Merged
merged 17 commits into from
Dec 29, 2021

Conversation

igrankova
Copy link
Contributor

What

Add title and description properties to each field in source-connectors specifications:
source-quickbooks-singer

How

Describe the solution

Recommended reading order

  1. x.java
  2. y.python

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here
  • After the new connector version is published, connector version bumped in the seed directory as described here
  • Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

@igrankova igrankova added the area/connectors Connector related issues label Dec 20, 2021
@igrankova igrankova requested a review from misteryeo December 20, 2021 11:59
@igrankova igrankova self-assigned this Dec 20, 2021
@igrankova igrankova linked an issue Dec 20, 2021 that may be closed by this pull request
@github-actions github-actions bot added the area/documentation Improvements or additions to documentation label Dec 20, 2021
@igrankova igrankova temporarily deployed to more-secrets December 20, 2021 12:07 Inactive
@igrankova
Copy link
Contributor Author

igrankova commented Dec 20, 2021

/test connector=connectors/source-quickbooks-singer

🕑 connectors/source-quickbooks-singer https://github.com/airbytehq/airbyte/actions/runs/1602030318
❌ connectors/source-quickbooks-singer https://github.com/airbytehq/airbyte/actions/runs/1602030318
🐛

@jrhizor jrhizor temporarily deployed to more-secrets December 20, 2021 12:35 Inactive
@igrankova igrankova temporarily deployed to more-secrets December 21, 2021 14:15 Inactive
@igrankova igrankova requested a review from bazarnov December 21, 2021 14:25
@bazarnov
Copy link
Collaborator

bazarnov commented Dec 29, 2021

/test connector=connectors/source-quickbooks-singer

🕑 connectors/source-quickbooks-singer https://github.com/airbytehq/airbyte/actions/runs/1634117420
❌ connectors/source-quickbooks-singer https://github.com/airbytehq/airbyte/actions/runs/1634117420
🐛 https://gradle.com/s/famc56y6mgge6

@bazarnov bazarnov temporarily deployed to more-secrets December 29, 2021 13:15 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets December 29, 2021 13:16 Inactive
@bazarnov
Copy link
Collaborator

bazarnov commented Dec 29, 2021

/test connector=connectors/source-quickbooks-singer

🕑 connectors/source-quickbooks-singer https://github.com/airbytehq/airbyte/actions/runs/1634285392
❌ connectors/source-quickbooks-singer https://github.com/airbytehq/airbyte/actions/runs/1634285392
🐛 https://gradle.com/s/aljovcklswkqk
Python short test summary info:

=========================== short test summary info ============================
FAILED test_core.py::TestConnection::test_check[inputs0] - docker.errors.Cont...
FAILED test_core.py::TestConnection::test_check[inputs1] - docker.errors.Cont...
FAILED test_core.py::TestDiscovery::test_discover[inputs0] - docker.errors.Co...
ERROR test_core.py::TestSpec::test_match_expected[inputs0] - docker.errors.Co...
ERROR test_core.py::TestSpec::test_defined_refs_exist_in_json_spec_file[inputs0]
ERROR test_core.py::TestSpec::test_oauth_flow_parameters[inputs0] - docker.er...
ERROR test_core.py::TestDiscovery::test_defined_cursors_exist_in_schema[inputs0]
ERROR test_core.py::TestDiscovery::test_defined_refs_exist_in_schema[inputs0]
ERROR test_core.py::TestBasicRead::test_read[inputs0] - docker.errors.Contain...
ERROR test_full_refresh.py::TestFullRefresh::test_sequential_reads[inputs0]
ERROR test_incremental.py::TestIncremental::test_two_sequential_reads[inputs0]
ERROR test_incremental.py::TestIncremental::test_state_with_abnormally_large_values[inputs0]
==================== 3 failed, 4 passed, 9 errors in 10.25s ====================

@bazarnov bazarnov temporarily deployed to more-secrets December 29, 2021 14:14 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets December 29, 2021 14:14 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets December 29, 2021 15:21 Inactive
@bazarnov bazarnov temporarily deployed to more-secrets December 29, 2021 15:26 Inactive
@bazarnov
Copy link
Collaborator

bazarnov commented Dec 29, 2021

/test connector=connectors/source-quickbooks-singer

🕑 connectors/source-quickbooks-singer https://github.com/airbytehq/airbyte/actions/runs/1634519211
❌ connectors/source-quickbooks-singer https://github.com/airbytehq/airbyte/actions/runs/1634519211
🐛

@bazarnov bazarnov temporarily deployed to more-secrets December 29, 2021 15:32 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets December 29, 2021 15:32 Inactive
@bazarnov
Copy link
Collaborator

bazarnov commented Dec 29, 2021

/test connector=connectors/source-quickbooks-singer

🕑 connectors/source-quickbooks-singer https://github.com/airbytehq/airbyte/actions/runs/1634552261
❌ connectors/source-quickbooks-singer https://github.com/airbytehq/airbyte/actions/runs/1634552261
🐛 https://gradle.com/s/plomjbm3yh4su

@bazarnov bazarnov temporarily deployed to more-secrets December 29, 2021 15:44 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets December 29, 2021 15:44 Inactive
@bazarnov
Copy link
Collaborator

bazarnov commented Dec 29, 2021

/test connector=connectors/source-quickbooks-singer

🕑 connectors/source-quickbooks-singer https://github.com/airbytehq/airbyte/actions/runs/1634606569
❌ connectors/source-quickbooks-singer https://github.com/airbytehq/airbyte/actions/runs/1634606569
🐛 https://gradle.com/s/spfx7owxzfjts

@bazarnov bazarnov temporarily deployed to more-secrets December 29, 2021 16:03 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets December 29, 2021 16:03 Inactive
@bazarnov
Copy link
Collaborator

bazarnov commented Dec 29, 2021

/test connector=connectors/source-quickbooks-singer

🕑 connectors/source-quickbooks-singer https://github.com/airbytehq/airbyte/actions/runs/1635153529
✅ connectors/source-quickbooks-singer https://github.com/airbytehq/airbyte/actions/runs/1635153529
Python tests coverage:

	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                                 Stmts   Miss  Cover
	 ------------------------------------------------------------------------
	 source_acceptance_test/__init__.py                       2      0   100%
	 source_acceptance_test/base.py                          10      4    60%
	 source_acceptance_test/config.py                        74      6    92%
	 source_acceptance_test/conftest.py                     109    109     0%
	 source_acceptance_test/plugin.py                        47     47     0%
	 source_acceptance_test/tests/__init__.py                 4      0   100%
	 source_acceptance_test/tests/test_core.py              242     96    60%
	 source_acceptance_test/tests/test_full_refresh.py       38      0   100%
	 source_acceptance_test/tests/test_incremental.py        69     38    45%
	 source_acceptance_test/utils/__init__.py                 6      0   100%
	 source_acceptance_test/utils/asserts.py                 37      2    95%
	 source_acceptance_test/utils/common.py                  54     17    69%
	 source_acceptance_test/utils/compare.py                 62     23    63%
	 source_acceptance_test/utils/connector_runner.py       110     48    56%
	 source_acceptance_test/utils/json_schema_helper.py     115     14    88%
	 ------------------------------------------------------------------------
	 TOTAL                                                  979    404    59%
	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                   Stmts   Miss  Cover
	 ----------------------------------------------------------
	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------/actions-runner/_work/airbyte/airbyte/airbyte-integrations/connectors/source-quickbooks-singer/.venv/lib/python3.8/site-packages/coverage/control.py:768: CoverageWarning: No data was collected. (no-data-collected)
	   self._warn("No data was collected.", slug="no-data-collected")
	 source_quickbooks_singer/__init__.py       2      2     0%
	 source_quickbooks_singer/source.py        36     36     0%
	 ----------------------------------------------------------
	 TOTAL                                     38     38     0%

@bazarnov bazarnov temporarily deployed to more-secrets December 29, 2021 19:31 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets December 29, 2021 19:32 Inactive
@bazarnov
Copy link
Collaborator

bazarnov commented Dec 29, 2021

/test connector=connectors/source-quickbooks-singer

🕑 connectors/source-quickbooks-singer https://github.com/airbytehq/airbyte/actions/runs/1635216716
✅ connectors/source-quickbooks-singer https://github.com/airbytehq/airbyte/actions/runs/1635216716
Python tests coverage:

	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                                 Stmts   Miss  Cover
	 ------------------------------------------------------------------------
	 source_acceptance_test/__init__.py                       2      0   100%
	 source_acceptance_test/base.py                          10      4    60%
	 source_acceptance_test/config.py                        74      6    92%
	 source_acceptance_test/conftest.py                     109    109     0%
	 source_acceptance_test/plugin.py                        47     47     0%
	 source_acceptance_test/tests/__init__.py                 4      0   100%
	 source_acceptance_test/tests/test_core.py              242     96    60%
	 source_acceptance_test/tests/test_full_refresh.py       38      0   100%
	 source_acceptance_test/tests/test_incremental.py        69     38    45%
	 source_acceptance_test/utils/__init__.py                 6      0   100%
	 source_acceptance_test/utils/asserts.py                 37      2    95%
	 source_acceptance_test/utils/common.py                  54     17    69%
	 source_acceptance_test/utils/compare.py                 62     23    63%
	 source_acceptance_test/utils/connector_runner.py       110     48    56%
	 source_acceptance_test/utils/json_schema_helper.py     115     14    88%
	 ------------------------------------------------------------------------
	 TOTAL                                                  979    404    59%
	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                   Stmts   Miss  Cover
	 Name                                   Stmts   Miss  Cover/actions-runner/_work/airbyte/airbyte/airbyte-integrations/connectors/source-quickbooks-singer/.venv/lib/python3.8/site-packages/coverage/control.py:768: CoverageWarning: No data was collected. (no-data-collected)
	   self._warn("No data was collected.", slug="no-data-collected")
	 ----------------------------------------------------------
	 source_quickbooks_singer/__init__.py       2      2     0%
	 source_quickbooks_singer/source.py        36     36     0%
	 ----------------------------------------------------------
	 TOTAL                                     38     38     0%

@bazarnov bazarnov temporarily deployed to more-secrets December 29, 2021 19:59 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets December 29, 2021 19:59 Inactive
@bazarnov
Copy link
Collaborator

bazarnov commented Dec 29, 2021

/publish connector=connectors/source-quickbooks-singer

🕑 connectors/source-quickbooks-singer https://github.com/airbytehq/airbyte/actions/runs/1635265302
✅ connectors/source-quickbooks-singer https://github.com/airbytehq/airbyte/actions/runs/1635265302

@bazarnov bazarnov temporarily deployed to more-secrets December 29, 2021 20:16 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets December 29, 2021 20:17 Inactive
@bazarnov bazarnov temporarily deployed to more-secrets December 29, 2021 20:26 Inactive
@bazarnov bazarnov merged commit 11dba47 into master Dec 29, 2021
@bazarnov bazarnov deleted the igrankova/issue-8372-update-title-description branch December 29, 2021 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Update fields in source-connectors specifications: quickbooks-singer
3 participants