-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add metadata to segment tracking #8872
Conversation
@@ -96,6 +96,7 @@ | |||
final JobOutput jobOutput = lastAttempt.getOutput().get(); | |||
if (jobOutput.getSync() != null) { | |||
final StandardSyncSummary syncSummary = jobOutput.getSync().getStandardSyncSummary(); | |||
metadata.put("sync_start_time", syncSummary.getStartTime()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we also add end time?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
duration is computed using the end time and we now have start time so we can always re-compute the reverse.
Let's leave it out to make the amount of data transiting through segment a little smaller
What
I'm proposing to add some properties to segment tracking.
If I look at data sent by Segment, for example:
I see that some tracking data for a job was sent on multiple different dates (all dates columns are auto-generated and handled by Segment)
see results:
query_results.txt
(Looking at the full source dataset from segment, I find 6 different dates for the same ids all the way back from
2021-09-22
)How