Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🎉 Source Kustomer: Clarify setup fields #8738

Merged
merged 19 commits into from
Dec 22, 2021
Merged

🎉 Source Kustomer: Clarify setup fields #8738

merged 19 commits into from
Dec 22, 2021

Conversation

lazebnyi
Copy link
Collaborator

@lazebnyi lazebnyi commented Dec 13, 2021 •
edited
Loading

What

#8697 - Kustomer source connector: investigate "user_agent" deprecation
#8698 - Kustomer source connector: remove "page_limit_size" option

How

Deleted user-agent, date_window_size, page_size_limit from spec.json file.
Default value for date_window_size and page_size_limit is 60 and 500.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here
  • After the new connector version is published, connector version bumped in the seed directory as described here
  • Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

@github-actions github-actions bot added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels Dec 13, 2021
This was linked to issues Dec 13, 2021
Kustomer source connector: investigate "user_agent" deprecation #8697
Closed
Kustomer source connector: remove "page_limit_size" option #8698
Closed
@lazebnyi lazebnyi changed the title Source Kustomer: Clarify setup fields 🎉 Source Kustomer: Clarify setup fields Dec 13, 2021
@lazebnyi
Copy link
Collaborator Author

lazebnyi commented Dec 13, 2021 •
edited by github-actions bot
Loading

/test connector=connectors/source-kustomer-singer

🕑 connectors/source-kustomer-singer https://github.com/airbytehq/airbyte/actions/runs/1572475836
✅ connectors/source-kustomer-singer https://github.com/airbytehq/airbyte/actions/runs/1572475836
No Python unittests run

@jrhizor jrhizor temporarily deployed to more-secrets December 13, 2021 10:47 Inactive
@lazebnyi lazebnyi requested review from antixar and bazarnov December 13, 2021 10:56
@lazebnyi lazebnyi temporarily deployed to more-secrets December 13, 2021 10:57 Inactive
@lazebnyi lazebnyi temporarily deployed to more-secrets December 13, 2021 10:58 Inactive
antixar
antixar reviewed Dec 13, 2021
View reviewed changes
Copy link
Contributor

@antixar antixar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove these options in other files too: invalid_config.json
And please add an integration "check" test with the old config format.

@bazarnov
Copy link
Collaborator

bazarnov commented Dec 13, 2021 •
edited
Loading

Is this Default value for date_window_size and page_size_limit is 60 and 500 agreed with the Client, or something else? How those values are picked?
Have you committed the code changes?

@lazebnyi
Copy link
Collaborator Author

@bazarnov This is the default value that is set by the singer (https://github.com/singer-io/tap-kustomer/blob/b56a2cc3646d57b8c1eb8876a335073a8968fd00/tap_kustomer/sync.py#L12). Permission for delete those fields from the config is based on PR description and UX handbook.

@lazebnyi lazebnyi requested a review from antixar December 16, 2021 15:20
@lazebnyi lazebnyi temporarily deployed to more-secrets December 16, 2021 15:21 Inactive
antixar
antixar approved these changes Dec 17, 2021
View reviewed changes
Copy link
Contributor

@antixar antixar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately this connector doesn't support the relevant test framework(SAT) fully. For this the connector must be migrated to CDK. Airbyte team knows about this and has approved its publishing without adding of new tests.
@lazebnyi , please, publish this

@lazebnyi
Copy link
Collaborator Author

lazebnyi commented Dec 17, 2021 •
edited by github-actions bot
Loading

/publish connector=connectors/source-kustomer-singer

🕑 connectors/source-kustomer-singer https://github.com/airbytehq/airbyte/actions/runs/1592430465
❌ connectors/source-kustomer-singer https://github.com/airbytehq/airbyte/actions/runs/1592430465

@jrhizor jrhizor temporarily deployed to more-secrets December 17, 2021 13:30 Inactive
@lazebnyi lazebnyi marked this pull request as ready for review December 17, 2021 13:38
@lazebnyi lazebnyi temporarily deployed to more-secrets December 17, 2021 13:55 Inactive
@lazebnyi
Copy link
Collaborator Author

lazebnyi commented Dec 17, 2021 •
edited by github-actions bot
Loading

/publish connector=connectors/source-kustomer-singer

🕑 connectors/source-kustomer-singer https://github.com/airbytehq/airbyte/actions/runs/1592537102
❌ connectors/source-kustomer-singer https://github.com/airbytehq/airbyte/actions/runs/1592537102

@lazebnyi lazebnyi temporarily deployed to more-secrets December 17, 2021 13:58 Inactive
@lazebnyi lazebnyi temporarily deployed to more-secrets December 22, 2021 16:52 Inactive
@lazebnyi
Copy link
Collaborator Author

lazebnyi commented Dec 22, 2021 •
edited by github-actions bot
Loading

/test connector=connectors/source-kustomer-singer

🕑 connectors/source-kustomer-singer https://github.com/airbytehq/airbyte/actions/runs/1612279110
✅ connectors/source-kustomer-singer https://github.com/airbytehq/airbyte/actions/runs/1612279110
No Python unittests run

@jrhizor jrhizor temporarily deployed to more-secrets December 22, 2021 17:04 Inactive
@lazebnyi
Copy link
Collaborator Author

lazebnyi commented Dec 22, 2021 •
edited by github-actions bot
Loading

/publish connector=connectors/source-kustomer-singer

🕑 connectors/source-kustomer-singer https://github.com/airbytehq/airbyte/actions/runs/1612303206
❌ connectors/source-kustomer-singer https://github.com/airbytehq/airbyte/actions/runs/1612303206

@jrhizor jrhizor temporarily deployed to more-secrets December 22, 2021 17:10 Inactive
@lazebnyi
Copy link
Collaborator Author

lazebnyi commented Dec 22, 2021 •
edited by github-actions bot
Loading

/publish connector=connectors/source-kustomer-singer

🕑 connectors/source-kustomer-singer https://github.com/airbytehq/airbyte/actions/runs/1612339858
❌ connectors/source-kustomer-singer https://github.com/airbytehq/airbyte/actions/runs/1612339858

@lazebnyi lazebnyi temporarily deployed to more-secrets December 22, 2021 17:19 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets December 22, 2021 17:20 Inactive
@lazebnyi
Copy link
Collaborator Author

lazebnyi commented Dec 22, 2021 •
edited by github-actions bot
Loading

/publish connector=connectors/source-kustomer-singer

🕑 connectors/source-kustomer-singer https://github.com/airbytehq/airbyte/actions/runs/1612448617
❌ connectors/source-kustomer-singer https://github.com/airbytehq/airbyte/actions/runs/1612448617

@lazebnyi lazebnyi temporarily deployed to more-secrets December 22, 2021 17:52 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets December 22, 2021 17:53 Inactive
@lazebnyi
Copy link
Collaborator Author

lazebnyi commented Dec 22, 2021 •
edited by github-actions bot
Loading

/publish connector=connectors/source-kustomer-singer

🕑 connectors/source-kustomer-singer https://github.com/airbytehq/airbyte/actions/runs/1612493643
❌ connectors/source-kustomer-singer https://github.com/airbytehq/airbyte/actions/runs/1612493643

@lazebnyi lazebnyi temporarily deployed to more-secrets December 22, 2021 18:06 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets December 22, 2021 18:07 Inactive
@lazebnyi
Copy link
Collaborator Author

lazebnyi commented Dec 22, 2021 •
edited by github-actions bot
Loading

/publish connector=connectors/source-kustomer-singer

🕑 connectors/source-kustomer-singer https://github.com/airbytehq/airbyte/actions/runs/1612517508
❌ connectors/source-kustomer-singer https://github.com/airbytehq/airbyte/actions/runs/1612517508

@lazebnyi lazebnyi temporarily deployed to more-secrets December 22, 2021 18:13 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets December 22, 2021 18:14 Inactive
@lazebnyi
Copy link
Collaborator Author

lazebnyi commented Dec 22, 2021 •
edited by github-actions bot
Loading

/publish connector=connectors/source-kustomer-singer

🕑 connectors/source-kustomer-singer https://github.com/airbytehq/airbyte/actions/runs/1612545568
✅ connectors/source-kustomer-singer https://github.com/airbytehq/airbyte/actions/runs/1612545568

@lazebnyi lazebnyi temporarily deployed to more-secrets December 22, 2021 18:21 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets December 22, 2021 18:22 Inactive
@lazebnyi lazebnyi merged commit 2a1dbe7 into master Dec 22, 2021
@lazebnyi lazebnyi deleted the lazebnyi/8697-kustomer-clarify-setup-fields branch December 22, 2021 18:28
@jrhizor jrhizor mentioned this pull request Dec 27, 2021
Merged
@ivansabik ivansabik mentioned this pull request Jul 28, 2022
Closed
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antixar antixar antixar approved these changes

@bazarnov bazarnov bazarnov approved these changes

Assignees
No one assigned
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
4 participants
@lazebnyi @bazarnov @antixar @jrhizor