🎉 Source Facebook pages: updated all empty objects in Page and Post streams #8267

midavadim · 2021-11-26T11:14:05Z

What

Source Facebook pages: updated all empty objects in Page and Post streams #8267

Issue: #7673
Source Facebook Pages Invalid JSON schema

How

added schema generation based on FB git .

🚨 User Impact 🚨

Schema changes means that customer will need to refresh scehmas for all existing connections

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
Credentials added to Github CI. Instructions.
/test connector=connectors/<name> command is passing.
New Connector version released on Dockerhub by running the /publish command described here
After the connector is published, connector added to connector index as described here
Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Updating a connector

Community member or Airbyter

Grant edit access to maintainers (instructions)
Secrets in the connector's spec are annotated with airbyte_secret
Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
Code reviews completed
Documentation updated
- Connector's README.md
- Connector's bootstrap.md. See description and examples
- Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
Credentials added to Github CI. Instructions.
/test connector=connectors/<name> command is passing.
New Connector version released on Dockerhub by running the /publish command described here
After the new connector version is published, connector version bumped in the seed directory as described here
Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Connector Generator

Issue acceptance criteria met
PR name follows PR naming conventions
If adding a new generator, add it to the list of scaffold modules being tested
The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
Documentation which references the generator is updated as needed.

…with references to sub nodes, fixed fields for page stream, added TypeTransformer because some attributes should be explicitly converted to strings. Added schema generation tool

CLAassistant · 2021-11-26T11:14:14Z

All committers have signed the CLA.

bazarnov · 2021-11-26T12:47:44Z

@midavadim
Please fix the conflicts on the branch, as well as try to pass the CI SAT tests for the connector, before review.

…book-fix-schemas # Conflicts: # airbyte-integrations/connectors/source-facebook-pages/source_facebook_pages/metrics.py # airbyte-integrations/connectors/source-facebook-pages/source_facebook_pages/schemas/page.json

midavadim · 2021-11-26T16:16:48Z

/test connector=connectors/source-facebook-pages

🕑 connectors/source-facebook-pages https://github.com/airbytehq/airbyte/actions/runs/1508267528
❌ connectors/source-facebook-pages https://github.com/airbytehq/airbyte/actions/runs/1508267528
🐛 https://gradle.com/s/ml7mqgeou5egi

midavadim · 2021-11-26T16:52:12Z

/test connector=connectors/source-facebook-pages

🕑 connectors/source-facebook-pages https://github.com/airbytehq/airbyte/actions/runs/1508360143
✅ connectors/source-facebook-pages https://github.com/airbytehq/airbyte/actions/runs/1508360143
Python tests coverage:

	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                                 Stmts   Miss  Cover
	 ------------------------------------------------------------------------
	 source_acceptance_test/__init__.py                       2      0   100%
	 source_acceptance_test/base.py                          10      4    60%
	 source_acceptance_test/config.py                        75      8    89%
	 source_acceptance_test/conftest.py                     108    108     0%
	 source_acceptance_test/plugin.py                        47     47     0%
	 source_acceptance_test/tests/__init__.py                 4      0   100%
	 source_acceptance_test/tests/test_core.py              200     94    53%
	 source_acceptance_test/tests/test_full_refresh.py       38     27    29%
	 source_acceptance_test/tests/test_incremental.py        69     38    45%
	 source_acceptance_test/utils/__init__.py                 6      0   100%
	 source_acceptance_test/utils/asserts.py                 37      2    95%
	 source_acceptance_test/utils/common.py                  41     24    41%
	 source_acceptance_test/utils/compare.py                 62     25    60%
	 source_acceptance_test/utils/connector_runner.py        82     49    40%
	 source_acceptance_test/utils/json_schema_helper.py     115     14    88%
	 ------------------------------------------------------------------------
	 TOTAL                                                  896    440    51%
	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                Stmts   Miss  Cover
	 -------------------------------------------------------
	 source_facebook_pages/__init__.py       2      0   100%
	 source_facebook_pages/metrics.py        4      0   100%
	 source_facebook_pages/source.py        29     17    41%
	 source_facebook_pages/streams.py       74     34    54%
	 -------------------------------------------------------
	 TOTAL                                 109     51    53%

antixar

Could you add a shot draft of schemas' parsing to a bootstrap.md ?

airbyte-integrations/connectors/source-facebook-pages/source_facebook_pages/metrics.py

ChristopheDuong

It would be nice to put in the description of the PR the link to the parent/related issue #7673 instead of linking to the PR itself

airbyte-integrations/connectors/source-facebook-pages/tools/schema_gen.py

midavadim · 2021-12-02T18:20:59Z

/test connector=connectors/source-facebook-pages

🕑 connectors/source-facebook-pages https://github.com/airbytehq/airbyte/actions/runs/1531929968
✅ connectors/source-facebook-pages https://github.com/airbytehq/airbyte/actions/runs/1531929968
Python tests coverage:

	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                                 Stmts   Miss  Cover
	 ------------------------------------------------------------------------
	 source_acceptance_test/__init__.py                       2      0   100%
	 source_acceptance_test/base.py                          10      4    60%
	 source_acceptance_test/config.py                        75      8    89%
	 source_acceptance_test/conftest.py                     108    108     0%
	 source_acceptance_test/plugin.py                        47     47     0%
	 source_acceptance_test/tests/__init__.py                 4      0   100%
	 source_acceptance_test/tests/test_core.py              200     94    53%
	 source_acceptance_test/tests/test_full_refresh.py       38     27    29%
	 source_acceptance_test/tests/test_incremental.py        69     38    45%
	 source_acceptance_test/utils/__init__.py                 6      0   100%
	 source_acceptance_test/utils/asserts.py                 37      2    95%
	 source_acceptance_test/utils/common.py                  41     24    41%
	 source_acceptance_test/utils/compare.py                 62     25    60%
	 source_acceptance_test/utils/connector_runner.py        82     49    40%
	 source_acceptance_test/utils/json_schema_helper.py     115     14    88%
	 ------------------------------------------------------------------------
	 TOTAL                                                  896    440    51%
	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                Stmts   Miss  Cover
	 -------------------------------------------------------
	 source_facebook_pages/__init__.py       2      0   100%
	 source_facebook_pages/metrics.py        4      0   100%
	 source_facebook_pages/source.py        29     17    41%
	 source_facebook_pages/streams.py       74     34    54%
	 -------------------------------------------------------
	 TOTAL                                 109     51    53%

midavadim · 2021-12-02T18:49:10Z

/publish connector=connectors/source-facebook-pages

🕑 connectors/source-facebook-pages https://github.com/airbytehq/airbyte/actions/runs/1532030147
✅ connectors/source-facebook-pages https://github.com/airbytehq/airbyte/actions/runs/1532030147

midavadim · 2021-12-02T18:57:57Z

/test connector=connectors/source-facebook-pages

🕑 connectors/source-facebook-pages https://github.com/airbytehq/airbyte/actions/runs/1532061964
✅ connectors/source-facebook-pages https://github.com/airbytehq/airbyte/actions/runs/1532061964
Python tests coverage:

	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                                 Stmts   Miss  Cover
	 ------------------------------------------------------------------------
	 source_acceptance_test/__init__.py                       2      0   100%
	 source_acceptance_test/base.py                          10      4    60%
	 source_acceptance_test/config.py                        75      8    89%
	 source_acceptance_test/conftest.py                     108    108     0%
	 source_acceptance_test/plugin.py                        47     47     0%
	 source_acceptance_test/tests/__init__.py                 4      0   100%
	 source_acceptance_test/tests/test_core.py              200     94    53%
	 source_acceptance_test/tests/test_full_refresh.py       38     27    29%
	 source_acceptance_test/tests/test_incremental.py        69     38    45%
	 source_acceptance_test/utils/__init__.py                 6      0   100%
	 source_acceptance_test/utils/asserts.py                 37      2    95%
	 source_acceptance_test/utils/common.py                  41     24    41%
	 source_acceptance_test/utils/compare.py                 62     25    60%
	 source_acceptance_test/utils/connector_runner.py        82     49    40%
	 source_acceptance_test/utils/json_schema_helper.py     115     14    88%
	 ------------------------------------------------------------------------
	 TOTAL                                                  896    440    51%
	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                Stmts   Miss  Cover
	 -------------------------------------------------------
	 source_facebook_pages/__init__.py       2      0   100%
	 source_facebook_pages/metrics.py        4      0   100%
	 source_facebook_pages/source.py        29     17    41%
	 source_facebook_pages/streams.py       74     34    54%
	 -------------------------------------------------------
	 TOTAL                                 109     51    53%

jrhizor · 2021-12-02T19:51:18Z

Please remember to update the seed spec which causes build failures like https://github.com/airbytehq/airbyte/runs/4399670905?check_suite_focus=true

From the PR template:

Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

…treams (airbytehq#8267) * updated part of non-defined object properties * Updates schema for Page and Post streams, empty objects are replaced with references to sub nodes, fixed fields for page stream, added TypeTransformer because some attributes should be explicitly converted to strings. Added schema generation tool * updated docs * fixed format issues * enhanced schemas - added datatime format, float is saved as number * updated source version

midavadim added 2 commits November 16, 2021 19:37

updated part of non-defined object properties

97d998f

Updates schema for Page and Post streams, empty objects are replaced …

5cf45b0

…with references to sub nodes, fixed fields for page stream, added TypeTransformer because some attributes should be explicitly converted to strings. Added schema generation tool

github-actions bot added the area/connectors Connector related issues label Nov 26, 2021

midavadim requested review from antixar and bazarnov November 26, 2021 11:18

midavadim linked an issue Nov 26, 2021 that may be closed by this pull request

Source Facebook Pages Invalid JSON schema #7673

Closed

midavadim added 2 commits November 26, 2021 16:57

updated docs

3ae2601

github-actions bot added the area/documentation Improvements or additions to documentation label Nov 26, 2021

midavadim temporarily deployed to more-secrets November 26, 2021 15:37 Inactive

jrhizor temporarily deployed to more-secrets November 26, 2021 16:19 Inactive

fixed format issues

724f7d6

midavadim temporarily deployed to more-secrets November 26, 2021 16:51 Inactive

jrhizor temporarily deployed to more-secrets November 26, 2021 16:54 Inactive

bazarnov approved these changes Nov 27, 2021

View reviewed changes

avida mentioned this pull request Nov 29, 2021

✨ Source Facebook Marketing: Added fields in campaign schema #8257

Merged

16 tasks

antixar approved these changes Nov 29, 2021

View reviewed changes

midavadim requested a review from ChristopheDuong November 30, 2021 17:16

ChristopheDuong reviewed Nov 30, 2021

View reviewed changes

airbyte-integrations/connectors/source-facebook-pages/source_facebook_pages/metrics.py Show resolved Hide resolved

ChristopheDuong approved these changes Nov 30, 2021

View reviewed changes

ChristopheDuong reviewed Nov 30, 2021

View reviewed changes

airbyte-integrations/connectors/source-facebook-pages/tools/schema_gen.py Outdated Show resolved Hide resolved

ChristopheDuong reviewed Nov 30, 2021

View reviewed changes

airbyte-integrations/connectors/source-facebook-pages/tools/schema_gen.py Outdated Show resolved Hide resolved

enhanced schemas - added datatime format, float is saved as number

60a6e3a

midavadim temporarily deployed to more-secrets December 2, 2021 18:04 Inactive

jrhizor temporarily deployed to more-secrets December 2, 2021 18:23 Inactive

updated source version

c56019a

midavadim temporarily deployed to more-secrets December 2, 2021 18:48 Inactive

jrhizor temporarily deployed to more-secrets December 2, 2021 18:51 Inactive

jrhizor temporarily deployed to more-secrets December 2, 2021 19:00 Inactive

midavadim merged commit 5ce8339 into master Dec 2, 2021

midavadim deleted the midavadim/7673-facebook-fix-schemas branch December 2, 2021 19:09

jrhizor mentioned this pull request Dec 3, 2021

Bump Airbyte version from 0.32.11-alpha to 0.33.0-alpha #8497

Merged

igrankova added connectors/sources-api connectors/source/facebook-pages labels Jan 6, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

🎉 Source Facebook pages: updated all empty objects in Page and Post streams #8267

🎉 Source Facebook pages: updated all empty objects in Page and Post streams #8267

midavadim commented Nov 26, 2021 •

edited

Loading

CLAassistant commented Nov 26, 2021 •

edited

Loading

bazarnov commented Nov 26, 2021 •

edited

Loading

midavadim commented Nov 26, 2021 •

edited by github-actions bot

Loading

midavadim commented Nov 26, 2021 •

edited by github-actions bot

Loading

antixar left a comment

ChristopheDuong left a comment •

edited

Loading

midavadim commented Dec 2, 2021 •

edited by github-actions bot

Loading

midavadim commented Dec 2, 2021 •

edited by github-actions bot

Loading

midavadim commented Dec 2, 2021 •

edited by github-actions bot

Loading

jrhizor commented Dec 2, 2021

🎉 Source Facebook pages: updated all empty objects in Page and Post streams #8267

🎉 Source Facebook pages: updated all empty objects in Page and Post streams #8267

Conversation

midavadim commented Nov 26, 2021 • edited Loading

What

How

Recommended reading order

🚨 User Impact 🚨

Pre-merge Checklist

Community member or Airbyter

Airbyter

Community member or Airbyter

Airbyter

CLAassistant commented Nov 26, 2021 • edited Loading

bazarnov commented Nov 26, 2021 • edited Loading

midavadim commented Nov 26, 2021 • edited by github-actions bot Loading

midavadim commented Nov 26, 2021 • edited by github-actions bot Loading

antixar left a comment

Choose a reason for hiding this comment

ChristopheDuong left a comment • edited Loading

Choose a reason for hiding this comment

midavadim commented Dec 2, 2021 • edited by github-actions bot Loading

midavadim commented Dec 2, 2021 • edited by github-actions bot Loading

midavadim commented Dec 2, 2021 • edited by github-actions bot Loading

jrhizor commented Dec 2, 2021

midavadim commented Nov 26, 2021 •

edited

Loading

CLAassistant commented Nov 26, 2021 •

edited

Loading

bazarnov commented Nov 26, 2021 •

edited

Loading

midavadim commented Nov 26, 2021 •

edited by github-actions bot

Loading

midavadim commented Nov 26, 2021 •

edited by github-actions bot

Loading

ChristopheDuong left a comment •

edited

Loading

midavadim commented Dec 2, 2021 •

edited by github-actions bot

Loading

midavadim commented Dec 2, 2021 •

edited by github-actions bot

Loading

midavadim commented Dec 2, 2021 •

edited by github-actions bot

Loading