Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix first sync check NPE #8101

Merged
merged 1 commit into from
Nov 18, 2021
Merged

fix first sync check NPE #8101

merged 1 commit into from
Nov 18, 2021

Conversation

jrhizor
Copy link
Contributor

@jrhizor jrhizor commented Nov 18, 2021

At the end of my successful sync with a workspace that was created before #7832, I get:

java.lang.NullPointerException: Cannot invoke "java.lang.Boolean.booleanValue()" because the return value of "io.airbyte.config.StandardWorkspace.getFirstCompletedSync()" is null
	at io.airbyte.scheduler.app.JobSubmitter.lambda$submitJob$2(JobSubmitter.java:147) ~[io.airbyte.airbyte-scheduler-app-0.32.2-alpha.jar:?]
	at io.airbyte.commons.concurrency.LifecycledCallable.onSuccess(LifecycledCallable.java:99) [io.airbyte-airbyte-commons-0.32.2-alpha.jar:?]
	at io.airbyte.commons.concurrency.LifecycledCallable.call(LifecycledCallable.java:79) [io.airbyte-airbyte-commons-0.32.2-alpha.jar:?]
	at java.util.concurrent.FutureTask.run(FutureTask.java:264) [?:?]
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136) [?:?]
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635) [?:?]
	at java.lang.Thread.run(Thread.java:833) [?:?]

This isn't that terrible since it doesn't actually break the sync.

@jrhizor jrhizor requested a review from benmoriceau November 18, 2021 16:45
@github-actions github-actions bot added area/platform issues related to the platform area/scheduler labels Nov 18, 2021
@jrhizor jrhizor temporarily deployed to more-secrets November 18, 2021 16:46 Inactive
@jrhizor jrhizor merged commit dcd3b93 into master Nov 18, 2021
@jrhizor jrhizor deleted the jrhizor/fix-npe branch November 18, 2021 23:07
schlattk pushed a commit to schlattk/airbyte that referenced this pull request Jan 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/platform issues related to the platform area/scheduler
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants