Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Akorotkov/6544 mongo performance issues #8098

Merged
merged 9 commits into from
Nov 18, 2021
Merged

Akorotkov/6544 mongo performance issues #8098

merged 9 commits into from
Nov 18, 2021

Conversation

andriikorotkov
Copy link
Contributor

What

Describe what the change is solving
It helps to add screenshots if it affects the frontend.

How

Describe the solution

Recommended reading order

  1. x.java
  2. y.python

🚨 User Impact 🚨

Are there any breaking changes? If yes, please make sure to include it here and in any changelogs with the 🚨🚨 emoji
What is the end result perceived by the user?

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

  • Community member? Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • docs/SUMMARY.md
    • docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
    • docs/integrations/README.md
    • airbyte-integrations/builds.md
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here
  • After the connector is published, connector added to connector index as described here
  • Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here
  • After the new connector version is published, connector version bumped in the seed directory as described here
  • Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Connector Generator

  • Issue acceptance criteria met
  • PR name follows PR naming conventions
  • If adding a new generator, add it to the list of scaffold modules being tested
  • The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
  • Documentation which references the generator is updated as needed.

@andriikorotkov
updated source-mongodb-v2 performance
f77238f
@andriikorotkov
updated code style
6ac8c93
@andriikorotkov
Merge branch 'master' of github.com:airbytehq/airbyte into akorotkov/…
6e3f202 
…6544-mongo-performance-issues
@andriikorotkov
fixed remarks
9ff2bfd
@andriikorotkov
fixed remarks
4eb9d09
@andriikorotkov
fixed remarks
451fe71
@andriikorotkov
updated strict encrypt source mongodb version
ae3c06e
@andriikorotkov
Merge branch 'master' of github.com:airbytehq/airbyte into akorotkov/…
5f19252 
…6544-mongo-performance-issues

� Conflicts:
�	airbyte-config/init/src/main/resources/config/STANDARD_SOURCE_DEFINITION/b2e713cd-cc36-4c0a-b5bd-b47cb8a0561e.json
�	airbyte-config/init/src/main/resources/seed/source_definitions.yaml
�	airbyte-integrations/connectors/source-mongodb-strict-encrypt/Dockerfile
�	airbyte-integrations/connectors/source-mongodb-v2/Dockerfile
�	docs/integrations/sources/mongodb-v2.md
@andriikorotkov
updated source mongodb work with empty collections
a1d23ff
@github-actions github-actions bot added the area/connectors Connector related issues label Nov 18, 2021
@andriikorotkov
Copy link
Contributor Author

andriikorotkov commented Nov 18, 2021 •
edited by github-actions bot
Loading

/test connector=connectors/source-mongodb-v2

🕑 connectors/source-mongodb-v2 https://github.com/airbytehq/airbyte/actions/runs/1477111606
✅ connectors/source-mongodb-v2 https://github.com/airbytehq/airbyte/actions/runs/1477111606
No Python unittests run

@andriikorotkov
Copy link
Contributor Author

andriikorotkov commented Nov 18, 2021 •
edited by github-actions bot
Loading

/test connector=connectors/source-mongodb-strict-encrypt

🕑 connectors/source-mongodb-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/1477112248
✅ connectors/source-mongodb-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/1477112248
No Python unittests run

@jrhizor jrhizor temporarily deployed to more-secrets November 18, 2021 15:32 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets November 18, 2021 15:32 Inactive
alexandr-shegeda
alexandr-shegeda approved these changes Nov 18, 2021
View reviewed changes
Copy link
Contributor

@alexandr-shegeda alexandr-shegeda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. we can proceed with publishing and merge without airbyte review

@andriikorotkov
Copy link
Contributor Author

andriikorotkov commented Nov 18, 2021 •
edited by github-actions bot
Loading

/publish connector=connectors/source-mongodb-v2

🕑 connectors/source-mongodb-v2 https://github.com/airbytehq/airbyte/actions/runs/1477225594
✅ connectors/source-mongodb-v2 https://github.com/airbytehq/airbyte/actions/runs/1477225594

@andriikorotkov
Copy link
Contributor Author

andriikorotkov commented Nov 18, 2021 •
edited by github-actions bot
Loading

/publish connector=connectors/source-mongodb-strict-encrypt

🕑 connectors/source-mongodb-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/1477225969
✅ connectors/source-mongodb-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/1477225969

@jrhizor jrhizor temporarily deployed to more-secrets November 18, 2021 16:00 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets November 18, 2021 16:00 Inactive
@andriikorotkov andriikorotkov marked this pull request as ready for review November 18, 2021 16:14
@andriikorotkov andriikorotkov temporarily deployed to more-secrets November 18, 2021 16:16 Inactive
@andriikorotkov andriikorotkov merged commit 9eb78a4 into master Nov 18, 2021
@andriikorotkov andriikorotkov deleted the akorotkov/6544-mongo-performance-issues branch November 18, 2021 16:24
This was referenced Nov 18, 2021
Merged
Closed
@joelluijmes joelluijmes mentioned this pull request Dec 3, 2021
Merged
40 tasks
schlattk pushed a commit to schlattk/airbyte that referenced this pull request Jan 4, 2022
@andriikorotkov @schlattk
Akorotkov/6544 mongo performance issues (airbytehq#8098)
e128030 
* updated source-mongodb-v2 performance

* updated code style

* fixed remarks

* fixed remarks

* fixed remarks

* updated strict encrypt source mongodb version

* updated source mongodb work with empty collections
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexandr-shegeda alexandr-shegeda alexandr-shegeda approved these changes

Assignees
No one assigned
Labels
area/connectors Connector related issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andriikorotkov @alexandr-shegeda @jrhizor