[IGNORE] Branch for integration-tests PR 7620 #7786

alexandertsukanov · 2021-11-09T14:57:38Z

What

Describe what the change is solving
It helps to add screenshots if it affects the frontend.

How

Describe the solution

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
Credentials added to Github CI. Instructions.
/test connector=connectors/<name> command is passing.
New Connector version released on Dockerhub by running the /publish command described here
After the connector is published, connector added to connector index as described here
Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Updating a connector

Community member or Airbyter

Grant edit access to maintainers (instructions)
Secrets in the connector's spec are annotated with airbyte_secret
Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
Code reviews completed
Documentation updated
- Connector's README.md
- Connector's bootstrap.md. See description and examples
- Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
Credentials added to Github CI. Instructions.
/test connector=connectors/<name> command is passing.
New Connector version released on Dockerhub by running the /publish command described here
After the new connector version is published, connector version bumped in the seed directory as described here
Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Connector Generator

Issue acceptance criteria met
PR name follows PR naming conventions
If adding a new generator, add it to the list of scaffold modules being tested
The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
Documentation which references the generator is updated as needed.

This change is

…ukanov/branch_for_test_pr_7620 Merge branch to pass integration tests

alexandertsukanov · 2021-11-09T15:00:07Z

/test connector=connectors/destination-clickhouse

🕑 connectors/destination-clickhouse https://github.com/airbytehq/airbyte/actions/runs/1440032992
❌ connectors/destination-clickhouse https://github.com/airbytehq/airbyte/actions/runs/1440032992
🐛 https://gradle.com/s/yzoricljih3wc

alexandertsukanov · 2021-11-09T15:01:30Z

/test connector=connectors/destination-clickhouse-strict-encrypt

🕑 connectors/destination-clickhouse-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/1440039711
✅ connectors/destination-clickhouse-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/1440039711
No Python unittests run

ChristopheDuong

You've been running integration tests for connector=connectors/destination-clickhouse

but the original PR is also introducing critical changes to normalization... make sure it passes connector=bases/base-normalization too

ChristopheDuong · 2021-11-12T15:37:01Z

/test connector=bases-base-normalization

🕑 bases-base-normalization https://github.com/airbytehq/airbyte/actions/runs/1453707249
❌ bases-base-normalization https://github.com/airbytehq/airbyte/actions/runs/1453707249
🐛

alexandertsukanov · 2021-11-12T16:00:36Z

You've been running integration tests for connector=connectors/destination-clickhouse

but the original PR is also introducing critical changes to normalization... make sure it passes connector=bases/base-normalization too

Thanks for pointing out that.

…ukanov/branch_for_test_pr_7620

alexandertsukanov · 2021-11-15T13:10:48Z

/test connector=bases-base-normalization

🕑 bases-base-normalization https://github.com/airbytehq/airbyte/actions/runs/1462293406
❌ bases-base-normalization https://github.com/airbytehq/airbyte/actions/runs/1462293406
🐛

alexandertsukanov · 2021-11-15T13:11:03Z

/test connector=connectors/destination-clickhouse

🕑 connectors/destination-clickhouse https://github.com/airbytehq/airbyte/actions/runs/1462294924
✅ connectors/destination-clickhouse https://github.com/airbytehq/airbyte/actions/runs/1462294924
No Python unittests run

alexandertsukanov · 2021-11-15T13:11:21Z

/test connector=connectors/destination-clickhouse-strict-encrypt

🕑 connectors/destination-clickhouse-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/1462302154
❌ connectors/destination-clickhouse-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/1462302154
🐛 https://gradle.com/s/hnk7msvldqbr6

…ukanov/branch_for_test_pr_7620

alexandertsukanov · 2021-11-17T12:49:45Z

/test connector=connectors/destination-clickhouse-strict-encrypt

🕑 connectors/destination-clickhouse-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/1471621868
✅ connectors/destination-clickhouse-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/1471621868
No Python unittests run

…ukanov/branch_for_test_pr_7620

alexandertsukanov · 2021-11-29T09:09:49Z

/test connector=bases-base-normalization

🕑 bases-base-normalization https://github.com/airbytehq/airbyte/actions/runs/1515209824
❌ bases-base-normalization https://github.com/airbytehq/airbyte/actions/runs/1515209824
🐛

alexandertsukanov · 2021-11-29T09:10:00Z

/test connector=connectors/destination-clickhouse

🕑 connectors/destination-clickhouse https://github.com/airbytehq/airbyte/actions/runs/1515206500
✅ connectors/destination-clickhouse https://github.com/airbytehq/airbyte/actions/runs/1515206500
No Python unittests run

alexandertsukanov · 2021-11-29T09:10:08Z

/test connector=connectors/destination-clickhouse-strict-encrypt

🕑 connectors/destination-clickhouse-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/1515206943
✅ connectors/destination-clickhouse-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/1515206943
No Python unittests run

burmecia and others added 9 commits November 4, 2021 15:42

add ClickHouse destination

59be9e6

update docs

410e9c9

format code

ff94b62

code improvement as per code review

aff0c61

add ssh tunneling and ssl/tls support and code enhancement

27fddcf

merge from master

b1eaa31

merge from master

09f3fa6

Merge branch 'master' into new-dest-clickhouse

d954ca8

Merge remote-tracking branch 'pr-source/new-dest-clickhouse' into ots…

f05de4e

…ukanov/branch_for_test_pr_7620 Merge branch to pass integration tests

alexandertsukanov temporarily deployed to more-secrets November 9, 2021 14:57 Inactive

github-actions bot added area/connectors Connector related issues area/documentation Improvements or additions to documentation area/platform issues related to the platform area/worker Related to worker normalization labels Nov 9, 2021

jrhizor temporarily deployed to more-secrets November 9, 2021 15:02 Inactive

jrhizor temporarily deployed to more-secrets November 9, 2021 15:03 Inactive

alexandertsukanov mentioned this pull request Nov 9, 2021

🎉 New Destination: ClickHouse #7620

Merged

38 tasks

burmecia added 4 commits November 10, 2021 11:16

Merge branch 'master' into new-dest-clickhouse

6b76313

disable testCustomDbtTransformationsFailure test

4fc08be

fix string format bug

b7d12cc

Merge branch 'master' into new-dest-clickhouse

856233b

ChristopheDuong suggested changes Nov 12, 2021

View reviewed changes

jrhizor temporarily deployed to more-secrets November 12, 2021 15:39 Inactive

burmecia and others added 2 commits November 13, 2021 12:35

fix reserved keywords bug and disable dbt

282febe

Merge remote-tracking branch 'pr-source/new-dest-clickhouse' into ots…

33cedf3

…ukanov/branch_for_test_pr_7620

alexandertsukanov temporarily deployed to more-secrets November 15, 2021 13:11 Inactive

jrhizor temporarily deployed to more-secrets November 15, 2021 13:13 Inactive

jrhizor temporarily deployed to more-secrets November 15, 2021 13:14 Inactive

burmecia and others added 2 commits November 17, 2021 22:45

disable dbt in expect result

43e39f6

Merge remote-tracking branch 'pr-source/new-dest-clickhouse' into ots…

0acef86

…ukanov/branch_for_test_pr_7620

alexandertsukanov temporarily deployed to more-secrets November 17, 2021 12:44 Inactive

jrhizor temporarily deployed to more-secrets November 17, 2021 12:52 Inactive

burmecia and others added 4 commits November 26, 2021 10:43

add type hints

d85eb1f

merge from master

2aadea4

Merge branch 'master' into new-dest-clickhouse

9589702

Merge remote-tracking branch 'pr-source/new-dest-clickhouse' into ots…

d4a6b60

…ukanov/branch_for_test_pr_7620

alexandertsukanov temporarily deployed to more-secrets November 29, 2021 09:10 Inactive

jrhizor temporarily deployed to more-secrets November 29, 2021 09:12 Inactive

karinakuz added connectors/destinations-warehouse connectors/destination/clickhouse labels Jan 14, 2022

alexandertsukanov closed this Feb 11, 2022

swyxio deleted the otsukanov/branch_for_test_pr_7620 branch October 12, 2022 18:21

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[IGNORE] Branch for integration-tests PR 7620 #7786

[IGNORE] Branch for integration-tests PR 7620 #7786

alexandertsukanov commented Nov 9, 2021 •

edited by edgao

Loading

alexandertsukanov commented Nov 9, 2021 •

edited by github-actions bot

Loading

alexandertsukanov commented Nov 9, 2021 •

edited by github-actions bot

Loading

ChristopheDuong left a comment

ChristopheDuong commented Nov 12, 2021 •

edited by github-actions bot

Loading

alexandertsukanov commented Nov 12, 2021

alexandertsukanov commented Nov 15, 2021 •

edited by github-actions bot

Loading

alexandertsukanov commented Nov 15, 2021 •

edited by github-actions bot

Loading

alexandertsukanov commented Nov 15, 2021 •

edited by github-actions bot

Loading

alexandertsukanov commented Nov 17, 2021 •

edited by github-actions bot

Loading

alexandertsukanov commented Nov 29, 2021 •

edited by github-actions bot

Loading

alexandertsukanov commented Nov 29, 2021 •

edited by github-actions bot

Loading

alexandertsukanov commented Nov 29, 2021 •

edited by github-actions bot

Loading

[IGNORE] Branch for integration-tests PR 7620 #7786

[IGNORE] Branch for integration-tests PR 7620 #7786

Conversation

alexandertsukanov commented Nov 9, 2021 • edited by edgao Loading

What

How

Recommended reading order

Pre-merge Checklist

Community member or Airbyter

Airbyter

Community member or Airbyter

Airbyter

alexandertsukanov commented Nov 9, 2021 • edited by github-actions bot Loading

alexandertsukanov commented Nov 9, 2021 • edited by github-actions bot Loading

ChristopheDuong left a comment

Choose a reason for hiding this comment

ChristopheDuong commented Nov 12, 2021 • edited by github-actions bot Loading

alexandertsukanov commented Nov 12, 2021

alexandertsukanov commented Nov 15, 2021 • edited by github-actions bot Loading

alexandertsukanov commented Nov 15, 2021 • edited by github-actions bot Loading

alexandertsukanov commented Nov 15, 2021 • edited by github-actions bot Loading

alexandertsukanov commented Nov 17, 2021 • edited by github-actions bot Loading

alexandertsukanov commented Nov 29, 2021 • edited by github-actions bot Loading

alexandertsukanov commented Nov 29, 2021 • edited by github-actions bot Loading

alexandertsukanov commented Nov 29, 2021 • edited by github-actions bot Loading

alexandertsukanov commented Nov 9, 2021 •

edited by edgao

Loading

alexandertsukanov commented Nov 9, 2021 •

edited by github-actions bot

Loading

alexandertsukanov commented Nov 9, 2021 •

edited by github-actions bot

Loading

ChristopheDuong commented Nov 12, 2021 •

edited by github-actions bot

Loading

alexandertsukanov commented Nov 15, 2021 •

edited by github-actions bot

Loading

alexandertsukanov commented Nov 15, 2021 •

edited by github-actions bot

Loading

alexandertsukanov commented Nov 15, 2021 •

edited by github-actions bot

Loading

alexandertsukanov commented Nov 17, 2021 •

edited by github-actions bot

Loading

alexandertsukanov commented Nov 29, 2021 •

edited by github-actions bot

Loading

alexandertsukanov commented Nov 29, 2021 •

edited by github-actions bot

Loading

alexandertsukanov commented Nov 29, 2021 •

edited by github-actions bot

Loading