🐛 Source Zendesk Support: fix missing ticket_id in ticket_comments stream

[asyarif93]

What

close #7631

How

Ticket ID not included in Ticket Comments response, manually add ticket_id to ticket_comments dict using side effects.

Recommended reading order

1. streams.py

Pre-merge Checklist

Community member or Airbyter

• Grant edit access to maintainers (instructions)
• Secrets in the connector's spec are annotated with airbyte_secret
• Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
• Code reviews completed
• Documentation updated
  • Connector's README.md
  • Connector's bootstrap.md. See description and examples
  • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
• PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

• Create a non-forked branch based on this PR and test the below items on it
• Build is successful
• Credentials added to Github CI. Instructions.
• /test connector=connectors/<name> command is passing.
• New Connector version released on Dockerhub by running the /publish command described here
• After the new connector version is published, connector version bumped in the seed directory as described here
• Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

[asyarif93]

unit test results

python -m pytest -s unit_tests
Test session starts (platform: linux, Python 3.8.10, pytest 6.2.5, pytest-sugar 0.9.4)
cachedir: .pytest_cache
rootdir: /home/lpt393/projects/airbyte, configfile: pytest.ini
plugins: timeout-1.4.2, requests-mock-1.9.3, sugar-0.9.4
collecting ... 
 airbyte-integrations/connectors/source-zendesk-support/unit_tests/unit_test.py::test_backoff_cases[Retry-After-123-123] ✓12% █▍        
 airbyte-integrations/connectors/source-zendesk-support/unit_tests/unit_test.py::test_backoff_cases[Retry-After--123-None] ✓25% ██▌       
 airbyte-integrations/connectors/source-zendesk-support/unit_tests/unit_test.py::test_backoff_cases[X-Rate-Limit-100-1.2] ✓38% ███▊      
 airbyte-integrations/connectors/source-zendesk-support/unit_tests/unit_test.py::test_backoff_cases[X-Rate-Limit--100-None] ✓50% █████     
 airbyte-integrations/connectors/source-zendesk-support/unit_tests/unit_test.py::test_backoff_cases[Fake-Header--100-None] ✓62% ██████▍   
 airbyte-integrations/connectors/source-zendesk-support/unit_tests/unit_test.py::test_comments_not_found_ticket[200-1-None] ✓75% ███████▌  {"type": "LOG", "log": {"level": "INFO", "message": "ticket 12345 not found (404 error). It could have been deleted."}}
airbyte-integrations/connectors/source-zendesk-support/unit_tests/unit_test.py::test_comments_not_found_ticket[404-0-None] ✓88% ████████▊

airbyte-integrations/connectors/source-zendesk-support/unit_tests/unit_test.py::test_comments_not_found_ticket[403-0-HTTPError] ✓100% ██████████

==================================================== warnings summary =====================================================

airbyte-integrations/connectors/source-zendesk-support/unit_tests/unit_test.py::test_backoff_cases[Retry-After-123-123]

airbyte-integrations/connectors/source-zendesk-support/unit_tests/unit_test.py::test_backoff_cases[Retry-After--123-None]

airbyte-integrations/connectors/source-zendesk-support/unit_tests/unit_test.py::test_backoff_cases[X-Rate-Limit-100-1.2]

airbyte-integrations/connectors/source-zendesk-support/unit_tests/unit_test.py::test_backoff_cases[X-Rate-Limit--100-None]

airbyte-integrations/connectors/source-zendesk-support/unit_tests/unit_test.py::test_backoff_cases[Fake-Header--100-None]

airbyte-integrations/connectors/source-zendesk-support/unit_tests/unit_test.py::test_comments_not_found_ticket[200-1-None]

airbyte-integrations/connectors/source-zendesk-support/unit_tests/unit_test.py::test_comments_not_found_ticket[404-0-None]

airbyte-integrations/connectors/source-zendesk-support/unit_tests/unit_test.py::test_comments_not_found_ticket[403-0-HTTPError]

/home/lpt393/projects/airbyte/airbyte-integrations/connectors/source-zendesk-support/.venv/lib/python3.8/site-packages/airbyte_cdk/sources/streams/http/http.py:37: DeprecationWarning: Call to deprecated class NoAuth. (Set authenticator=None instead) -- Deprecated since version 0.1.20.

self._authenticator = NoAuth()
airbyte-integrations/connectors/source-zendesk-support/unit_tests/unit_test.py::test_backoff_cases[Retry-After-123-123]

airbyte-integrations/connectors/source-zendesk-support/unit_tests/unit_test.py::test_backoff_cases[Retry-After--123-None]

airbyte-integrations/connectors/source-zendesk-support/unit_tests/unit_test.py::test_backoff_cases[X-Rate-Limit-100-1.2]

airbyte-integrations/connectors/source-zendesk-support/unit_tests/unit_test.py::test_backoff_cases[X-Rate-Limit--100-None]

airbyte-integrations/connectors/source-zendesk-support/unit_tests/unit_test.py::test_backoff_cases[Fake-Header--100-None]

airbyte-integrations/connectors/source-zendesk-support/unit_tests/unit_test.py::test_comments_not_found_ticket[200-1-None]

airbyte-integrations/connectors/source-zendesk-support/unit_tests/unit_test.py::test_comments_not_found_ticket[404-0-None]

airbyte-integrations/connectors/source-zendesk-support/unit_tests/unit_test.py::test_comments_not_found_ticket[403-0-HTTPError]

/home/lpt393/projects/airbyte/airbyte-integrations/connectors/source-zendesk-support/.venv/lib/python3.8/site-packages/deprecated/classic.py:173: DeprecationWarning: Call to deprecated class HttpAuthenticator. (Use requests.auth.AuthBase instead) -- Deprecated since version 0.1.20.

return old_new1(cls, *args, **kwargs)
-- Docs: https://docs.pytest.org/en/stable/warnings.html
Results (0.18s):

8 passed

[sherifnada]

thanks @asyarif93 ! we'll review shortly

[marcosmarxm]

Tested and published in #7980