Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🎉 Source Greenhouse: Implement demographics streams support #7607

Merged
merged 3 commits into from
Nov 8, 2021
Merged

🎉 Source Greenhouse: Implement demographics streams support #7607

merged 3 commits into from
Nov 8, 2021

Conversation

htrueman
Copy link
Contributor

@htrueman htrueman commented Nov 3, 2021 •
edited
Loading

What

Closes #6546

How

  • Implemented demographics streams.
  • Updated SAT to test new streams.

Recommended reading order

  1. streams.py
  2. acceptance-test-config.yml
  3. source.py
  4. schemas

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

  • Community member? Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • docs/SUMMARY.md
    • docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
    • docs/integrations/README.md
    • airbyte-integrations/builds.md
  • PR name follows PR naming conventions
  • Connector added to connector index like described here

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions
  • Connector version bumped like described here

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here

Connector Generator

  • Issue acceptance criteria met
  • PR name follows PR naming conventions
  • If adding a new generator, add it to the list of scaffold modules being tested
  • The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
  • Documentation which references the generator is updated as needed.

@htrueman
Add demographics streams support.
caf92a3 
Update SAT to dest demographics streams.
@CLAassistant
Copy link

CLAassistant commented Nov 3, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@htrueman htrueman self-assigned this Nov 3, 2021
@github-actions github-actions bot added the area/connectors Connector related issues label Nov 3, 2021
@htrueman
Copy link
Contributor Author

htrueman commented Nov 3, 2021 •
edited by github-actions bot
Loading

/test connector=connectors/source-greenhouse

🕑 connectors/source-greenhouse https://github.com/airbytehq/airbyte/actions/runs/1418638200
✅ connectors/source-greenhouse https://github.com/airbytehq/airbyte/actions/runs/1418638200
Python tests coverage:

	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                            Stmts   Miss  Cover
	 ---------------------------------------------------
	 source_greenhouse/__init__.py       2      0   100%
	 source_greenhouse/source.py        20     10    50%
	 source_greenhouse/streams.py       86     12    86%
	 ---------------------------------------------------
	 TOTAL                             108     22    80%
	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                                 Stmts   Miss  Cover
	 ------------------------------------------------------------------------
	 source_acceptance_test/__init__.py                       2      0   100%
	 source_acceptance_test/base.py                          10      4    60%
	 source_acceptance_test/config.py                        75      8    89%
	 source_acceptance_test/conftest.py                     108    108     0%
	 source_acceptance_test/plugin.py                        47     47     0%
	 source_acceptance_test/tests/__init__.py                 4      0   100%
	 source_acceptance_test/tests/test_core.py              200     94    53%
	 source_acceptance_test/tests/test_full_refresh.py       33     22    33%
	 source_acceptance_test/tests/test_incremental.py        69     38    45%
	 source_acceptance_test/utils/__init__.py                 6      0   100%
	 source_acceptance_test/utils/asserts.py                 37      2    95%
	 source_acceptance_test/utils/common.py                  41     24    41%
	 source_acceptance_test/utils/compare.py                 62     25    60%
	 source_acceptance_test/utils/connector_runner.py        82     49    40%
	 source_acceptance_test/utils/json_schema_helper.py     115     14    88%
	 ------------------------------------------------------------------------
	 TOTAL                                                  891    435    51%

@jrhizor jrhizor temporarily deployed to more-secrets November 3, 2021 20:49 Inactive
Zirochkaa
Zirochkaa approved these changes Nov 4, 2021
View reviewed changes
Copy link
Contributor

@Zirochkaa Zirochkaa left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like applications.demographics_answers and applications.interviews streams (or at least applications.interviews stream) already contained data. Could you please update ticket description?

Also could you please update PR's name like described here since you added new streams?

@htrueman htrueman requested a review from sherifnada November 4, 2021 13:48
sherifnada
sherifnada approved these changes Nov 4, 2021
View reviewed changes
Copy link
Contributor

@sherifnada sherifnada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but please don't forget the checklist

@github-actions github-actions bot added the area/documentation Improvements or additions to documentation label Nov 8, 2021
@htrueman htrueman changed the title Source Greenhouse: Implement demographics streams support 🎉 Source Greenhouse: Implement demographics streams support Nov 8, 2021
@htrueman htrueman temporarily deployed to more-secrets November 8, 2021 08:19 Inactive
@htrueman htrueman temporarily deployed to more-secrets November 8, 2021 08:22 Inactive
@htrueman
Copy link
Contributor Author

htrueman commented Nov 8, 2021 •
edited by github-actions bot
Loading

/publish connector=connectors/source-greenhouse

🕑 connectors/source-greenhouse https://github.com/airbytehq/airbyte/actions/runs/1433854950
✅ connectors/source-greenhouse https://github.com/airbytehq/airbyte/actions/runs/1433854950

@jrhizor jrhizor temporarily deployed to more-secrets November 8, 2021 08:24 Inactive
@htrueman htrueman merged commit f0c54a7 into master Nov 8, 2021
@htrueman htrueman deleted the htrueman/source-greenhouse-fill-all-streams-with-data branch November 8, 2021 08:32
Zirochkaa
Zirochkaa reviewed Nov 8, 2021
View reviewed changes
docs/integrations/sources/greenhouse.md Outdated
@@ -57,5 +57,6 @@ Please follow the [Greenhouse documentation for generating an API key](https://d

| Version | Date | Pull Request | Subject |
| :--- | :--- | :--- | :--- |
| 0.2.6 | 2021-09-22 | [7607](https://github.com/airbytehq/airbyte/pull/7607) | Implement demographics streams support. Update SAT for demographics streams |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrong date :(

@jrhizor jrhizor mentioned this pull request Nov 8, 2021
Merged
schlattk pushed a commit to schlattk/airbyte that referenced this pull request Jan 4, 2022
@htrueman @schlattk
🎉 Source Greenhouse: Implement demographics streams support (airbyteh…
3642849 
…q#7607)

* Add demographics streams support.
Update SAT to dest demographics streams.

* Bump docker version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zirochkaa Zirochkaa Zirochkaa approved these changes

@sherifnada sherifnada sherifnada approved these changes

@avida avida Awaiting requested review from avida

@yevhenii-ldv yevhenii-ldv Awaiting requested review from yevhenii-ldv

Assignees

@htrueman htrueman

Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🎉 Source Greenhouse: Fill all implemented streams with data
5 participants
@htrueman @CLAassistant @sherifnada @Zirochkaa @jrhizor