Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zoura oAuth support #7384

Closed
wants to merge 1 commit into from
Closed

Zoura oAuth support #7384

wants to merge 1 commit into from

Conversation

avida
Copy link
Contributor

@avida avida commented Oct 26, 2021

Resolves #7112

Zuora supports only oAuth client_credentials grant type. That means we have nothing to do on backend, only inject client_id/client_secret parameters wnen doing check_connection/read operations.

But still there is Authorization button on UI that doing nothing, I can see couple of solutions on this:

@github-actions github-actions bot added area/connectors Connector related issues area/frontend area/platform issues related to the platform labels Oct 26, 2021
@avida avida force-pushed the drezchykov/zuora-oauth branch from 1edee44 to 904a416 Compare October 26, 2021 09:40
@avida avida temporarily deployed to more-secrets October 26, 2021 09:42 Inactive
@avida avida force-pushed the drezchykov/zuora-oauth branch from 904a416 to 258f106 Compare October 26, 2021 09:48
@github-actions github-actions bot added the area/documentation Improvements or additions to documentation label Oct 26, 2021
@avida
Copy link
Contributor Author

avida commented Oct 26, 2021

/test connector=connectors/source-zuora

🕑 connectors/source-zuora https://github.com/airbytehq/airbyte/actions/runs/1385061140
✅ connectors/source-zuora https://github.com/airbytehq/airbyte/actions/runs/1385061140
Python tests coverage:

	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                                 Stmts   Miss  Cover
	 ------------------------------------------------------------------------
	 source_acceptance_test/__init__.py                       2      0   100%
	 source_acceptance_test/base.py                          10      4    60%
	 source_acceptance_test/config.py                        74      8    89%
	 source_acceptance_test/conftest.py                     108    108     0%
	 source_acceptance_test/plugin.py                        47     47     0%
	 source_acceptance_test/tests/__init__.py                 4      0   100%
	 source_acceptance_test/tests/test_core.py              200     94    53%
	 source_acceptance_test/tests/test_full_refresh.py       18     11    39%
	 source_acceptance_test/tests/test_incremental.py        69     38    45%
	 source_acceptance_test/utils/__init__.py                 6      0   100%
	 source_acceptance_test/utils/asserts.py                 37      2    95%
	 source_acceptance_test/utils/common.py                  41     24    41%
	 source_acceptance_test/utils/compare.py                 47     20    57%
	 source_acceptance_test/utils/connector_runner.py        82     49    40%
	 source_acceptance_test/utils/json_schema_helper.py     115     14    88%
	 ------------------------------------------------------------------------
	 TOTAL                                                  860    419    51%
	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                     Stmts   Miss  Cover
	 ------------------------------------------------------------
	 source_zuora/__init__.py                     2      0   100%
	 source_zuora/source.py                     208     52    75%
	 source_zuora/zuora_auth.py                  19      0   100%
	 source_zuora/zuora_endpoint.py               4      0   100%
	 source_zuora/zuora_errors.py                30     13    57%
	 source_zuora/zuora_excluded_streams.py       2      0   100%
	 ------------------------------------------------------------
	 TOTAL                                      265     65    75%
	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                     Stmts   Miss  Cover
	 ------------------------------------------------------------
	 source_zuora/__init__.py                     2      2     0%
	 Name                                     Stmts   Miss  Cover/actions-runner/_work/airbyte/airbyte/airbyte-integrations/connectors/source-zuora/.venv/lib/python3.8/site-packages/coverage/control.py:761: CoverageWarning: No data was collected. (no-data-collected)
	 source_zuora/source.py                     208    208     0%
	 source_zuora/zuora_auth.py                  19     19     0%
	 source_zuora/zuora_endpoint.py               4      4     0%
	 source_zuora/zuora_errors.py                30     30     0%
	 source_zuora/zuora_excluded_streams.py       2      2     0%
	 ------------------------------------------------------------
	 TOTAL                                      265    265     0%

@avida avida temporarily deployed to more-secrets October 26, 2021 09:50 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets October 26, 2021 09:51 Inactive
@avida avida force-pushed the drezchykov/zuora-oauth branch from 258f106 to d0324f6 Compare October 26, 2021 09:57
@avida avida force-pushed the drezchykov/zuora-oauth branch from d0324f6 to dc8a9ea Compare October 26, 2021 09:58
@github-actions github-actions bot removed area/frontend area/platform issues related to the platform labels Oct 26, 2021
@avida avida temporarily deployed to more-secrets October 26, 2021 09:59 Inactive
@avida avida closed this Oct 26, 2021
@avida avida deleted the drezchykov/zuora-oauth branch October 26, 2021 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

oAuth backend for zuora source
2 participants