Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use window vars for sentry and correct env name #6802

Merged
merged 4 commits into from
Oct 8, 2021
Merged

use window vars for sentry and correct env name #6802

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c6a5cf6
fall back to window var for sentry initialization
jrhizor Oct 5, 2021
54999a3
correct naming
jrhizor Oct 5, 2021
d1f31a5
add dsn to window type
jrhizor Oct 7, 2021
bc1d4c2
fix naming
jrhizor Oct 7, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion airbyte-webapp/.env
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,5 @@ REACT_APP_SEGMENT_TOKEN=6cxNSmQyGSKcATLdJ2pL6WsawkzEMDAN
REACT_APP_FULL_STORY_ORG=13AXQ4
REACT_APP_PAPERCUPS_ACCOUNT_ID=74560291-451e-4ceb-a802-56706ece528b
REACT_APP_OPEN_REPLAY_PROJECT_ID=6611843272536134
REACT_APP_SENTRY_DNS=
REACT_APP_SENTRY_DSN=
REACT_APP_INTERCOM_APP_ID=nj1oam7s
4 changes: 3 additions & 1 deletion airbyte-webapp/src/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,9 @@ import * as Sentry from "@sentry/react";

// We do not follow default config approach that we follow as we want to init
// sentry asap
Sentry.init({ dsn: process.env.REACT_APP_SENTRY_DNS });
Sentry.init({
dsn: process.env.REACT_APP_SENTRY_DSN || window.REACT_APP_SENTRY_DSN,
});

const CloudApp = lazy(() => import(`packages/cloud/App`));
const App = lazy(() => import(`./App`));
Expand Down