🎉 Source Google Ads: add new stream 'click_view' #6684

yevhenii-ldv · 2021-10-03T18:10:21Z

What

Updated copy of contributor`s PR: #5991.

How

Describe the solution

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
Credentials added to Github CI. Instructions.
/test connector=connectors/<name> command is passing.
New Connector version released on Dockerhub by running the /publish command described here

Updating a connector

Community member or Airbyter

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
Credentials added to Github CI. Instructions.
/test connector=connectors/<name> command is passing.
New Connector version released on Dockerhub by running the /publish command described here

Connector Generator

Issue acceptance criteria met
PR name follows PR naming conventions
If adding a new generator, add it to the list of scaffold modules being tested
The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
Documentation which references the generator is updated as needed.

…ogleAdsClickView

CLAassistant · 2021-10-03T18:10:25Z

All committers have signed the CLA.

yevhenii-ldv · 2021-10-03T18:11:19Z

/test connector=connectors/source-google-ads

🕑 connectors/source-google-ads https://github.com/airbytehq/airbyte/actions/runs/1301047027
✅ connectors/source-google-ads https://github.com/airbytehq/airbyte/actions/runs/1301047027
Python tests coverage:

	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                                 Stmts   Miss  Cover
	 ------------------------------------------------------------------------
	 source_acceptance_test/__init__.py                       2      0   100%
	 source_acceptance_test/base.py                          10      4    60%
	 source_acceptance_test/config.py                        74      8    89%
	 source_acceptance_test/conftest.py                     108    108     0%
	 source_acceptance_test/plugin.py                        47     47     0%
	 source_acceptance_test/tests/__init__.py                 4      0   100%
	 source_acceptance_test/tests/test_core.py              200     94    53%
	 source_acceptance_test/tests/test_full_refresh.py       18     11    39%
	 source_acceptance_test/tests/test_incremental.py        69     38    45%
	 source_acceptance_test/utils/__init__.py                 6      0   100%
	 source_acceptance_test/utils/asserts.py                 37      2    95%
	 source_acceptance_test/utils/common.py                  41     24    41%
	 source_acceptance_test/utils/compare.py                 47     20    57%
	 source_acceptance_test/utils/connector_runner.py        82     49    40%
	 source_acceptance_test/utils/json_schema_helper.py     111     11    90%
	 ------------------------------------------------------------------------
	 TOTAL                                                  856    416    51%
	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                       Stmts   Miss  Cover
	 --------------------------------------------------------------
	 source_google_ads/__init__.py                  2      0   100%
	 source_google_ads/custom_query_stream.py      75     50    33%
	 source_google_ads/google_ads.py               67     10    85%
	 source_google_ads/source.py                   35     15    57%
	 source_google_ads/streams.py                  84      6    93%
	 --------------------------------------------------------------
	 TOTAL                                        263     81    69%
	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                       Stmts   Miss  Cover
	 --------------------------------------------------------------
	 source_google_ads/__init__.py                  2      0   100%
	 source_google_ads/custom_query_stream.py      75      6    92%
	 source_google_ads/google_ads.py               67      7    90%
	 source_google_ads/source.py                   35     22    37%
	 source_google_ads/streams.py                  84     16    81%
	 --------------------------------------------------------------
	 TOTAL                                        263     51    81%

docs/integrations/sources/google-ads.md

airbyte-integrations/connectors/source-google-ads/source_google_ads/google_ads.py

airbyte-integrations/connectors/source-google-ads/source_google_ads/streams.py

airbyte-integrations/connectors/source-google-ads/source_google_ads/google_ads.py

…ogleAdsClickView � Conflicts: � docs/integrations/sources/google-ads.md

yevhenii-ldv · 2021-10-06T13:35:15Z

/test connector=connectors/source-google-ads

🕑 connectors/source-google-ads https://github.com/airbytehq/airbyte/actions/runs/1312109481
✅ connectors/source-google-ads https://github.com/airbytehq/airbyte/actions/runs/1312109481
Python tests coverage:

	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                                 Stmts   Miss  Cover
	 ------------------------------------------------------------------------
	 source_acceptance_test/__init__.py                       2      0   100%
	 source_acceptance_test/base.py                          10      4    60%
	 source_acceptance_test/config.py                        74      8    89%
	 source_acceptance_test/conftest.py                     108    108     0%
	 source_acceptance_test/plugin.py                        47     47     0%
	 source_acceptance_test/tests/__init__.py                 4      0   100%
	 source_acceptance_test/tests/test_core.py              200     94    53%
	 source_acceptance_test/tests/test_full_refresh.py       18     11    39%
	 source_acceptance_test/tests/test_incremental.py        69     38    45%
	 source_acceptance_test/utils/__init__.py                 6      0   100%
	 source_acceptance_test/utils/asserts.py                 37      2    95%
	 source_acceptance_test/utils/common.py                  41     24    41%
	 source_acceptance_test/utils/compare.py                 47     20    57%
	 source_acceptance_test/utils/connector_runner.py        82     49    40%
	 source_acceptance_test/utils/json_schema_helper.py     115     14    88%
	 ------------------------------------------------------------------------
	 TOTAL                                                  860    419    51%
	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                       Stmts   Miss  Cover
	 --------------------------------------------------------------
	 source_google_ads/__init__.py                  2      0   100%
	 source_google_ads/custom_query_stream.py      75     50    33%
	 source_google_ads/google_ads.py               67     10    85%
	 source_google_ads/source.py                   35     15    57%
	 source_google_ads/streams.py                  84      6    93%
	 --------------------------------------------------------------
	 TOTAL                                        263     81    69%
	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                       Stmts   Miss  Cover
	 --------------------------------------------------------------
	 source_google_ads/__init__.py                  2      0   100%
	 source_google_ads/custom_query_stream.py      75      6    92%
	 source_google_ads/google_ads.py               67      7    90%
	 source_google_ads/source.py                   35     22    37%
	 source_google_ads/streams.py                  84     16    81%
	 --------------------------------------------------------------
	 TOTAL                                        263     51    81%

yevhenii-ldv · 2021-10-07T09:26:13Z

/publish connector=connectors/source-google-ads

❌ connectors/source-google-ads https://github.com/airbytehq/airbyte/actions/runs/1315563386

yevhenii-ldv · 2021-10-07T09:32:12Z

/publish connector=connectors/source-google-ads

🕑 connectors/source-google-ads https://github.com/airbytehq/airbyte/actions/runs/1315585417
❌ connectors/source-google-ads https://github.com/airbytehq/airbyte/actions/runs/1315585417

…ogleAdsClickView

yevhenii-ldv · 2021-10-07T11:02:19Z

/publish connector=connectors/source-google-ads

🕑 connectors/source-google-ads https://github.com/airbytehq/airbyte/actions/runs/1315875820
✅ connectors/source-google-ads https://github.com/airbytehq/airbyte/actions/runs/1315875820

* fetch gclid from clickview stream * resolve comments and update google ads document * add document url in stream.py file * fixed date range issue and added campaign name in json schema Co-authored-by: blotouta2 <ankur@blotout.io>

blotouta2 and others added 6 commits September 11, 2021 22:58

fetch gclid from clickview stream

3e2ff39

resolve comments and update google ads document

d8af10e

add document url in stream.py file

dc214aa

fixed date range issue and added campaign name in json schema

872d215

Merge branch 'master' of https://github.com/airbytehq/airbyte into go…

17e42ec

…ogleAdsClickView

update contributor's code

58bfd5f

yevhenii-ldv temporarily deployed to more-secrets October 3, 2021 18:10 Inactive

github-actions bot added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels Oct 3, 2021

yevhenii-ldv changed the title ~~Google ads click view~~ 🎉 Source Google Ads: add new stream 'click_view' Oct 3, 2021

jrhizor temporarily deployed to more-secrets October 3, 2021 18:13 Inactive

yevhenii-ldv requested review from Zirochkaa, avida and htrueman October 3, 2021 19:07

sherifnada reviewed Oct 3, 2021

View reviewed changes

Zirochkaa approved these changes Oct 4, 2021

View reviewed changes

airbyte-integrations/connectors/source-google-ads/source_google_ads/google_ads.py Outdated Show resolved Hide resolved

yevhenii-ldv added 3 commits October 6, 2021 16:28

update after review

887a0a4

Merge branch 'master' of https://github.com/airbytehq/airbyte into go…

d49ed6b

…ogleAdsClickView � Conflicts: � docs/integrations/sources/google-ads.md

update changelogs

411fc26

yevhenii-ldv temporarily deployed to more-secrets October 6, 2021 13:38 Inactive

jrhizor temporarily deployed to more-secrets October 6, 2021 13:41 Inactive

yevhenii-ldv requested a review from sherifnada October 6, 2021 14:09

sherifnada approved these changes Oct 6, 2021

View reviewed changes

bump version

c4af937

yevhenii-ldv temporarily deployed to more-secrets October 7, 2021 09:27 Inactive

jrhizor temporarily deployed to more-secrets October 7, 2021 09:28 Inactive

jrhizor temporarily deployed to more-secrets October 7, 2021 09:34 Inactive

Merge branch 'master' of https://github.com/airbytehq/airbyte into go…

19aa957

…ogleAdsClickView

yevhenii-ldv temporarily deployed to more-secrets October 7, 2021 11:03 Inactive

jrhizor temporarily deployed to more-secrets October 7, 2021 11:04 Inactive

yevhenii-ldv merged commit ab6cc49 into master Oct 7, 2021

yevhenii-ldv deleted the googleAdsClickView branch October 7, 2021 11:18

yevhenii-ldv added this to the Connectors, October 15th 2021 milestone Oct 7, 2021

jrhizor mentioned this pull request Oct 7, 2021

Bump Airbyte version from 0.30.15-alpha to 0.30.16-alpha #6880

Merged

yevhenii-ldv self-assigned this Oct 14, 2021

marcosmarxm mentioned this pull request Oct 19, 2021

fetch gclid from clickview stream #5991

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

🎉 Source Google Ads: add new stream 'click_view' #6684

🎉 Source Google Ads: add new stream 'click_view' #6684

yevhenii-ldv commented Oct 3, 2021

CLAassistant commented Oct 3, 2021 •

edited

Loading

yevhenii-ldv commented Oct 3, 2021 •

edited by github-actions bot

Loading

yevhenii-ldv commented Oct 6, 2021 •

edited by github-actions bot

Loading

yevhenii-ldv commented Oct 7, 2021 •

edited by github-actions bot

Loading

yevhenii-ldv commented Oct 7, 2021 •

edited by github-actions bot

Loading

yevhenii-ldv commented Oct 7, 2021 •

edited by github-actions bot

Loading

🎉 Source Google Ads: add new stream 'click_view' #6684

🎉 Source Google Ads: add new stream 'click_view' #6684

Conversation

yevhenii-ldv commented Oct 3, 2021

What

How

Recommended reading order

Pre-merge Checklist

Community member or Airbyter

Airbyter

Community member or Airbyter

Airbyter

CLAassistant commented Oct 3, 2021 • edited Loading

yevhenii-ldv commented Oct 3, 2021 • edited by github-actions bot Loading

yevhenii-ldv commented Oct 6, 2021 • edited by github-actions bot Loading

yevhenii-ldv commented Oct 7, 2021 • edited by github-actions bot Loading

yevhenii-ldv commented Oct 7, 2021 • edited by github-actions bot Loading

yevhenii-ldv commented Oct 7, 2021 • edited by github-actions bot Loading

CLAassistant commented Oct 3, 2021 •

edited

Loading

yevhenii-ldv commented Oct 3, 2021 •

edited by github-actions bot

Loading

yevhenii-ldv commented Oct 6, 2021 •

edited by github-actions bot

Loading

yevhenii-ldv commented Oct 7, 2021 •

edited by github-actions bot

Loading

yevhenii-ldv commented Oct 7, 2021 •

edited by github-actions bot

Loading

yevhenii-ldv commented Oct 7, 2021 •

edited by github-actions bot

Loading