Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Revert "Redirect to oboarding page"" #6680

Merged

Conversation

jrhizor
Copy link
Contributor

@jrhizor jrhizor commented Oct 3, 2021

Reverts #6644

Wasn't responsible for the frontend problems we were seeing. We definitely want this in.

We'll still need to fix #6635

@jrhizor jrhizor requested review from jamakase and cgardens October 3, 2021 17:11
@jrhizor jrhizor temporarily deployed to more-secrets October 3, 2021 17:12 Inactive
@CLAassistant
Copy link

CLAassistant commented Oct 4, 2021

CLA assistant check
All committers have signed the CLA.

@jamakase jamakase temporarily deployed to more-secrets October 4, 2021 06:36 Inactive
@jamakase jamakase temporarily deployed to more-secrets October 4, 2021 08:04 Inactive
@jamakase jamakase temporarily deployed to more-secrets October 4, 2021 08:23 Inactive
@jamakase jamakase merged commit effceb6 into master Oct 4, 2021
@jamakase jamakase deleted the revert-6644-revert-6251-jamakase/onboarding-redirect branch October 4, 2021 08:43
@jrhizor
Copy link
Contributor Author

jrhizor commented Oct 4, 2021

Thanks Artem!

schlattk pushed a commit to schlattk/airbyte that referenced this pull request Jan 4, 2022
* Revert "Revert "Redirect to oboarding page (airbytehq#6251)" (airbytehq#6644)"

This reverts commit 82d492b.

* Fix e2e tests

Co-authored-by: Artem Astapenko <jamakase54@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix frontend tests failing due to onboarding redirect changes
3 participants