Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source Sendgrid: Update manifest for adapting changes with AsyncRetriever #55185

Merged
merged 12 commits into from
Mar 11, 2025

Conversation

btkcodedev
Copy link
Collaborator

What

Closes https://github.com/airbytehq/airbyte-internal-issues/issues/11787

How

Definition of Done:

The source-sendgrid works with the updated manifest.yaml considering the changes made here
In specific:

upgrade the CDK version to at least 6.36.3

rename the urls_extractor to download_target_extractor, here

move off the stream_slice interpolation context to use the {{creation_response['id']}}, here

move off the stream_slice interpolation context to use the {{download_target}}, here

make sure the CAT passes, as before

make sure the Regression Tests pass, as before

no source behaviour changes are expected

Follow the airbytehq/airbyte-python-cdk#368 (User Impact section) for more information about the changes.

Copy link

vercel bot commented Mar 4, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 10, 2025 6:23pm

@btkcodedev
Copy link
Collaborator Author

btkcodedev commented Mar 4, 2025

/bump-version type="minor" changelog="Update manifest for adapting changes with AsyncRetriever"

Bump Version job started... Check job output.

✅ Changes applied successfully. (b799c36)

@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Mar 4, 2025
@btkcodedev
Copy link
Collaborator Author

This is ready
CC @bazarnov @natikgadzhi @DanyloGL

@bazarnov
Copy link
Collaborator

bazarnov commented Mar 5, 2025

This is ready CC @bazarnov @natikgadzhi @DanyloGL

Hey @btkcodedev we've prepared another small update for CDK > Decoders to be able to re-use them instead of the ResponseToFileExtractor, which support is terminated currently.

So, after this one is merged and released, we would need to update this PR as follows:

  1. Update the version of the CDK to the latest one possible

  2. Replace the:

download_extractor:
  type: ResponseToFileExtractor

With the following:

download_decoder:
  type: GzipDecoder
  decoder:
    type: CsvDecoder

Once the tests are green we should be good to merge it.

@btkcodedev
Copy link
Collaborator Author

Ok Thanks, Will do after airbytehq/airbyte-python-cdk#378 is merged!! 🙇

@bazarnov
Copy link
Collaborator

bazarnov commented Mar 7, 2025

@btkcodedev The CDK update mentioned earlier was merged, please refer to v6.38.2 when updating the CDK version. Thanks!

Copy link
Collaborator

@bazarnov bazarnov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor Change:

  • Replace path with url_base in the download_requester.

After this modification, the code will be LGTM.

Thank you, @btkcodedev

@btkcodedev
Copy link
Collaborator Author

@bazarnov, the bounces stream was fine before the upgrade, its failing now, any idea why?

@btkcodedev
Copy link
Collaborator Author

the stream looks untouched for me though!

@bazarnov
Copy link
Collaborator

The bounces stream has no records apparently:

{"type":"LOG","log":{"level":"INFO","message":"Starting syncing"}}
{"type":"LOG","log":{"level":"INFO","message":"Marking stream bounces as STARTED"}}
{"type":"LOG","log":{"level":"INFO","message":"Syncing stream: bounces "}}
{"type":"TRACE","trace":{"type":"STREAM_STATUS","emitted_at":1741625706627.451,"stream_status":{"stream_descriptor":{"name":"bounces"},"status":"STARTED"}}}
{"type":"LOG","log":{"level":"INFO","message":"Read 0 records from bounces stream"}}
{"type":"LOG","log":{"level":"INFO","message":"Marking stream bounces as STOPPED"}}

Looks like we should update them @DanyloGL Could you please help with this?

Alternatively, we can skip checking this stream in the acceptance-test-config.yaml, here by adding the bounces stream to the list of empty_streams.

@bazarnov
Copy link
Collaborator

@btkcodedev I confirm that with the old CDK 5.13.0 there are no Records for the Bounces stream. Not sure why and what has happened, let's add this stream to the list of the empty_streams for now.

@btkcodedev
Copy link
Collaborator Author

Added! This should work now

@bazarnov
Copy link
Collaborator

Feel free to merge, once the CI is green again.

@btkcodedev btkcodedev merged commit 5de4d25 into master Mar 11, 2025
27 checks passed
@btkcodedev btkcodedev deleted the btkcodedev/sendgridUpdate branch March 11, 2025 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/sendgrid
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants