-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Source Sendgrid: Update manifest for adapting changes with AsyncRetriever #55185
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
/bump-version type="minor" changelog="Update manifest for adapting changes with AsyncRetriever"
|
This is ready |
Hey @btkcodedev we've prepared another small update for CDK > Decoders to be able to re-use them instead of the So, after this one is merged and released, we would need to update this PR as follows:
download_extractor:
type: ResponseToFileExtractor With the following: download_decoder:
type: GzipDecoder
decoder:
type: CsvDecoder Once the tests are green we should be good to merge it. |
Ok Thanks, Will do after airbytehq/airbyte-python-cdk#378 is merged!! 🙇 |
@btkcodedev The CDK update mentioned earlier was merged, please refer to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor Change:
- Replace
path
withurl_base
in thedownload_requester
.
After this modification, the code will be LGTM.
Thank you, @btkcodedev
@bazarnov, the bounces stream was fine before the upgrade, its failing now, any idea why? |
the stream looks untouched for me though! |
The
Looks like we should update them @DanyloGL Could you please help with this? Alternatively, we can skip checking this stream in the |
@btkcodedev I confirm that with the old CDK |
Added! This should work now |
Feel free to merge, once the CI is green again. |
What
Closes https://github.com/airbytehq/airbyte-internal-issues/issues/11787
How
Definition of Done:
The source-sendgrid works with the updated manifest.yaml considering the changes made here
In specific:
upgrade the CDK version to at least 6.36.3
rename the urls_extractor to download_target_extractor, here
move off the stream_slice interpolation context to use the {{creation_response['id']}}, here
move off the stream_slice interpolation context to use the {{download_target}}, here
make sure the CAT passes, as before
make sure the Regression Tests pass, as before
no source behaviour changes are expected
Follow the airbytehq/airbyte-python-cdk#368 (User Impact section) for more information about the changes.