-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Source Square: Change type of object_types in the request body from string to array #53695
base: master
Are you sure you want to change the base?
🐛 Source Square: Change type of object_types in the request body from string to array #53695
Conversation
@y-yoshimura-cipher is attempting to deploy a commit to the Airbyte Growth Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The correct Square API documentation is: https://developer.squareup.com/reference/square/catalog-api/search-catalog-objects
thanks for the fix @y-yoshimura-cipher can you also run test to all these streams?
@marcosmarxm |
@y-yoshimura-cipher can you contact me on Slack? |
@marcosmarxm |
What
Fixes the issue causing the Bad Request error.
Souce-Square: version.1.7.2
The following error occurs in the latest version.
How
This pull request includes several updates to the
airbyte-integrations/connectors/source-square/manifest.yaml
file. The main changes involve formatting adjustments to JSON strings and updates to stream hashes.Formatting adjustments:
object_types
from string to arrayhttps://developer.squareup.com/docs/catalog-api/categorize-catalog-itemshttps://developer.squareup.com/reference/square/catalog-api/search-catalog-objects
Review guide
manifest.yaml
has been changed to object_type in the request body from string to arrayUser Impact
categories, discounts, items, modifier_list, taxes will work ( they are currently broken)
Can this PR be safely reverted and rolled back?