Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Source Square: Change type of object_types in the request body from string to array #53695

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

y-yoshimura-cipher
Copy link

@y-yoshimura-cipher y-yoshimura-cipher commented Feb 14, 2025

What

Fixes the issue causing the Bad Request error.

Souce-Square: version.1.7.2

The following error occurs in the latest version.

image

How

This pull request includes several updates to the airbyte-integrations/connectors/source-square/manifest.yaml file. The main changes involve formatting adjustments to JSON strings and updates to stream hashes.

Formatting adjustments:

  • Changed the type of object_types from string to array

https://developer.squareup.com/docs/catalog-api/categorize-catalog-items

https://developer.squareup.com/reference/square/catalog-api/search-catalog-objects

Review guide

manifest.yaml has been changed to object_type in the request body from string to array

User Impact

categories, discounts, items, modifier_list, taxes will work ( they are currently broken)

Can this PR be safely reverted and rolled back?

  • YES 💚
  • NO ❌

Copy link

vercel bot commented Feb 14, 2025

@y-yoshimura-cipher is attempting to deploy a commit to the Airbyte Growth Team on Vercel.

A member of the Team first needs to authorize it.

@CLAassistant
Copy link

CLAassistant commented Feb 14, 2025

CLA assistant check
All committers have signed the CLA.

@y-yoshimura-cipher y-yoshimura-cipher changed the title 🐛 Source Square: Change object_types type in the request body from string to array 🐛 Source Square: Change type of object_types in the request body from string to array Feb 14, 2025
Copy link
Member

@marcosmarxm marcosmarxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The correct Square API documentation is: https://developer.squareup.com/reference/square/catalog-api/search-catalog-objects

thanks for the fix @y-yoshimura-cipher can you also run test to all these streams?

@y-yoshimura-cipher
Copy link
Author

@marcosmarxm
Thank you for the link! I have been testing on the UI, but I am not sure how to run tests on all these streams outside of it.
If you could provide some instructions, that would be very helpful.

image

@marcosmarxm
Copy link
Member

@y-yoshimura-cipher can you contact me on Slack?

@y-yoshimura-cipher
Copy link
Author

y-yoshimura-cipher commented Feb 25, 2025

@marcosmarxm
I couldn't find your Slack name. You can find me on Slack as @y-yoshimura-cipher.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation community connectors/source/square
Projects
Status: Waiting Contributor
Development

Successfully merging this pull request may close these issues.

4 participants