-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Source Pinterest: Add Account ID parameter and stream filter #53135
base: master
Are you sure you want to change the base?
Conversation
- Implement AdAccountValidationStream for validating ad account IDs - Introduce AdAccountRecordExtractor for better record processing - Improve error handling and implement structured error mapping - Update manifest.yaml to reflect new stream additions - Ensure graceful handling of invalid accounts without breaking execution
- Added new invalid_account_config.json for acceptance tests - Updated acceptance-test-config.yml to include invalid account test
- Added new invalid_account_config.json for acceptance tests - Updated acceptance-test-config.yml to include invalid account test
@karolur is attempting to deploy a commit to the Airbyte Growth Team on Vercel. A member of the Team first needs to authorize it. |
/format-fix
|
Hello 👋, I apologize if your contribution hasn't been reviewed or updated yet. I'm working to address the community contribution backlog. I created this GitHub project to help you understand when to expect a review. This week, my goal is to complete all contributions related to Marketplace and Manifest-only connectors. Next week, I will focus on API Certified Connectors, followed by DB Java Connector contributions. If you have any questions about your contribution, please feel free to send me a direct message in the Airbyte Community Slack (and include the link to your pull request). |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change looks good to me. I'm running integration tests and need to wait until their done and all green. After need final approval from connector team to introduce this feature to Pinterest connector.
What
This PR introduces an Account Id filter for the Pinterest source connector.
Account Id
to fetch data only for that particular account.🔗 Related Discussion: Airbyte Discussion #52036
How
account_id
if provided.AdAccountValidationStream
to validate the providedaccount_id
before proceeding with data retrieval.AdAccountRecordExtractor
to handle both scenarios—fetching data for a single account or all accounts—ensuring correct processing based on user input.Review guide
source_pinterest/source.py
→ UpdatedSourcePinterest
to validateaccount_id
in_validate_and_transform
.source_pinterest/streams.py
→ AddedAdAccountValidationStream
to verify the existence of the specifiedaccount_id
.source_pinterest/components/components.py
→ AddedAdAccountRecordExtractor
to handle data extraction for single vs. multiple accounts.source_pinterest/manifest.yaml
→ Updated connector specification to includeaccount_id
as an optional configuration parameter.source_pinterest/components/error_mapping.py
→ Extended error handling to return meaningful errors for invalidaccount_id
values.User Impact
New Feature: Users can now filter Pinterest ad data by a specific
account_id
, ensuring more precise data retrieval.Compliance-Friendly: Helps organizations align with data access policies by restricting API calls to only authorized accounts.
No Breaking Changes: Users who do not specify an
Account Id
will continue fetching all available data as before.Can this PR be safely reverted and rolled back?