add connectionsHandler #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michel-tricot
approved these changes
Aug 14, 2020
| import java.io.IOException; | ||
| import java.util.UUID; | ||
|
|
||
| public class SourceImplementationHelpers { |
There was a problem hiding this comment.
Is this file going to go away with the mocks?
There was a problem hiding this comment.
the writeConfig part is. still using it the file to generate the struct which gets used in two different test classes.
| return getConnectionInternal(connectionIdRequestBody.getConnectionId()); | ||
| } | ||
|
|
||
| private StandardSync.Status toPersistenceStatus(ConnectionStatus apiStatus) { |
There was a problem hiding this comment.
Why do we have this conversion here?
There was a problem hiding this comment.
because the enums generated separately by open api 3 and json2pojo. so, even though they have the same values, the mapping has to be done explicitly to map back and forth between persistence and API structs. miss duck typing yet? 😉
cgardens
force-pushed
the
cgardens/endpoints5
branch
from
e0ab902 to
fce475b
Compare
cgardens
force-pushed
the
cgardens/endpoints6
branch
from
5466817 to
e176809
Compare
21 tasks
14 tasks
marcosmarxm
pushed a commit
that referenced
this pull request
Jun 24, 2024
Fork Sync: Update from parent repository
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
wrapperObject.isA(). instead it either just doesn't generate a usable object or generates an object with all of the fields. this is worth looking into more carefully, but for now, we just assume schedule is manual if it is nullNote: I need to propagate the change in how to handle unit tests down to this PR. I will use mocks like was suggested in an earlier PR and will integrate that before I merge. I don't think you need to block reviewing on that.