Destination S3V2: Fix: File xfer uses part size for part, not file size #52662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
tryangul
reviewed
Jan 30, 2025
| @@ -44,7 +44,7 @@ class FilePartAccumulator( | |||
|
|
|||
| while (true) { | |||
| val bytePart = | |||
| ByteArray(ObjectStorageUploadConfiguration.DEFAULT_FILE_SIZE_BYTES.toInt()) | |||
| ByteArray(ObjectStorageUploadConfiguration.DEFAULT_PART_SIZE_BYTES.toInt()) | |||
There was a problem hiding this comment.
Should this class be reading from the ObjectStorageUploadConfiguration instead of referencing the constant directly?
johnny-schmidt
force-pushed
the
jschmidt/s3v2/fix-file-transfer-part-size
branch
from
6197254 to
19ef4c3
Compare
johnny-schmidt
force-pushed
the
jschmidt/s3v2/fix-file-transfer-part-size
branch
from
19ef4c3 to
b37d539
Compare
johnny-schmidt
force-pushed
the
jschmidt/s3v2/fix-file-transfer-part-size
branch
from
b37d539 to
bd76580
Compare
octavia-squidington-iii
added
area/connectors
johnny-schmidt
force-pushed
the
jschmidt/s3v2/fix-file-transfer-part-size
branch
from
bd76580 to
9802a01
Compare
johnny-schmidt
force-pushed
the
jschmidt/s3v2/fix-file-transfer-part-size
branch
from
9802a01 to
bef31d1
Compare
tryangul
reviewed
Jan 31, 2025
| @@ -6,7 +6,7 @@ plugins { | |||
| airbyteBulkConnector { | |||
| core = 'load' | |||
| toolkits = ['load-s3', 'load-avro', 'load-aws'] | |||
| cdk = '0.296' | |||
| cdk = 'local' | |||
There was a problem hiding this comment.
Let's repin the cdk after ya?
tryangul
approved these changes
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This probably fixes the oom issue on large files