🎉 New Source: Bing Ads

[yaroslav-dudar]

What

Bing Ads Source connector #2508
Implemented 4 streams: Account, Campaign, AdGroup, Ad

How

Connector implemented with SDK library https://github.com/BingAds/BingAds-Python-SDK

Recommended reading order

1. client.py
2. source.py
3. cache.py

Pre-merge Checklist

Expand the checklist which is relevant for this PR.

Connector checklist

• Issue acceptance criteria met
• PR name follows PR naming conventions
• Secrets are annotated with airbyte_secret in the connector's spec
• Credentials added to Github CI if needed and not already present. instructions for injecting secrets into CI.
• Unit & integration tests added as appropriate (and are passing)
  • Community members: please provide proof of this succeeding locally e.g: screenshot or copy-paste acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
• /test connector=connectors/<name> command as documented here is passing.
  • Community members can skip this, Airbyters will run this for you.
• Code reviews completed
• Documentation updated
  • README.md
  • docs/SUMMARY.md if it's a new connector
  • Created or updated reference docs in docs/integrations/<source or destination>/<name>.
  • Changelog in the appropriate page in docs/integrations/.... See changelog example
  • docs/integrations/README.md contains a reference to the new connector
  • Build status added to build page
• Build is successful
• Connector version bumped like described here
• New Connector version released on Dockerhub by running the /publish command described here
• No major blockers
• PR merged into master branch
• Follow up tickets have been created
• Associated tickets have been closed & stakeholders notified

Connector Generator checklist

• Issue acceptance criteria met
• PR name follows PR naming conventions
• If adding a new generator, add it to the list of scaffold modules being tested
• The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
• Documentation which references the generator is updated as needed.

[yaroslav-dudar]

/test connector=connectors/source-bing-ads

🕑 connectors/source-bing-ads https://github.com/airbytehq/airbyte/actions/runs/1056489683
❌ connectors/source-bing-ads https://github.com/airbytehq/airbyte/actions/runs/1056489683

[yaroslav-dudar]

/test connector=connectors/source-bing-ads

🕑 connectors/source-bing-ads https://github.com/airbytehq/airbyte/actions/runs/1056550331
✅ connectors/source-bing-ads https://github.com/airbytehq/airbyte/actions/runs/1056550331

[Phlair]

Really like the use of caching here and nice unit tests.

It would be nice to document the caching strategy somewhere (maybe in README or a docstring). Once I'd read through all the classes it completely makes sense but it could be described somewhere central so reading all the code isn't necessary to gain that understanding. E.g. We need to cache Accounts to reuse in Campaigns, and cache Campaigns to reuse in AdGroups and so on and so on.

Is it the case that BingAds can only ever be full refresh or did we choose not to implement incremental for simplicity?

Other minor review points in comments.

[Phlair]

imo this is close enough to being merged that this issue can come after as a separate PR.

[yaroslav-dudar]

/test connector=connectors/source-bing-ads

🕑 connectors/source-bing-ads https://github.com/airbytehq/airbyte/actions/runs/1124872380
✅ connectors/source-bing-ads https://github.com/airbytehq/airbyte/actions/runs/1124872380

[Phlair]

Thanks for the changes, lgtm!

One note for the future, in case of ever implementing incremental we'd need to ensure that data doesn't get missed due to the caching strategy but for full refresh as is it's no problem

[yaroslav-dudar]

/publish connector=connectors/source-bing-ads

🕑 connectors/source-bing-ads https://github.com/airbytehq/airbyte/actions/runs/1127993044
✅ connectors/source-bing-ads https://github.com/airbytehq/airbyte/actions/runs/1127993044