Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 4836: Stripe connector: Fix incorect data field type #4878

Merged
merged 2 commits into from
Jul 26, 2021
Merged

🐛 4836: Stripe connector: Fix incorect data field type #4878

merged 2 commits into from
Jul 26, 2021

Conversation

avida
Copy link
Contributor

@avida avida commented Jul 21, 2021 •
edited
Loading

What

This change solves issue #4836

Recommended reading order

  1. x.java
  2. y.python

Pre-merge Checklist

Expand the checklist which is relevant for this PR.

Connector checklist

  • Issue acceptance criteria met
  • PR name follows PR naming conventions
  • Secrets are annotated with airbyte_secret in the connector's spec
  • Credentials added to Github CI if needed and not already present. instructions for injecting secrets into CI.
  • Unit & integration tests added as appropriate (and are passing)
    • Community members: please provide proof of this succeeding locally e.g: screenshot or copy-paste acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • /test connector=connectors/<name> command as documented here is passing.
    • Community members can skip this, Airbyters will run this for you.
  • Code reviews completed
  • Documentation updated
    • README.md
    • docs/SUMMARY.md if it's a new connector
    • Created or updated reference docs in docs/integrations/<source or destination>/<name>.
    • Changelog in the appropriate page in docs/integrations/.... See changelog example
    • docs/integrations/README.md contains a reference to the new connector
    • Build status added to build page
  • Build is successful
  • Connector version bumped like described here
  • New Connector version released on Dockerhub by running the /publish command described here
  • No major blockers
  • PR merged into master branch
  • Follow up tickets have been created
  • Associated tickets have been closed & stakeholders notified

Connector Generator checklist

  • Issue acceptance criteria met
  • PR name follows PR naming conventions
  • If adding a new generator, add it to the list of scaffold modules being tested
  • The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
  • Documentation which references the generator is updated as needed.

@github-actions github-actions bot added the area/connectors Connector related issues label Jul 21, 2021
@avida avida marked this pull request as ready for review July 21, 2021 08:07
@keu
Copy link
Contributor

keu commented Jul 21, 2021 •
edited by github-actions bot
Loading

/test connector=source-stripe

🕑 source-stripe https://github.com/airbytehq/airbyte/actions/runs/1051779113
❌ source-stripe https://github.com/airbytehq/airbyte/actions/runs/1051779113

@keu
Copy link
Contributor

keu commented Jul 21, 2021

LGTM, you will also need to update changelog (either in the connectors root folder in CHANGELOG.md or in docs/.../stripe.md if the former doesn't exist)

@avida avida force-pushed the drezchykov/4836-stripe-source-norm-error branch from 702bd10 to 2512974 Compare July 21, 2021 08:19
@github-actions github-actions bot added the area/documentation Improvements or additions to documentation label Jul 21, 2021
@avida avida force-pushed the drezchykov/4836-stripe-source-norm-error branch from 2512974 to 3b1ca8e Compare July 21, 2021 08:25
@Zirochkaa Zirochkaa linked an issue Jul 21, 2021 that may be closed by this pull request
Stripe Source Normalization Error #4836
Closed
@avida
Copy link
Contributor Author

avida commented Jul 21, 2021

LGTM, you will also need to update changelog (either in the connectors root folder in CHANGELOG.md or in docs/.../stripe.md if the former doesn't exist)
Done

@avida avida closed this Jul 21, 2021
@avida avida reopened this Jul 21, 2021
@Zirochkaa
Copy link
Contributor

Zirochkaa commented Jul 21, 2021 •
edited by github-actions bot
Loading

/test connector=source-stripe

🕑 source-stripe https://github.com/airbytehq/airbyte/actions/runs/1051823524
❌ source-stripe https://github.com/airbytehq/airbyte/actions/runs/1051823524

Zirochkaa
Zirochkaa approved these changes Jul 21, 2021
View reviewed changes
Copy link
Contributor

@Zirochkaa Zirochkaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@avida avida force-pushed the drezchykov/4836-stripe-source-norm-error branch from 3b1ca8e to 13bc8fe Compare July 21, 2021 08:36
@avida
Copy link
Contributor Author

avida commented Jul 21, 2021 •
edited by github-actions bot
Loading

/test connector=source-stripe

🕑 source-stripe https://github.com/airbytehq/airbyte/actions/runs/1051855583
❌ source-stripe https://github.com/airbytehq/airbyte/actions/runs/1051855583

@avida avida force-pushed the drezchykov/4836-stripe-source-norm-error branch from 13bc8fe to 01b90f6 Compare July 21, 2021 09:57
@avida
Copy link
Contributor Author

avida commented Jul 21, 2021 •
edited by github-actions bot
Loading

/test connector=source-stripe

🕑 source-stripe https://github.com/airbytehq/airbyte/actions/runs/1052085581
❌ source-stripe https://github.com/airbytehq/airbyte/actions/runs/1052085581

@avida
Copy link
Contributor Author

avida commented Jul 21, 2021 •
edited by github-actions bot
Loading

/test connector=source-stripe

🕑 source-stripe https://github.com/airbytehq/airbyte/actions/runs/1052117091
❌ source-stripe https://github.com/airbytehq/airbyte/actions/runs/1052117091

@avida avida force-pushed the drezchykov/4836-stripe-source-norm-error branch from 741b646 to 1452c11 Compare July 21, 2021 10:43
@avida
Copy link
Contributor Author

avida commented Jul 21, 2021 •
edited by github-actions bot
Loading

/test connector=source-stripe

🕑 source-stripe https://github.com/airbytehq/airbyte/actions/runs/1052214387
❌ source-stripe https://github.com/airbytehq/airbyte/actions/runs/1052214387

@avida avida force-pushed the drezchykov/4836-stripe-source-norm-error branch from 1452c11 to 1399558 Compare July 21, 2021 12:24
@avida
Copy link
Contributor Author

avida commented Jul 21, 2021 •
edited by github-actions bot
Loading

/test connector=source-stripe

🕑 source-stripe https://github.com/airbytehq/airbyte/actions/runs/1052490138
✅ source-stripe https://github.com/airbytehq/airbyte/actions/runs/1052490138

@keu keu changed the title 4836: Stripe connector: Fix incorect data field type 🐛 4836: Stripe connector: Fix incorect data field type Jul 21, 2021
@avida
Copy link
Contributor Author

avida commented Jul 21, 2021 •
edited by github-actions bot
Loading

/test connector=source-stripe

🕑 source-stripe https://github.com/airbytehq/airbyte/actions/runs/1052663800
✅ source-stripe https://github.com/airbytehq/airbyte/actions/runs/1052663800

@avida avida requested review from sherifnada and davinchia July 22, 2021 06:53
@avida
Copy link
Contributor Author

avida commented Jul 22, 2021 •
edited by github-actions bot
Loading

/publish connector=connectors/source-stripe

🕑 connectors/source-stripe https://github.com/airbytehq/airbyte/actions/runs/1055326775
❌ connectors/source-stripe https://github.com/airbytehq/airbyte/actions/runs/1055326775

@avida avida force-pushed the drezchykov/4836-stripe-source-norm-error branch from f0bb1fb to cf1681e Compare July 22, 2021 13:17
@avida avida requested review from keu and Zirochkaa July 22, 2021 13:17
@avida
Copy link
Contributor Author

avida commented Jul 22, 2021 •
edited by github-actions bot
Loading

/test connector=source-stripe

🕑 source-stripe https://github.com/airbytehq/airbyte/actions/runs/1056262035
❌ source-stripe https://github.com/airbytehq/airbyte/actions/runs/1056262035

@avida
Copy link
Contributor Author

avida commented Jul 22, 2021

Looks like stripe API output changes since yesterday, that added "payment_settings" field to subscriptions object, Ive updated acceptance tests data according to new API output

@avida
Copy link
Contributor Author

avida commented Jul 22, 2021 •
edited by github-actions bot
Loading

/test connector=source-stripe

🕑 source-stripe https://github.com/airbytehq/airbyte/actions/runs/1056290084
✅ source-stripe https://github.com/airbytehq/airbyte/actions/runs/1056290084

@avida avida force-pushed the drezchykov/4836-stripe-source-norm-error branch from 71096d8 to dbe55b2 Compare July 22, 2021 14:38
@avida
Copy link
Contributor Author

avida commented Jul 22, 2021 •
edited by github-actions bot
Loading

/test connector=source-stripe

🕑 source-stripe https://github.com/airbytehq/airbyte/actions/runs/1056526963
❌ source-stripe https://github.com/airbytehq/airbyte/actions/runs/1056526963

@avida avida force-pushed the drezchykov/4836-stripe-source-norm-error branch from dbe55b2 to f6fa915 Compare July 22, 2021 14:46
@avida
Copy link
Contributor Author

avida commented Jul 22, 2021 •
edited by github-actions bot
Loading

/test connector=source-stripe

🕑 source-stripe https://github.com/airbytehq/airbyte/actions/runs/1056557951
✅ source-stripe https://github.com/airbytehq/airbyte/actions/runs/1056557951

Phlair
Phlair approved these changes Jul 23, 2021
View reviewed changes
Copy link
Contributor

@Phlair Phlair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Zirochkaa
Zirochkaa approved these changes Jul 23, 2021
View reviewed changes
Copy link
Contributor

@Zirochkaa Zirochkaa left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, but need to resolve a conflict in airbyte-integrations/bases/source-acceptance-test/source_acceptance_test/tests/test_core.py file.

@avida avida force-pushed the drezchykov/4836-stripe-source-norm-error branch from 990793f to b046c18 Compare July 26, 2021 13:17
@avida
Copy link
Contributor Author

avida commented Jul 26, 2021 •
edited by github-actions bot
Loading

/publish connector=connectors/source-stripe

🕑 connectors/source-stripe https://github.com/airbytehq/airbyte/actions/runs/1067575646
❌ connectors/source-stripe https://github.com/airbytehq/airbyte/actions/runs/1067575646

@avida avida force-pushed the drezchykov/4836-stripe-source-norm-error branch 2 times, most recently from c6de95f to e2955ae Compare July 26, 2021 13:37
@avida
Copy link
Contributor Author

avida commented Jul 26, 2021 •
edited by github-actions bot
Loading

/publish connector=connectors/source-stripe

🕑 connectors/source-stripe https://github.com/airbytehq/airbyte/actions/runs/1067592865
❌ connectors/source-stripe https://github.com/airbytehq/airbyte/actions/runs/1067592865

@avida avida force-pushed the drezchykov/4836-stripe-source-norm-error branch from e2955ae to 3cfb6d4 Compare July 26, 2021 13:44
@avida
Copy link
Contributor Author

avida commented Jul 26, 2021 •
edited by github-actions bot
Loading

/publish connector=connectors/source-stripe

🕑 connectors/source-stripe https://github.com/airbytehq/airbyte/actions/runs/1067613740
❌ connectors/source-stripe https://github.com/airbytehq/airbyte/actions/runs/1067613740

@avida avida force-pushed the drezchykov/4836-stripe-source-norm-error branch from 3cfb6d4 to 230b0b6 Compare July 26, 2021 13:57
@avida
Copy link
Contributor Author

avida commented Jul 26, 2021 •
edited by github-actions bot
Loading

/publish connector=connectors/source-stripe

🕑 connectors/source-stripe https://github.com/airbytehq/airbyte/actions/runs/1067653462
❌ connectors/source-stripe https://github.com/airbytehq/airbyte/actions/runs/1067653462

@avida avida force-pushed the drezchykov/4836-stripe-source-norm-error branch from 230b0b6 to 27cd5b3 Compare July 26, 2021 14:26
@avida
Copy link
Contributor Author

avida commented Jul 26, 2021 •
edited by github-actions bot
Loading

/publish connector=connectors/source-stripe

🕑 connectors/source-stripe https://github.com/airbytehq/airbyte/actions/runs/1067754934
✅ connectors/source-stripe https://github.com/airbytehq/airbyte/actions/runs/1067754934

@avida avida merged commit 718bd75 into master Jul 26, 2021
@avida avida deleted the drezchykov/4836-stripe-source-norm-error branch July 26, 2021 14:44
@tuliren tuliren mentioned this pull request Jul 26, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sherifnada sherifnada sherifnada approved these changes

@tuliren tuliren tuliren approved these changes

@htrueman htrueman htrueman approved these changes

@Zirochkaa Zirochkaa Zirochkaa approved these changes

@Phlair Phlair Phlair approved these changes

@yevhenii-ldv yevhenii-ldv Awaiting requested review from yevhenii-ldv

@davinchia davinchia Awaiting requested review from davinchia

@keu keu Awaiting requested review from keu

Assignees
No one assigned
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Stripe Source Normalization Error
7 participants
@avida @keu @Zirochkaa @tuliren @sherifnada @htrueman @Phlair