Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add entrypoint and bump version for remaining connectors. #4539

Merged
merged 55 commits into from
Jul 7, 2021
Merged

Add entrypoint and bump version for remaining connectors. #4539

merged 55 commits into from
Jul 7, 2021

Conversation

marcosmarxm
Copy link
Member

@marcosmarxm marcosmarxm commented Jul 4, 2021 •
edited by davinchia
Loading

What

As the title.

Able to publish:

  • connectors/source-appstore-singer/Dockerfile
  • connectors/source-salesforce-singer/Dockerfile (without tests, since we hit quota limit)
  • connectors/source-braintree-singer/Dockerfile
  • connectors/source-posthog/Dockerfile (source acceptance test failing last 10 run CI failed) (published without tests since they are failing)
  • connectors/source-chargebee/Dockerfile
  • connectors/source-google-ads/Dockerfile
  • connectors/source-aws-cloudtrail/Dockerfile

With CISO:

  • connectors/source-appsflyer-singer/Dockerfile (without tests, since integration tests are not set up)
  • connectors/source-gitlab-singer/Dockerfile
  • connectors/source-google-search-console-singer/Dockerfile
  • connectors/source-marketo-singer/Dockerfile
  • connectors/source-mixpanel-singer/Dockerfile
  • connectors/source-quickbooks-singer/Dockerfile (without tests, since they are failing)
  • connectors/source-zoom-singer/Dockerfile

Deprecated (Folders should be deleted.)

  • connectors/source-exchangeratesapi-singer/Dockerfile (deprecated)
  • connectors/source-google-adwords-singer/Dockerfile (deprecated)
  • connectors/source-shopify-singer/Dockerfile
  • connectors/source-slack-singer/Dockerfile

Update Readme:

  • connectors/source-appstore-singer/Dockerfile
  • connectors/source-aws-cloudtrail/Dockerfile )
  • connectors/source-braintree-singer/Dockerfile
  • connectors/source-google-ads/Dockerfile
  • connectors/source-gitlab-singer/Dockerfile
  • connectors/source-google-search-console-singer/Dockerfile
  • connectors/source-marketo-singer/Dockerfile
  • connectors/source-mixpanel-singer/Dockerfile
  • connectors/source-posthog/Dockerfile (source acceptance test failing last 10 run CI failed) (published without tests since they are failing)
  • connectors/source-quickbooks-singer/Dockerfile (without tests, since they are failing)
  • connectors/source-salesforce-singer/Dockerfile (without tests, since we hit quota limit)
  • connectors/source-zoom-singer/Dockerfile

How

Describe the solution

Recommended reading order

  1. x.java
  2. y.python

Pre-merge Checklist

Expand the checklist which is relevant for this PR.

Connector checklist

  • Issue acceptance criteria met
  • PR name follows PR naming conventions
  • Secrets are annotated with airbyte_secret in the connector's spec
  • Credentials added to Github CI if needed and not already present. instructions for injecting secrets into CI.
  • Unit & integration tests added as appropriate (and are passing)
    • Community members: please provide proof of this succeeding locally e.g: screenshot or copy-paste acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • /test connector=connectors/<name> command as documented here is passing.
    • Community members can skip this, Airbyters will run this for you.
  • Code reviews completed
  • Documentation updated
    • README.md
    • docs/SUMMARY.md if it's a new connector
    • Created or updated reference docs in docs/integrations/<source or destination>/<name>.
    • Changelog in the appropriate page in docs/integrations/.... See changelog example
    • docs/integrations/README.md contains a reference to the new connector
    • Build status added to build page
  • Build is successful
  • Connector version bumped like described here
  • New Connector version released on Dockerhub by running the /publish command described here
  • No major blockers
  • PR merged into master branch
  • Follow up tickets have been created
  • Associated tickets have been closed & stakeholders notified

Connector Generator checklist

  • Issue acceptance criteria met
  • PR name follows PR naming conventions
  • If adding a new generator, add it to the list of scaffold modules being tested
  • The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
  • Documentation which references the generator is updated as needed.

@github-actions github-actions bot added the area/connectors Connector related issues label Jul 4, 2021
@marcosmarxm
Copy link
Member Author

marcosmarxm commented Jul 5, 2021 •
edited by github-actions bot
Loading

/publish connector=connectors/source-gitlab-singer

🕑 connectors/source-gitlab-singer https://github.com/airbytehq/airbyte/actions/runs/999391780
❌ connectors/source-gitlab-singer https://github.com/airbytehq/airbyte/actions/runs/999391780
🕑 connectors/source-gitlab-singer https://github.com/airbytehq/airbyte/actions/runs/999391780
❌ connectors/source-gitlab-singer https://github.com/airbytehq/airbyte/actions/runs/999391780

@davinchia
Copy link
Contributor

davinchia commented Jul 5, 2021 •
edited by github-actions bot
Loading

/publish connector=connectors/source-gitlab-singer

🕑 connectors/source-gitlab-singer https://github.com/airbytehq/airbyte/actions/runs/999837439
❌ connectors/source-gitlab-singer https://github.com/airbytehq/airbyte/actions/runs/999837439

@davinchia
Copy link
Contributor

davinchia commented Jul 5, 2021 •
edited by github-actions bot
Loading

/publish connector=connectors/source-gitlab-singer

🕑 connectors/source-gitlab-singer https://github.com/airbytehq/airbyte/actions/runs/999862168
❌ connectors/source-gitlab-singer https://github.com/airbytehq/airbyte/actions/runs/999862168

@davinchia
Copy link
Contributor

davinchia commented Jul 5, 2021 •
edited by github-actions bot
Loading

/publish connector=connectors/source-gitlab-singer

🕑 connectors/source-gitlab-singer https://github.com/airbytehq/airbyte/actions/runs/1000078397
❌ connectors/source-gitlab-singer https://github.com/airbytehq/airbyte/actions/runs/1000078397

@davinchia
Copy link
Contributor

davinchia commented Jul 5, 2021 •
edited by github-actions bot
Loading

/test connector=connectors/source-gitlab-singer

🕑 connectors/source-gitlab-singer https://github.com/airbytehq/airbyte/actions/runs/1000088414
✅ connectors/source-gitlab-singer https://github.com/airbytehq/airbyte/actions/runs/1000088414

@davinchia
Copy link
Contributor

davinchia commented Jul 5, 2021 •
edited by github-actions bot
Loading

/test connector=connectors/source-gitlab-singer

🕑 connectors/source-gitlab-singer https://github.com/airbytehq/airbyte/actions/runs/1000110763
❌ connectors/source-gitlab-singer https://github.com/airbytehq/airbyte/actions/runs/1000110763

@davinchia
Copy link
Contributor

davinchia commented Jul 5, 2021 •
edited by github-actions bot
Loading

/publish connector=connectors/source-gitlab-singer

🕑 connectors/source-gitlab-singer https://github.com/airbytehq/airbyte/actions/runs/1000153231
❌ connectors/source-gitlab-singer https://github.com/airbytehq/airbyte/actions/runs/1000153231

@davinchia
Copy link
Contributor

davinchia commented Jul 5, 2021 •
edited by github-actions bot
Loading

/publish connector=connectors/source-gitlab-singer

🕑 connectors/source-gitlab-singer https://github.com/airbytehq/airbyte/actions/runs/1000253920
❌ connectors/source-gitlab-singer https://github.com/airbytehq/airbyte/actions/runs/1000253920

@davinchia
Copy link
Contributor

davinchia commented Jul 5, 2021 •
edited by github-actions bot
Loading

/publish connector=connectors/source-gitlab-singer

🕑 connectors/source-gitlab-singer https://github.com/airbytehq/airbyte/actions/runs/1000308081
❌ connectors/source-gitlab-singer https://github.com/airbytehq/airbyte/actions/runs/1000308081

@davinchia
Copy link
Contributor

davinchia commented Jul 5, 2021 •
edited by github-actions bot
Loading

/test connector=connectors/source-slack-singer

🕑 connectors/source-slack-singer https://github.com/airbytehq/airbyte/actions/runs/1000444737
❌ connectors/source-slack-singer https://github.com/airbytehq/airbyte/actions/runs/1000444737

@davinchia davinchia changed the title Source Gitlab: add entrypoint and bump version Add entrypoint and bump version for remaining connectors. Jul 5, 2021
@github-actions github-actions bot added the area/documentation Improvements or additions to documentation label Jul 5, 2021
@davinchia
Copy link
Contributor

davinchia commented Jul 5, 2021 •
edited by github-actions bot
Loading

/publish connector=connectors/source-gitlab-singer

🕑 connectors/source-gitlab-singer https://github.com/airbytehq/airbyte/actions/runs/1001061623
❌ connectors/source-gitlab-singer https://github.com/airbytehq/airbyte/actions/runs/1001061623

@davinchia
Copy link
Contributor

davinchia commented Jul 5, 2021 •
edited by github-actions bot
Loading

/publish connector=connectors/source-gitlab-singer

🕑 connectors/source-gitlab-singer https://github.com/airbytehq/airbyte/actions/runs/1001105475
❌ connectors/source-gitlab-singer https://github.com/airbytehq/airbyte/actions/runs/1001105475

@davinchia
Copy link
Contributor

davinchia commented Jul 5, 2021 •
edited by github-actions bot
Loading

/publish connector=connectors/source-gitlab-singer

🕑 connectors/source-gitlab-singer https://github.com/airbytehq/airbyte/actions/runs/1001132189
❌ connectors/source-gitlab-singer https://github.com/airbytehq/airbyte/actions/runs/1001132189

@davinchia
Copy link
Contributor

davinchia commented Jul 5, 2021 •
edited by github-actions bot
Loading

/publish connector=connectors/source-gitlab-singer

🕑 connectors/source-gitlab-singer https://github.com/airbytehq/airbyte/actions/runs/1001144501
❌ connectors/source-gitlab-singer https://github.com/airbytehq/airbyte/actions/runs/1001144501

@davinchia
Copy link
Contributor

davinchia commented Jul 6, 2021 •
edited by github-actions bot
Loading

/publish connector=connectors/source-quickbooks-singer run-tests=false

🕑 connectors/source-quickbooks-singer https://github.com/airbytehq/airbyte/actions/runs/1003066257
✅ connectors/source-quickbooks-singer https://github.com/airbytehq/airbyte/actions/runs/1003066257

@davinchia
Copy link
Contributor

davinchia commented Jul 6, 2021 •
edited by github-actions bot
Loading

/publish connector=connectors/source-posthog run-tests=false

🕑 connectors/source-posthog https://github.com/airbytehq/airbyte/actions/runs/1003066823
✅ connectors/source-posthog https://github.com/airbytehq/airbyte/actions/runs/1003066823

@davinchia davinchia mentioned this pull request Jul 6, 2021
Merged
26 tasks
@davinchia
Copy link
Contributor

@marcosmarxm apart from 'deprecated' connector, this is done!

jrhizor
jrhizor reviewed Jul 6, 2021
View reviewed changes
buildSrc/src/main/groovy/airbyte-python.gradle
@@ -25,7 +25,7 @@ class AirbytePythonPlugin implements Plugin<Project> {
pip 'mypy:0.812'
pip 'isort:5.6.4'
pip 'pytest:6.1.2'
pip 'pip:21.1'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was there a reason to upgrade this?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Initially testing to see if upgrading pip would get rid of our errors, since wheels are sometimes available in later version. It did not.

Now I'm keeping it because it works so why not :)

@jrhizor jrhizor self-requested a review July 6, 2021 17:06
jrhizor
jrhizor approved these changes Jul 6, 2021
View reviewed changes
Copy link
Contributor

@jrhizor jrhizor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there anything blocking us from resolving the merge conflict and getting this in?

@davinchia
Copy link
Contributor

davinchia commented Jul 7, 2021 •
edited by github-actions bot
Loading

/publish connector=connectors/source-gitlab

🕑 connectors/source-gitlab https://github.com/airbytehq/airbyte/actions/runs/1007213551
✅ connectors/source-gitlab https://github.com/airbytehq/airbyte/actions/runs/1007213551

@davinchia
Copy link
Contributor

davinchia commented Jul 7, 2021 •
edited by github-actions bot
Loading

/publish connector=connectors/source-google-adwords-singer run-tests=false

🕑 connectors/source-google-adwords-singer https://github.com/airbytehq/airbyte/actions/runs/1007225154
✅ connectors/source-google-adwords-singer https://github.com/airbytehq/airbyte/actions/runs/1007225154

@davinchia davinchia merged commit 6201100 into master Jul 7, 2021
@davinchia davinchia deleted the marcosmarxm/airbyte-entrypoint-gitlab branch July 7, 2021 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davinchia davinchia davinchia left review comments

@jrhizor jrhizor jrhizor approved these changes

Assignees
No one assigned
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/aws-cloudtrail connectors/source/braintree connectors/sources-api
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@marcosmarxm @davinchia @jrhizor @igrankova @ycherniaiev