Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ TikTok Marketing Source: Add SparkAds Stream #45081

Merged
merged 24 commits into from
Mar 9, 2025
Merged

✨ TikTok Marketing Source: Add SparkAds Stream #45081

merged 24 commits into from
Mar 9, 2025

Conversation

topefolorunso
Copy link
Collaborator

What

Add spark ads to populate video_id and image_id closes airbytehq/airbyte-internal-issues#9726

How

Review guide

User Impact

Can this PR be safely reverted and rolled back?

  • YES 💚
  • NO ❌

@vercel Vercel
Copy link

vercel bot commented Sep 2, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 9, 2025 4:46pm

@octavia-squidington-iii octavia-squidington-iii added area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/tiktok-marketing labels Sep 2, 2024
@topefolorunso
Copy link
Collaborator Author

topefolorunso commented Sep 2, 2024 •
edited by github-actions bot
Loading

/format-fix

Format-fix job started... Check job output.

🟦 Job completed successfully (no changes).

@topefolorunso
Copy link
Collaborator Author

topefolorunso commented Sep 18, 2024 •
edited by github-actions bot
Loading

/format-fix

Format-fix job started... Check job output.

✅ Changes applied successfully. (bca1ef8)

@topefolorunso
Copy link
Collaborator Author

@ChristoGrab @natikgadzhi

@ChristoGrab
Copy link
Contributor

Poetry lockfile was out of sync so the build failed. Updated, waiting on CI to complete.

@natikgadzhi
Copy link
Contributor

@topefolorunso I'd be happy to refresh this too — I have capacity to review a few things, hit me up

@topefolorunso
Copy link
Collaborator Author

All good here @natikgadzhi. Only test failing is due to expected records which I'll populate once I get test creds

@natikgadzhi
Copy link
Contributor

Hmmmm. Can you add the stream to ignores in acceptance test config? We won't actually have test data for this stream anyway. Once you add the ignore, we can merge this.

@topefolorunso
Copy link
Collaborator Author

All good here @natikgadzhi

@natikgadzhi natikgadzhi merged commit dc28f8d into master Mar 9, 2025
28 checks passed
@natikgadzhi natikgadzhi deleted the tope/tiktok-marketing/add-sparkAds-stream branch March 9, 2025 22:21
@natikgadzhi
Copy link
Contributor

Nice! Good to see these going in over the weekend @topefolorunso ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@natikgadzhi natikgadzhi natikgadzhi approved these changes

@ChristoGrab ChristoGrab Awaiting requested review from ChristoGrab

Assignees
No one assigned
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/tiktok-marketing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@topefolorunso @ChristoGrab @natikgadzhi @octavia-squidington-iii