Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[source-postgres] use tcpAlive=true to make JDBC connection more robust upon backpressure #44878

Merged
merged 3 commits into from
Aug 30, 2024

Conversation

theyueli
Copy link
Contributor

@theyueli theyueli commented Aug 28, 2024

What

A possible improvement which will make JDBC connection not get dropped when there is backpressure.

Related to https://github.com/airbytehq/airbyte-internal-issues/issues/7

Solves part of https://github.com/airbytehq/oncall/issues/6315

Can this PR be safely reverted and rolled back?

  • [x ] YES 💚
  • NO ❌

@theyueli theyueli self-assigned this Aug 28, 2024
@theyueli theyueli requested a review from a team as a code owner August 28, 2024 23:26
Copy link

vercel bot commented Aug 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Aug 30, 2024 6:06pm

@evantahler
Copy link
Contributor

This is one of the solutions to https://github.com/airbytehq/oncall/issues/6315

@rodireich
Copy link
Contributor

Looks good to me (I was under the impression we already had keepalive turned on in the JDBC connection).
You might want to consider, or later consider doing this on the hikari pool config

config.keepaliveTime = ???

@theyueli
Copy link
Contributor Author

hikari pool config

Looks good to me (I was under the impression we already had keepalive turned on in the JDBC connection). You might want to consider, or later consider doing this on the hikari pool config

config.keepaliveTime = ???

@rodireich great finding!! Do you know what value we shall set? I was overwhelmed by these parameters, there is another one called idle timeout ... is that related?

https://docs.oracle.com/cd/E19159-01/819-3681/abehq/index.html

@theyueli theyueli merged commit f502315 into master Aug 30, 2024
35 checks passed
@theyueli theyueli deleted the yue/pg-keepalive branch August 30, 2024 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/postgres retrospective
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants