Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Github adjustments #43

Merged
merged 9 commits into from
Aug 12, 2020
Merged

Github adjustments #43

merged 9 commits into from
Aug 12, 2020

Conversation

michel-tricot
Copy link
Contributor

@michel-tricot michel-tricot commented Aug 12, 2020

Changes

Several github adjustments

Checklist

  • Fail build if style hasn't been properly applied
  • Add 2 issue templates (bug, enhancement)
  • Add PR template
  • Cache deps in github actions

@@ -0,0 +1,9 @@
## Changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this template have:

  1. What problem is this change solving? (if there is an issue, link to it and no need to describe)
  2. What's the solution being applied?
  3. How should I read the files in this change/which are the most important ones?

I definitely don't want it to be heavyweight but I find that I often have to reverse engineer all these things from the flat code/files which, if there is more than 1 reviewer, can be a time drain.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops merge too quickly. Will add that tmw

labels: enhancement

---
## Describe the solution you'd like
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

amazing 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants