Notify commit owner via slack message #37803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced May 3, 2024
alafanechere
approved these changes
May 6, 2024
Comment on lines
+435
to
+436
| user_identifier=user_identifier, | ||
| commit_sha=commit_sha, |
There was a problem hiding this comment.
The type hints on the log method are not accurate, they should be str | None instead of str for these two parameters.
| """ | ||
| Generate the registry entry files from the given metadata file, and persist it to GCS. | ||
| """ | ||
| if not metadata_entry: | ||
| # if the metadata entry is invalid, return an empty dict | ||
| return Output(metadata={"empty_metadata": True}, value=None) | ||
|
|
||
| user_identifier = safe_get_slack_user_identifier(airbyte_slack_users, metadata_entry.metadata_definition) |
There was a problem hiding this comment.
(I'm not 💯 sure user_identifier makes it way to the registry, might be just used to log, feel free to ignore my comment then)
We'll publish contributors email (both airbyters and external contributors) to our registry, shall we be concerned about exposing these? Git info are public but not sure that as a contributor I'd expect my email to be publicaly available in our online registry.
bnchrch
force-pushed
the
bnchrch/registry/add-git-commit-info
branch
from
7e76b6c to
219e7b5
Compare
bnchrch
force-pushed
the
bnchrch/registry/add-slack-tag-notifiation
branch
from
2b03faf to
d5ce17d
Compare
bnchrch
force-pushed
the
bnchrch/registry/add-git-commit-info
branch
from
219e7b5 to
5f9a6b9
Compare
bnchrch
force-pushed
the
bnchrch/registry/add-slack-tag-notifiation
branch
from
d5ce17d to
78f8640
Compare
bnchrch
force-pushed
the
bnchrch/registry/add-slack-tag-notifiation
branch
from
78f8640 to
9c54656
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Updates our slack lifecycle notifications to mention the author of the metadata change on slack
Spun out of #32715 as a stack